Giter Club home page Giter Club logo

Comments (6)

ADDISON74 avatar ADDISON74 commented on July 30, 2024 1

Excellent job. After using ImaClean for almost 8 years I found a new flavor thanks to you.

When pressing [Cancella] link you should ask "Are you sure?" like in Mass Delete actions. I posted an issue for this.

from openmage-image-cleaner.

fballiano avatar fballiano commented on July 30, 2024
  1. not really but at the same time it's a way to recognize new/old images based on the ID. also, filename could by duplicated on different content_type_id so we'd have to use a double column key which I think it's not even possible in magento's grids (btw I'd still prefer to have the ID key like every other magento's model).
  2. mmm depends on the kind of images, for my customers it may be difficult to recognize a smaller image so I wouldn't go less than 200, at the same time we could make it configurable...
  3. header was added
  4. if I add the download action I think there should be a massDownload action, which may be challanging (big zip size, timeouts, how to delete the ZIP file after download) so I thought that it would be better not to have a download at all... anyways it's something easy to add

from openmage-image-cleaner.

fballiano avatar fballiano commented on July 30, 2024

I was trying to add the download action but, when there are multiple actions the column itself renders as combobox:
Schermata 2021-04-10 alle 23 27 36

which is extremely uncomfortable to use so that's a no.

then I tried add multiple action columns:
Schermata 2021-04-10 alle 23 29 52

but that it also ugly (and I'd remove the headers which don't make any sense in that case)

so.. mmmm I'm wondering what makes more sense

from openmage-image-cleaner.

fballiano avatar fballiano commented on July 30, 2024

I created a rendered and it's now nice and working:

Schermata 2021-04-11 alle 00 49 18

I decided to keep the "delete" link as last cause I think it's the most used and easiest to click

from openmage-image-cleaner.

fballiano avatar fballiano commented on July 30, 2024

I've created #10 to remind me about the thumb size ;-)

from openmage-image-cleaner.

fballiano avatar fballiano commented on July 30, 2024

thumbnail size is now configurable ;-)

from openmage-image-cleaner.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.