Giter Club home page Giter Club logo

Comments (4)

fballiano avatar fballiano commented on July 30, 2024 1

As written in the README I check images in:

  • cms_block
  • cms_pages
  • core_email_templates
  • all CSS files in /skin
    because I need to avoid false positives as much as possible (that's the problem I always had with other extensions)..

about custom extensions, we'll never be able to support all of them, btw I hope they don't just use media/wysiwyg but instead they use media/extensionname or something like that.

we can try to support some of them but it will never be complete. at the same time, you could reference a product image in a static block... that condition will never be detected by any extension like this one, it would really become too difficult.

on my customers' stores I'd never "auto clean" WYSYWYG but I'd use the feature just as a double check to clear very old stuff (actually maybe it would be nice to show the filedate) because it will never be 100% safe (but neither the product/category ones although I also check custom EAV attributes and not only system ones).

hope I didn't forget anything :-)

from openmage-image-cleaner.

ADDISON74 avatar ADDISON74 commented on July 30, 2024

I forgot to mention /media/wysiwyg folder content can be checked in Magento Backend. Anyone can delete folders and images manually. But for products and categories it is a little bit complicated.

from openmage-image-cleaner.

fballiano avatar fballiano commented on July 30, 2024

problems should be fixed, thanks for the report!

I know that wysiwyg can be managed by the backend, but in my 11 years with magento nobody does (cause they're worried about deleting used images/files) so it grows without limits, that's why I'm trying to write this feature.

from openmage-image-cleaner.

ADDISON74 avatar ADDISON74 commented on July 30, 2024

We must continue testing this feature. Have you considered using images in blocks, product description or elsewhere than CMS pages? In the case of products and categories, things are clear, but here once an image is deleted there is a risk of missing it in a page in the frontend. If someone uses a block-based extension like Aheadworks Z-Blocks and put his images in this folder he will have a problem if not revising the images and doing a mass delete action.

You can evaluate all places where images are used but for Magento only and provide a warning in extension page about this issue.

from openmage-image-cleaner.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.