Giter Club home page Giter Club logo

Comments (7)

fballiano avatar fballiano commented on June 23, 2024 1

better, all done already

from openmage-image-cleaner.

ADDISON74 avatar ADDISON74 commented on June 23, 2024

... or we can extend the Actions column with a new link:

Open | Download | Delete

from openmage-image-cleaner.

fballiano avatar fballiano commented on June 23, 2024

I think it's uncomfortable to open it in the same window, but anyway at the moment I added the configuration and modified the template, still didn't add a separate action cause it's way easier for people to click on the image rather than a link, which is way smaller and sometimes may be misaligned if compared to the image ;-)

from openmage-image-cleaner.

ADDISON74 avatar ADDISON74 commented on June 23, 2024

My suggestion wasn't about opening the image in the same window which is really annoying. It is exactly the same behavior as before with the request of enable/disable this feature or make it visible as an Actions.

from openmage-image-cleaner.

ADDISON74 avatar ADDISON74 commented on June 23, 2024

Based on a configuration value Yes/Now will add/delete that tag for the image. It is disabling the click on the image.

from openmage-image-cleaner.

fballiano avatar fballiano commented on June 23, 2024

done, enabled by default

from openmage-image-cleaner.

ADDISON74 avatar ADDISON74 commented on June 23, 2024

Once you implemented this feature I would remove the code related to <how_to_open_image>new</how_to_open_image>. It is no longer relevant and the implementation resulted from a misunderstanding of the request.

When the link is activated it should always open the image in a new window. As I said, it's annoying to open it in the same window.

from openmage-image-cleaner.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.