facile-it / functionalkit Goto Github PK

We should add .zip definitions for more that 2 elements to all the types that expose a Cartesian conformance.

This can be safely and generically done for Array (it's actually .cartesian there), Future, Optional. For types with a secondary parameter (like ErrorType for Result), because the default behavior for .zip is not opinionated and preserves data via particular data structures, only the special .zip definitions can be enhanced with more that 2 elements. For Reader and State we can implement the enhancement to both the base non opinionated .zip and the more convenient zipCommon.

The continuation callback of Future contains the side effects produced when it's started, thus the Future has a strong reference to this callback. It seems like that after .start() is called, that is, after the continuation is executed, we should release its memory. This should change shouldn't break the tests.