Giter Club home page Giter Club logo

Comments (22)

alanjhughes avatar alanjhughes commented on May 26, 2024 1

@timbabs1 - should be out in a few hours

from expo.

alanjhughes avatar alanjhughes commented on May 26, 2024 1

@timbabs1 just minor version bump to the camera package. This PR will be labeled as published when it's out

from expo.

alanjhughes avatar alanjhughes commented on May 26, 2024 1

@timbabs1 new version has been published

from expo.

alanjhughes avatar alanjhughes commented on May 26, 2024 1

@pablobarreraf - For now, but there will be a new version of expo go released soon. Sidenote, you should not be using expo go to develop you entire project. It is purely a playground app for learning and testing. Development builds avoid these limitations and you can get the latest fixes as soon as they are published

from expo.

alanjhughes avatar alanjhughes commented on May 26, 2024

Hi @timbabs1 - The issue is with the documentation. The max recording duration is not in seconds but milliseconds. You have it set to 5 which is too small and this is causing the error. I'll update the documentation

from expo.

alanjhughes avatar alanjhughes commented on May 26, 2024

@timbabs1 - This PR should fix the problem. I didn't handle the maxDuration correctly on android. Sorry for the inconvenience.

from expo.

timbabs1 avatar timbabs1 commented on May 26, 2024

Ah I see, nice thats alright. So for now should we set it in milliseconds for android until that PR is merged?

@alanjhughes

from expo.

alanjhughes avatar alanjhughes commented on May 26, 2024

@timbabs1 - Yes, but even then it'll return an incorrect error when it exceeds the duration. The PR will be merged soon and published later. Your not using expo go?

from expo.

timbabs1 avatar timbabs1 commented on May 26, 2024

@alanjhughes Well for the Minimal reproducible example I have used expo go but in the project I am working on no, I am using a development build

And oh okay, when might this be published?

from expo.

timbabs1 avatar timbabs1 commented on May 26, 2024

@alanjhughes is there anyway I can be notified when this is published?

And would it be a minor version bump for expo or the camera module?

from expo.

timbabs1 avatar timbabs1 commented on May 26, 2024

@alanjhughes Thanks, noted

from expo.

timbabs1 avatar timbabs1 commented on May 26, 2024

Ah thanks I will check it soon

from expo.

timbabs1 avatar timbabs1 commented on May 26, 2024

Hi @alanjhughes so testing this, it works fine now when just recording and manually cancelling, but it doesn't work when you set the max duration for the video :(

I have also pushed the update to the reproduction repo

from expo.

alanjhughes avatar alanjhughes commented on May 26, 2024

@timbabs1 did you change the duration? I see you have 5000 set on android which will be 5000 seconds

from expo.

alanjhughes avatar alanjhughes commented on May 26, 2024

Should have mentioned that I made it correctly accept seconds like iOS does

from expo.

timbabs1 avatar timbabs1 commented on May 26, 2024

Right @alanjhughes but setting 5 causes it to crash immediately with the Error recording video [Error: Video recording failed: Video recording Failed: Unknown error]

from expo.

alanjhughes avatar alanjhughes commented on May 26, 2024

@timbabs1 I just pulled your repro again and it's working fine. Are you using expo go?

from expo.

alanjhughes avatar alanjhughes commented on May 26, 2024

Also noticed your ref is incorrect. You can just do this

  const cameraRef = useRef<CameraView>(null);

from expo.

timbabs1 avatar timbabs1 commented on May 26, 2024

Hi @alanjhughes yes I am using expo go and have updated the ref. Changes have been push

Are you using expo go as well?

from expo.

alanjhughes avatar alanjhughes commented on May 26, 2024

No, this change will not be in expo go. It is not updated frequently. You will need to use a development builds to get the latest changes

from expo.

timbabs1 avatar timbabs1 commented on May 26, 2024

@alanjhughes Ah yes I can see the change after updating expo dev client. It works now, many thanks! :)

from expo.

pablobarreraf avatar pablobarreraf commented on May 26, 2024

sorry to interjet but does this mean that it will work on a development build only? and not debugging on my local connected to the expo go app?

from expo.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.