[expo-av][iOS] Duck / unduck is not working properly on iOS about expo HOT 4 OPEN

Just my two cents, I agree #16578 has caused this regression which it seems I did worry about at the time.

It's been years since I've done anything with the expo sdk or objective-c, but I'd suggest at least the session setActive call and potentially all the session calls or the whole _updateSessionConfiguration method should be made async and queued with dispatch_async.
I'm not sure how you'd refactor the module since it expects several methods to return NSError, presumably there is a way to notify the js of an error that wasn't directly in response to js call.

For example something like this should resolve ducking and not cause framedrops, but I haven't made any attempt to handle potential errors and I'm not sure the EX_* stuff is correct.

if (!shouldBeActive && _sessionIsActive) {
  EX_WEAKIFY(self);
  dispatch_async(dispatch_get_main_queue(), ^{
    EX_ENSURE_STRONGIFY(self);
    
    NSError *error;
    [session setActive:NO error:&error];
    if (!error) {
      self->_sessionIsActive = NO;
    }
    // Does not handle the error
  });
}

from expo.

Experiencing the same issue

from expo.

Was someone able to fix this problem?

from expo.

Same!

from expo.