Giter Club home page Giter Club logo

pubg-replay-manager's People

Contributors

aaa4xu avatar epickitten avatar mastergroosha avatar swreeser avatar

Stargazers

 avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar

Watchers

 avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar

pubg-replay-manager's Issues

High DPI glitch

On my computer all buttons are cut off, using "custom dpi settings" with 125% (not the windows-native 125% as this makes some programmes blurry)

grafik

Window resizing issue

Initial Size at startup:

pubg-r-m-1

As soon as I choose a replay:

pubg-r-m-2

The window is not manually resizable.
My Windows DPI Setting is set to 125%, don't know if this is causing the issue

Implement proper parsing of serialized Unreal strings

I think the parsing of Unreal engine serialized strings (groggy, kill, replayinfo, level, ReplaySummary) could be improved. The current implementation doesn't seem to be causing problems now, but this is the "proper" way to read these files so it doesn't break in the future.

See my implementation here. Here's some pseudocode that might help based on the actual Unreal engine implementation of network demos:

  • read the first 4 bytes of the file as a little-endian unsigned 32-bit integer
  • read that many bytes from the file
  • if the final byte read was a 0, remove it
  • if the data read was obfuscated (kill, groggy, level, ReplaySummary), set each byte to (x + 1) & 0xff
  • deserialize the resulting data as JSON

Crash on deleted replay artifact

Had an error loading the project up the first time. Went away when I deleted the older replay files in AppData

System.IO.FileNotFoundException
  HResult=0x80070002
  Message=Could not find file 'C:\Users\user\AppData\Local\TslGame\Saved\Demos\match.bro.official.2017-pre6.na.duo.2017.12.08.612d9b1e-f211-4f03-8cc4-0df9f1d3c084__USER__76561198058777702\PUBG.replayinfo'.
  Source=mscorlib
  StackTrace:
   at System.IO.__Error.WinIOError(Int32 errorCode, String maybeFullPath)
   at System.IO.FileStream.Init(String path, FileMode mode, FileAccess access, Int32 rights, Boolean useRights, FileShare share, Int32 bufferSize, FileOptions options, SECURITY_ATTRIBUTES secAttrs, String msgPath, Boolean bFromProxy, Boolean useLongPath, Boolean checkHost)
   at System.IO.FileStream..ctor(String path, FileMode mode, FileAccess access, FileShare share, Int32 bufferSize, FileOptions options, String msgPath, Boolean bFromProxy, Boolean useLongPath, Boolean checkHost)
   at System.IO.File.InternalReadAllBytes(String path, Boolean checkHost)
   at PUBG_Replay_Manager.Main.UE4StringSerializer(String file_path, Boolean encoded, Int32 encoded_offset) in D:\dev\pubgrm\PUBG_Replay_Manager\Main.cs:line 497
   at PUBG_Replay_Manager.Main.ReadReplayInfo(String directory_of_recording) in D:\dev\pubgrm\PUBG_Replay_Manager\Main.cs:line 544
   at PUBG_Replay_Manager.Main.RefreshReplayList() in D:\dev\pubgrm\PUBG_Replay_Manager\Main.cs:line 54
   at PUBG_Replay_Manager.Main.replayListRefresh_Click(Object sender, EventArgs e) in D:\dev\pubgrm\PUBG_Replay_Manager\Main.cs:line 913
   at System.Windows.Forms.Control.OnClick(EventArgs e)
   at System.Windows.Forms.Button.OnClick(EventArgs e)
   at System.Windows.Forms.Button.OnMouseUp(MouseEventArgs mevent)
   at System.Windows.Forms.Control.WmMouseUp(Message& m, MouseButtons button, Int32 clicks)
   at System.Windows.Forms.Control.WndProc(Message& m)
   at System.Windows.Forms.ButtonBase.WndProc(Message& m)
   at System.Windows.Forms.Button.WndProc(Message& m)
   at System.Windows.Forms.NativeWindow.DebuggableCallback(IntPtr hWnd, Int32 msg, IntPtr wparam, IntPtr lparam)
   at System.Windows.Forms.UnsafeNativeMethods.DispatchMessageW(MSG& msg)
   at System.Windows.Forms.Application.ComponentManager.System.Windows.Forms.UnsafeNativeMethods.IMsoComponentManager.FPushMessageLoop(IntPtr dwComponentID, Int32 reason, Int32 pvLoopData)
   at System.Windows.Forms.Application.ThreadContext.RunMessageLoopInner(Int32 reason, ApplicationContext context)
   at System.Windows.Forms.Application.ThreadContext.RunMessageLoop(Int32 reason, ApplicationContext context)
   at PUBG_Replay_Manager.Program.Main() in D:\dev\pubgrm\PUBG_Replay_Manager\Program.cs:line 17
$ dir C:/Users/user/AppData/Local/TslGame/Saved/Demos
match.bro.official.2017-pre6.na.duo.2017.12.08.612d9b1e-f211-4f03-8cc4-0df9f1d3c084__USER__76561198058777702
match.bro.official.2017-pre6.na.duo.2017.12.09.07a562ae-b0d2-4200-b561-78857b414e4c__USER__76561198058777702
match.bro.official.2017-pre6.na.duo.2017.12.11.f064be80-992b-4c8f-8707-4dfacfc07c60__USER__76561198058777702
match.bro.official.2017-pre6.na.duo.2017.12.11.f0f94fb8-6bca-4c2a-9df4-e756aa6ce906__USER__76561198058777702
match.bro.official.2017-pre6.na.solo-fpp.2017.12.08.0f672e5f-a939-4c81-b19a-9b35b03cfb50__USER__76561198058777702
match.bro.official.2018-02.as.duo.2018.02.18.03dc150a-8c16-4179-8bd8-2130eb72d7c3__USER__8c1b0bc4d5b75f60b85192638f2863f0
match.bro.official.2018-02.na.duo.2018.02.09.64df1099-7be3-47bb-8681-215c0709b4e6__USER__8c1b0bc4d5b75f60b85192638f2863f0
match.bro.official.2018-02.na.duo.2018.02.14.5210ce3f-cd32-493b-a012-bb0f44ec62a3__USER__8c1b0bc4d5b75f60b85192638f2863f0
match.bro.official.2018-02.na.duo.2018.02.20.779b9439-6c7c-4f4b-a971-de5065df78f7__USER__8c1b0bc4d5b75f60b85192638f2863f0
match.bro.official.2018-02.na.duo.2018.02.21.5a741a4d-38aa-46ef-91c4-1a8b0898640d__USER__8c1b0bc4d5b75f60b85192638f2863f0
match.bro.official.2018-02.na.duo.2018.02.21.bd796a96-e354-4087-bbcd-8dcfe54f3ffc__USER__8c1b0bc4d5b75f60b85192638f2863f0
...

The "2017" directories just contained a checkpoints directory with a checkpoints## file in it.

Item Loot

Hey,

Loving your work man, very much appreciated for you doing this.

I was looking to see if I could extract the looted item data during the replay but assume thats held in the .demo file, which I think you mentioned can't be read yet ?

Cheers

Export ALL Replays just deletes any replay

The option to export all Replays just deletes any present replay.

Please check the exportallreplays_Click method its the same as the clearallreplays_Click exept for the different string shown within the confirmation box.

Luckily I backuped my replace manually in the first place

Crash on deleting replay

Did this three times in a row. When I delete a replay the manager crashes.

Tried to delete a replay:
match.bro.official.2018-02.na.squad.2018.02.21.4e8e7417-f152-4a26-b38f-e4e0f0d36af9__USER__8c1b0bc4d5b75f60b85192638f2863f0

Got an error:

System.IO.DirectoryNotFoundException
  HResult=0x80070003
  Message=Could not find a part of the path 'C:\Users\user\AppData\Local\TslGame\Saved\Demos\match.bro.official.2018-02.na.squad.2018.02.21.4e8e7417-f152-4a26-b38f-e4e0f0d36af9__USER__8c1b0bc4d5b75f60b85192638f2863f0'.
  Source=mscorlib
  StackTrace:
   at System.IO.__Error.WinIOError(Int32 errorCode, String maybeFullPath)
   at System.IO.FileSystemEnumerableIterator`1.CommonInit()
   at System.IO.FileSystemEnumerableIterator`1..ctor(String path, String originalUserPath, String searchPattern, SearchOption searchOption, SearchResultHandler`1 resultHandler, Boolean checkHost)
   at System.IO.Directory.GetDirectories(String path)
   at PUBG_Replay_Manager.Main.GetDirectorySize(String directory) in D:\dev\pubgrm\PUBG_Replay_Manager\Main.cs:line 775
   at PUBG_Replay_Manager.Main.ReadReplayInfo(String directory_of_recording) in D:\dev\pubgrm\PUBG_Replay_Manager\Main.cs:line 655
   at PUBG_Replay_Manager.Main.RefreshReplayList() in D:\dev\pubgrm\PUBG_Replay_Manager\Main.cs:line 54
   at PUBG_Replay_Manager.Main.deletereplay_Click(Object sender, EventArgs e) in D:\dev\pubgrm\PUBG_Replay_Manager\Main.cs:line 851
   at System.Windows.Forms.Control.OnClick(EventArgs e)
   at System.Windows.Forms.Button.OnClick(EventArgs e)
   at System.Windows.Forms.Button.OnMouseUp(MouseEventArgs mevent)
   at System.Windows.Forms.Control.WmMouseUp(Message& m, MouseButtons button, Int32 clicks)
   at System.Windows.Forms.Control.WndProc(Message& m)
   at System.Windows.Forms.ButtonBase.WndProc(Message& m)
   at System.Windows.Forms.Button.WndProc(Message& m)
   at System.Windows.Forms.NativeWindow.DebuggableCallback(IntPtr hWnd, Int32 msg, IntPtr wparam, IntPtr lparam)
   at System.Windows.Forms.UnsafeNativeMethods.DispatchMessageW(MSG& msg)
   at System.Windows.Forms.Application.ComponentManager.System.Windows.Forms.UnsafeNativeMethods.IMsoComponentManager.FPushMessageLoop(IntPtr dwComponentID, Int32 reason, Int32 pvLoopData)
   at System.Windows.Forms.Application.ThreadContext.RunMessageLoopInner(Int32 reason, ApplicationContext context)
   at System.Windows.Forms.Application.ThreadContext.RunMessageLoop(Int32 reason, ApplicationContext context)
   at PUBG_Replay_Manager.Program.Main() in D:\dev\pubgrm\PUBG_Replay_Manager\Program.cs:line 17

Wrong map name, mode and weather.

For some reason, your app shows incorrect map name (always Miramar), incorrect mode (always Squad) and doesn't show weather data.

System.IO.DirectoryNotFoundException when deleting a replay

Hello - really appreciate the work on the replay manager.
Since I updated to 1.0, I cannot delete a replay without the following exception. The list of replays disappears and continuing after the exception does not reload the list. I must quit and reload the program each time I want to delete. I don't have any special control access through Windows on. Something weird on my end?

Thanks.

See the end of this message for details on invoking
just-in-time (JIT) debugging instead of this dialog box.

************** Exception Text **************
System.IO.DirectoryNotFoundException: Could not find a part of the path 'C:\Users\HeliMagnet\AppData\Local\TslGame\Saved\Demos\match.bro.official.2018-03.na.duo-fpp.2018.03.09.5bdecb0b-f761-4d25-b309-c8b91d216b7a__USER__9e0b01130a33cc40d4e24cc33ac1654c'.
at System.IO.__Error.WinIOError(Int32 errorCode, String maybeFullPath)
at System.IO.FileSystemEnumerableIterator`1.CommonInit()
at System.IO.Directory.GetDirectories(String path)
at PUBG_Replay_Manager.Main.GetDirectorySize(String directory)
at PUBG_Replay_Manager.Main.ReadReplayInfo(String directory_of_recording)
at PUBG_Replay_Manager.Main.RefreshReplayList()
at PUBG_Replay_Manager.Main.deletereplay_Click(Object sender, EventArgs e)
at System.Windows.Forms.Control.OnClick(EventArgs e)
at System.Windows.Forms.Button.OnClick(EventArgs e)
at System.Windows.Forms.Button.OnMouseUp(MouseEventArgs mevent)
at System.Windows.Forms.Control.WmMouseUp(Message& m, MouseButtons button, Int32 clicks)
at System.Windows.Forms.Control.WndProc(Message& m)
at System.Windows.Forms.ButtonBase.WndProc(Message& m)
at System.Windows.Forms.Button.WndProc(Message& m)
at System.Windows.Forms.NativeWindow.Callback(IntPtr hWnd, Int32 msg, IntPtr wparam, IntPtr lparam)

************** Loaded Assemblies **************
mscorlib
Assembly Version: 4.0.0.0
Win32 Version: 4.7.2633.0 built by: NET471REL1LAST_C
CodeBase: file:///C:/Windows/Microsoft.NET/Framework64/v4.0.30319/mscorlib.dll

PUBG_Replay_Manager
Assembly Version: 1.0.0.0
Win32 Version: 1.0.0.0
CodeBase: file:///E:/Gaming/PUBG_Replay_Manager_v1.0.exe

System.Windows.Forms
Assembly Version: 4.0.0.0
Win32 Version: 4.7.2556.0 built by: NET471REL1
CodeBase: file:///C:/WINDOWS/Microsoft.Net/assembly/GAC_MSIL/System.Windows.Forms/v4.0_4.0.0.0__b77a5c561934e089/System.Windows.Forms.dll

System
Assembly Version: 4.0.0.0
Win32 Version: 4.7.2556.0 built by: NET471REL1
CodeBase: file:///C:/WINDOWS/Microsoft.Net/assembly/GAC_MSIL/System/v4.0_4.0.0.0__b77a5c561934e089/System.dll

System.Drawing
Assembly Version: 4.0.0.0
Win32 Version: 4.7.2556.0 built by: NET471REL1
CodeBase: file:///C:/WINDOWS/Microsoft.Net/assembly/GAC_MSIL/System.Drawing/v4.0_4.0.0.0__b03f5f7f11d50a3a/System.Drawing.dll

System.Configuration
Assembly Version: 4.0.0.0
Win32 Version: 4.7.2556.0 built by: NET471REL1
CodeBase: file:///C:/WINDOWS/Microsoft.Net/assembly/GAC_MSIL/System.Configuration/v4.0_4.0.0.0__b03f5f7f11d50a3a/System.Configuration.dll

System.Core
Assembly Version: 4.0.0.0
Win32 Version: 4.7.2633.0 built by: NET471REL1LAST_C
CodeBase: file:///C:/WINDOWS/Microsoft.Net/assembly/GAC_MSIL/System.Core/v4.0_4.0.0.0__b77a5c561934e089/System.Core.dll

System.Xml
Assembly Version: 4.0.0.0
Win32 Version: 4.7.2612.0 built by: NET471REL1LAST_B
CodeBase: file:///C:/WINDOWS/Microsoft.Net/assembly/GAC_MSIL/System.Xml/v4.0_4.0.0.0__b77a5c561934e089/System.Xml.dll

Newtonsoft.Json
Assembly Version: 10.0.0.0
Win32 Version: 1.0.0.0
CodeBase: file:///E:/Gaming/PUBG_Replay_Manager_v1.0.exe

System.Numerics
Assembly Version: 4.0.0.0
Win32 Version: 4.7.2556.0 built by: NET471REL1
CodeBase: file:///C:/WINDOWS/Microsoft.Net/assembly/GAC_MSIL/System.Numerics/v4.0_4.0.0.0__b77a5c561934e089/System.Numerics.dll

************** JIT Debugging **************
To enable just-in-time (JIT) debugging, the .config file for this
application or computer (machine.config) must have the
jitDebugging value set in the system.windows.forms section.
The application must also be compiled with debugging
enabled.

For example:

When JIT debugging is enabled, any unhandled exception
will be sent to the JIT debugger registered on the computer
rather than be handled by this dialog box.

I made a logo for this program. & about license

Well, I'm so new to Github, and I don't know where to post this. so i had to post this in issues tab again.
I made a logo for this program, which helps this program not to look suspicious.
take a look at this.
prmlogo
(original psd and png is in my PC.)
prmforicon
(for program ICON 512x512)
If you like this and want to use this, feel free to reply, then I will bring them to you.

and i finished localizing this program for korean. during the process, I have made a information box and edited Main.cs. I don't know if this is OK. can you help me with this? I will upload the translated version.
PUBG-Replay-Manager-master-KR.zip
1
(image of preview of translated version.)

Crash on start (โ‰ฅ v0.9)

v0.8 works fine (except replays before release of 1.0 of PUBG) but v0.9 and v1.0 crash directly on start.

Win7
Intel i7-4770K
Asus Maximus VII Ranger

Some issues / Some suggestions / about localization(translation)

Hello, I'm very happy that I could find this useful program that contains function I wanted, but I found some issues in your program and I got some suggestions on your program, so I decided to write them here.

  • Issues
  1. Selecting blank in replay list causes error(PUBG.replayinfo for this recording was not found!) and then another error(IndexOutOfRangeException) happens.
  2. Unit of Longest Kill in 'Your Statistics' seems wrong. for example, if the value is 3241.xxx, in game, it is 32m. Distance seems OK. (meter)
  • Suggestions
  1. Saving and Importing multiple replays will be nice, users will have no inconvenience coming from having their replays saved one by one.
  2. If game mod is solo or duo, hiding teammate 3 and 4 will be nice for design.
  3. I think If the number of replays is 20, importing more replays must be disabled, for preventing replays from deleting in game.

ps. About Localization(Translation)
First, I'm living in South Korea, and I have a plan to localize your program and distribute it on website, and I thought i need a permission from you. Your program will be very helpful for pro players, game analyst, streamers, and users, that live in Korea.
So could you allow me to do this? Thank you. ๐Ÿ‘

Choose different replays location

It would be nice to have an option to add a custom replay folder (e.g. where I store my backed-up replays) and be able to view them in the list (and maybe save this search folder for the next sessions).

Also there seems to be an issue with "older" replays (I translated the errors):

************** Exception text **************
System.InvalidCastException: Cannot cast from source type "System.UInt64" to destination type "System.String".
   at PUBG_Replay_Manager.Main.RefreshInfoGroups(ArrayList newInfo)
   at PUBG_Replay_Manager.Main.replayList_SelectedIndexChanged(Object sender, EventArgs e)
   at System.Windows.Forms.ListBox.OnSelectedIndexChanged(EventArgs e)
   at System.Windows.Forms.ListBox.WmReflectCommand(Message& m)
   at System.Windows.Forms.ListBox.WndProc(Message& m)
   at System.Windows.Forms.NativeWindow.Callback(IntPtr hWnd, Int32 msg, IntPtr wparam, IntPtr lparam)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    ๐Ÿ–– Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. ๐Ÿ“Š๐Ÿ“ˆ๐ŸŽ‰

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google โค๏ธ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.