Giter Club home page Giter Club logo

Comments (3)

eliemichel avatar eliemichel commented on August 15, 2024

Maybe the best way to minimize the fix required by breaking changes would be to put all classes in a namespace called BMesh. This way BMesh.Vertex remains valid, using static BMesh can be changed into using BMesh when one uses it.

So feel free to PR such a change, I'll be happy to merge it and have this code be more idiomatic!

from bmeshunity.

MechWarrior99 avatar MechWarrior99 commented on August 15, 2024

Maybe the best way to minimize the fix required by breaking changes would be to put all classes in a namespace called BMesh. This way BMesh.Vertex remains valid, using static BMesh can be changed into using BMesh when one uses it.

So feel free to PR such a change, I'll be happy to merge it and have this code be more idiomatic!

I think a namespace is a good idea, but doing so just moves the breaking change to people that use using static BMesh, naming the namespace BMesh also invalidates any the direct references to the BMesh class such as BMesh mesh = new BMesh(), so perhaps a different namespace name? Or just none at all?

from bmeshunity.

eliemichel avatar eliemichel commented on August 15, 2024

Let's call it BMeshUnity then. And yes we will break things anyways. As a transition measure, we can add a public alias Vertex = BMeshUnity.Vertex in BMeshUnity.BMesh (idk if the keyword using makes it a public alias, otherwise we can define a derived class public class Vertex : public BMeshUnity.BMesh {}.

from bmeshunity.

Related Issues (10)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.