doctorftb / lagbgonreborn Goto Github PK

Why is it not possible to change these messages? I would like to translate them into my own language. Please add the parameters to the config file to change this text.

Lag'B'Gon will be removing items in 1 minute!
Lag'B'Gon has removed 13 items and 173 entities

Hello,

Title says it all. :)
in config (I removed the other items that work fine) :

S:ItemBlackList <
extrautils2:flattransfernode

I am using FTB Sky Adventures pack that has Steve Carts Reborn in it and I added Lag B Gone to the server to control lag.

One of my players complained that Lag B Gone ate his cart, so I crafted a new one for him we put it down I scanned entities for its ID added it to the list and next go around it ate it again. So I held it in my hand added it to entity list it gave a completely different name so I added that name plus the name that the scan entities command gave to the list and it ate it next go around yet again.

Not sure what to put in to make Lag B Gone not eat Steve Carts carts.

Server version 1.12.2
Lag B Gone version: 1.0.0
Steve Carts version: 2.4.24.118

https://pastebin.com/RT5cLGL0

Hello.
I've added LagBGon Reborn 1.0.2 to FTB Revelation 1.12.2 (ver 2.6.0) modpack.
All was good and well, but after a while, about 2 days ago, server started lagging so much that it had to skip ticks.
After some inspection we found out that server was generating EXTREMELY high amount of random chunks (thanks, Dynmap!).
There were no hints in console (even with WorldGeneration-Profiler) on who's fault is it. So I had to disable mods one by one to find the culprit. And, eventually, with disabling, enabling, and disabling again, I've came to conclusion that the issue lies with LagBGon. You can see the map with an example. All the red squared area is world border and pregenerated chunks. Everything outside red square - generated (presumably) by LagBGon.
Can you, please, look into this issue?

Steps to reproduce:

1. Install FTB Revelation 1.12.2 (ver 2.6.0) modpack
2. Install LagBGon Reborn
3. Add Dynmap
4. Run server, wait a while (couple of days maybe)
5. (Not sure) Try to load couple of chunks (fast move through unloaded chunks) for activate LagBGon chunk unloading procedure.
6. Eventually it begins generating chunks randomly... ( this can be tracked by .mca region files on server )

It may not be LagBGon Reborn's fault in the end, but removing it solved the issue, so...

lagbgone is removing item frames
i just placed about 10 of them before it did the clear and they were removed

https://pastebin.com/qMCK2bVS

I run a ATM 3 Remix server and whenever we have your mod installed we get a crash report identical to this fairly frequently. We've disabled the mod for several days at a time and had no similar crashes while it is off. I've checked with the All The Mods discord and a couple other network owners have had the same issue with their servers that also have this mod installed.

I dug into every full log (20+ crashes) related to a crash with the same cause and every crash happens 10 seconds to 180 seconds at max after lagbgon unloads chunks. Was hoping we could get you to look into it. Can provide any further information you need.

On lines https://github.com/DoctorFTB/LagBGonReborn/blob/master/src/main/java/ftblag/lagbgonreborn/LBGCommand.java#L212 and https://github.com/DoctorFTB/LagBGonReborn/blob/master/src/main/java/ftblag/lagbgonreborn/LBGCommand.java#L216 it behaves as expected, but here https://github.com/DoctorFTB/LagBGonReborn/blob/master/src/main/java/ftblag/lagbgonreborn/LBGCommand.java#L222 and here https://github.com/DoctorFTB/LagBGonReborn/blob/master/src/main/java/ftblag/lagbgonreborn/LBGCommand.java#L226 it's completely opposite. This way if blacklist is true, items are being removed, but the entities list turns into a whitelist, thus removing ALL entities EXCEPT blacklisted.

Please make the entities removal behave as intended. Thanks!