dmitric / dlcimagepickercontroller Goto Github PK

how would i be able to modify the current radial blur to make it work like the Instagram tilt shift effect.

1. I would need to use the GPUImageTiltShiftFilter.
2. I would need to change the DLCBlurOverlayView to make the radius into a rotating rectangle.
   any help would be greatly appreciated.

GPUImage has removed blurSize property, so there's several errors in DLCImagePickerController implementation, here's the commit: BradLarson/GPUImage@165aac0#diff-bd0b73323e9d9727c5935e2b36fecf89L25

Video picker not implemented yet.

Hello, in my app I have a place where I choose between the camera and the imagepicker, so I'm hiding the imagepickerbutton in the DLCImagePickerController but there is no easy way to load the view with a UIImage already selected.

After take a photo in landscape, then turn on blur, the blur position is incorrect, especially in the left bottom.

Well, because you guys fix this bug in the master branch, would be nice if we can update the CocoaPod spec to a new version creating a new tag with this thing fixed.

012-08-22 13:41:27.291 DLCImagePickerController[759:907] Application windows are expected to have a root view controller at the end of application launch 2012-08-22 13:41:35.036 DLCImagePickerController[759:907] * Terminating app due to uncaught exception UIViewControllerHierarchyInconsistency', reason: 'A view can only be associated with at most one view controller at a time! View <UIView: 0x1ed53f50; frame = (0 0; 320 480); autoresize = W+H; layer = <CALayer: 0x1ed53f20>> is associated with <UIViewController: 0x1ed53cb0>. Clear this association before associating this view with <DLCImagePickerController: 0x1edcd370>.'

Hi,

Sorry about the bonehead question but what's the recommended way of adding DLCImagePickerController to an existing iOS project?
Thank you kindly!

Would love to see that happening!

Right now we use the filter output, but this could be optimized. I changed to code so that the camera wouldn't be running while capturing and then loading the full resolution image into GPUImagePicture

croppedImage is gone. What's the replacement?

Probably look into GPUImage library to figure this out

Hello,
Thanks for great sample how to use GPUImage. Could you tell me how to speed up BlurOverlayView? I know there is way to make it with UIScrollView. But could you show me how?

Thanks

I’ve recently added DLCImagePickerController to the CocoaPods package manager repo.

CocoaPods is a tool for managing dependencies for OSX and iOS Xcode projects and provides a central repository for iOS/OSX libraries. This makes adding libraries to a project and updating them extremely easy and it will help users to resolve dependencies of the libraries they use.

However, DLCImagePickerController doesn't have any version tags. I’ve added the current HEAD as version 0.0.1, but a version tag will make dependency resolution much easier.

Semantic version tags (instead of plain commit hashes/revisions) allow for resolution of cross-dependencies.

In case you didn’t know this yet; you can tag the current HEAD as, for instance, version 1.0.0, like so:

$ git tag -a 1.0.0 -m "Tag release 1.0.0"
$ git push --tags

Any chance of making this awesome control work with the iPad? Theoretically if we size things using AutoLayout, then we'd get both iPad and iPhone 5 support all in one shot.

HI.

I use DLCImagePickerController take a photo and select blur effect, it is well. then i touch the view and select blur effect position, I see a black round area on my screen:

touch before:
http://img4.picbed.org/uploads/2013/12/IMG_1248.PNG

touch after:
http://img3.tuchuang.org/uploads/2013/12/IMG_1249.PNG

Hey,

Thanks for this code !
I just have an memory issue... when I take a picture with ou without filter and I close the controller, dealloc is called but memory doesn't decrease and still stay at approx 70Mb.

Do you have this pb too ?

Thanks
Ben

I downloaded the sample project and it works fine. However, if I change the Base SDK to 6.1, on only 4 inch(5, 5s, 5c) screen phones (not on simulator), when selecting a photo from the library, it shifts the the image to the left. For example, this is the original image when selecting from Library:

after pressing choose:

Notice how the image is shifted to the left with a black bard on the right. Any ideas/suggestions what could be wrong?

Thanks!

Hey guys,

Running into an issue when trying to present the DLCImagePickerController. Strange thing is that it actually did work once but after that its continually hitting this error.

Im using cocoapods and xcode 4.6 if it helps.

Thanks!

2013-02-26 08:57:11.033 Noisy[4605:907] *** Terminating app due to uncaught exception 'UIViewControllerHierarchyInconsistency', reason: 'A view can only be associated with at most one view controller at a time! View <UIView: 0x20905a70; frame = (0 0; 320 568); autoresize = W+H; layer = <CALayer: 0x20905a40>> is associated with <UIViewController: 0x20905700>. Clear this association before associating this view with <DLCImagePickerController: 0x1f5d0310>.'
*** First throw call stack:
(0x327693e7 0x3a45a963 0x32769307 0x345dcd53 0x345dcc47 0x32fd77d9 0x32fd3543 0x326ef8a5 0x34714e7d 0x347146ff 0x3460d079 0x34597451 0x34623357 0x34664cd9 0x34663fab 0x34785da3 0xe3e13 0xe3cc7 0x346cf9d9 0x34663087 0x3466303b 0x34663015 0x346628cb 0x34662db9 0x3458b5f9 0x345788e1 0x345781ef 0x3628f5f7 0x3628f227 0x3273e3e7 0x3273e38b 0x3273d20f 0x326b023d 0x326b00c9 0x3628e33b 0x345cc2b9 0xd80a1 0xd8028)
libc++abi.dylib: terminate called throwing an exception

Right now when we capture an image from the still camera, we grab the full resolution image and then apply the filters on the full resolution GPUImagePicture afterwards.

We should grab the preview from stillCamera using imageFromCurrentlyProcessedOutput with the cropFilter, apply filters on that, and then only render the full resolution image if the user clicks "Done."

This will speed up the processing on the live image, and will make the app more responsive.

I believe this should be used to do the capture from the front camera as well, and will probably fix issue #1

I've recently added in a radial gradient overlay to show the user where the blur is on the screen.
It's done using CoreGraphics and the code can be seen in the drawRect method of BlurOverlayView.m.

I've noticed it's a bit laggy on iPhone 4 and 4S, so if anyone with some CoreGraphics foo would mind helping out, I'd appreciate it.

Hi,
I want to implement this type of code in my project its seems good..But while building it I'm getting gpuimage.h file not found error. So how can I solve it? Please help me.

Hi,

Those link are out of order from http://www.cocoapods.org/?q=DLCImagePickerController.

Maybe the homepage link need http:// on podspce

In 'DLCImagePickerController.m', the 'viewDidLoad' contains the following deprecated code: self.wantsFullScreenLayout = YES

Can someone make this Work with auto layout so that can work on iPhone 5 and iPhone4?

Hi there. I've been using your code to learn Objective-C and so far so good. Wonderful work. The thing is I'm also using the GPUImage framework and each time I take a picture with the Amatorka filter on live stream I get a white image. The preview is fine, I mean, I take the picture and it shows up great on the App, I click done to save to camera roll and I get a white image. When I pick an image from the camera roll and apply the filter it works great, but not on live stream. All the other filters work great on live stream except the LTU filters (LookupFilter). Did I do something wrong, or is it just not possible to apply LTU filters to live stream. Thanks in advance.

How did you create the ACV files? And what exactly are they?

Edit: I wasn't able to set any labels on this for some reasons. It's more a question than an issue.

Hi,

This library is simply amazing, getting so much power with so little effort is a big gift for other developers hehe

First, is there any wiki page or install/usage instructions? How are we supposed to know what methods to use, etc?

I can't seem to compile anymore as I get lots of "ARC Semantic Issue" errors:

Any idea why I might be getting these? I installed via the podfile.

Thanks!

The blur filter does not follow when you move your finger, just do for taps.
Only follow when not took the picture.

Hi guys!

Did you test it on ios 4.3?

Hello,
I have been using this fantastic library for a little over two month, and by this point I have fully implemented what I will need for my app. However, I was wondering if anyone knew how to add some more customisation to the UIButton's in the Scroll View, so that I can show names of the custom filters, and also how to add a border for the selected filter. I have attempted to do this for a few hours to no avail. Could anyone help with this?

Regards,
Christopher

Awesome work. Would it be possible for you to port this to straight C++ without iOs/xCode dependencies?

Hi there, thanks so much for your hard work! I noticed that pictures taken in portrait mode in DLCImagePickerController are "smaller" than portrait pics taken using the stock iPhone camera..Is this a bug? Do you have plans to make the output of your controller mirror that of the stock camera?

Thanks!

No visible @interface for 'GPUImageOutput' declares the selector 'imageFromCurrentlyProcessedOutputWithOrientation:'

Hi,

I believe there is a difference between the code on Github and the Pods (DLCImagePickerController 0.0.1). When will the pods be updated?

Thank you.

hi, Unfortunately I discovered that the control crashes with ios 7: (

*** Terminating app due to uncaught exception 'NSInternalInconsistencyException', reason: 'Incomplete filter FBO: 36054'

the green indicator stop here:

dispatch_sync(videoProcessingQueue, block);

best regards :)

I was wondering if it is possible to get the lookup filters working properly? They work on their own, but when you add the blur over it the image just goes black. The reason I want to use the lookup filters is that they allow more creative control over the kind of look I'm going for and anytime I made my own ACV filters and replaced yours or simply added them, they didn't work.

Any help would be greatly appreciated, and keep up the good work. I think you've got a great project here and I, as well as I'm sure many other people, am very thankful for everything you're doing.

I just tried your code, it crashes on simulator(Running IOS 5) as well as iPhone 4(Running IOS 6).
Reproducing steps,
Select Photo Picker, select any photo from library, selected 3rd Filter,(First and second are working fine), or any other next filter will crash the app.

Hi,

I'm currently playing with DLCImagePickerController and I have this code done:

/// .h
@interface CameraViewController : UIViewController<DLCImagePickerDelegate>
///

- (void)viewDidLoad
{
    [super viewDidLoad];
    self.imagePicker = [[DLCImagePickerController alloc] init];
    [self presentViewController:self.imagePicker animated:true completion:nil];
}

- (void)imagePickerController:(DLCImagePickerController *)picker didFinishPickingMediaWithInfo:(NSDictionary *)info
{
    [picker dismissViewControllerAnimated:true completion:nil];
    [self doneWithImage:[info objectForKey:@"UIImagePickerControllerOriginalImage"]];
}

- (void)imagePickerControllerDidCancel:(DLCImagePickerController *)picker
{
    NSLog(@"CANCEL");
}

None of the imagePickerController delegates method get called. When I press the X cancel button it does nothing and when I snap a picture and press done the button disables and I can only switch filters and do nothing else.

Is there anything I got wrong in my code? Is there any API docs or usage example for this project or not?

Thanks

Hello,

I am having difficulties to use images within the DLCImagePickerController. For example I am trying to add an image to filtersBackgroundImageView. There is no image showing. Can you please help me? Thanks..

    GPUImageOutput<GPUImageInput> *processUpTo;

    if (hasBlur) {
        processUpTo = blurFilter;
    } else {
        processUpTo = filter;
    }

    [staticPicture processImage];

    UIImage *currentFilteredVideoFrame = [processUpTo imageFromCurrentlyProcessedOutputWithOrientation:staticPictureOriginalOrientation];


    UIImageView *iv = [[UIImageView alloc] initWithFrame:CGRectMake(3, 3, 10, 10)];
    iv.image = [UIImage imageWithData:UIImageJPEGRepresentation(currentFilteredVideoFrame, self.outputJPEGQuality)];
    [self.filtersBackgroundImageView addSubview:iv];


    NSDictionary *info = [[NSDictionary alloc] initWithObjectsAndKeys:
                          UIImageJPEGRepresentation(currentFilteredVideoFrame, self.outputJPEGQuality), @"data", nil];
    [self.delegate imagePickerController:self didFinishPickingMediaWithInfo:info];

Hi,

Is there a way we can adjust the brightness of the captured image using UISlider. Once you move the slider you can preview the brightness that will change. I have tried it using live view only. But i can't figure it out on the captured image. Hope you can help me on this.

Thanks!

Hello, I am on a iPhone 4S, when I take a picture, I see a memory warning and when I try one or two filters my app crashes.
Everything works smoothly with the image picker

Hi @dmitric . I just solved the BlurOverlay lag and real-time application on more complex filters (such as GPUImageFilterGroup). How can I send you the code so you can try it and then implement it? I'm new to Github so I don't know how to make a Pull Request. I searched the documentation but it's not clear to me :-(

Thanks in advance.

Hi,

I installed DLCImagePickerController, follow GPUImage instructions, etc.

It looks like this within my project:

When I select DLCImagePickerController as my target, it builds flawlessly.

I can #import <> the library but as soon as I try to alloc it I get this:

I know it's not a 100% related problem but mostly as project linking issue but I'd really need some help figuring this out. I've spent almost 2 days figuring it out and I'm still scratching my head on it.

If this can be of any help here's more screenshots:
Build Settings
Build Phases

Also any usage example anywhere? I'm sure it's simple enough but it'd be great to know what to look for when testing if the library is working.

Thanks a lot and have a nice day.

I'm getting a error when switching between filters. It's referencing this line of code.

version = CFSwapInt16BigToHost((int)([databuffer bytes]));

Something appears to be wrong with all of the calls to the acv files.

The image got from imagePickerController:didFinishPickingMediaWithInfo: is pixelated which result in a very low quality, and I already set the outputJPEGQuality = 1.0.

The original image is

the result image is

Thanks!!!

Hello!

Just send a tweet asking this question. I'm working in an app that uses the picker to apply some filters to an image. What I want to do is to let the user save the filtered image afterwards. But I don't know how to extract the image from the GL Surface. Is it possible to generate an UIImage from the filtered one?

GPUImagePicture inherits from GPUImageOutput and checking its code:

- (UIImage *)imageFromCurrentlyProcessedOutputWithOrientation:(UIImageOrientation)imageOrientation;
{
    return nil;
}

- (UIImage *)imageByFilteringImage:(UIImage *)imageToFilter;
{
    return nil;
}

- (CGImageRef)newCGImageFromCurrentlyProcessedOutputWithOrientation:(UIImageOrientation)imageOrientation;
{
    return nil;
}

- (CGImageRef)newCGImageByFilteringImage:(UIImage *)imageToFilter;
{
    return nil;
}

It seems that is not possible, with this implementation...

Thanks!

Hi, great job!
But it seems that when you apply blur to a photo, then shoot, the program exits without any trace, even with Xcode.
Sorry about my poor English.

I'm using iOS6 with iPhone 4S

thank you very much about your great work!

Is it possible to show fullscreen photo when I try to capture it? Now preview video is looks cropped. I want to stretch it to screen bounds. Here is screenshot of your example: https://a248.e.akamai.net/camo.github.com/283b7fe6757d1a14f408e95838b5b8b57c0a7f26/687474703a2f2f692e696d6775722e636f6d2f724a78316c2e706e67
I'm talking about this flag photo. I want to remove that tab controls at the bottom and top and make video preview fullscreen. If it's possible, how to do that?

Turn on blur and observe the effect. Then either toggle it on and off, or pan, or pinch. Observe that the blur "intensity" increases every time the event happens when the blur "intensity"/"level" should be constant, equal to the first time the blur is applied.