Kernel: 5.15.0-89-generic
Framework 13 11th Gen (i5-1135G7)

The README and modprobe --show-depends framework_laptop show that this module depends on cros_ec and cros_ec_lpcs, however on my system cros_ec_lpcs is not loaded, and trying to load it with insmod gives an error: cros_ec_lpcs.ko: No such device.

Am i missing the requisite hardware for this module to work? it sorta sounded like all intel FW 13" laptops had the MEC chip mentioned here

Heya! So I am really excited about this work! Just got my 16 and am trying to get this installed. But I am running Universal Blue ( https://ublue.it ) using Blue Build right now ( https://blue-build.org/ ) and I've been banging my head against the wall for a few hours so far attempting to install the module during the image build process and have gotten nowhere. I did open an issue on Ublue's repo because they have a streamlined way to add kmods ( ublue-os/akmods#137 ), but figure I'd attack this problem from multiple angles and ask here as well? During the build process it appears that the current directory for the building of modules doesn't exist? /usr/src/kernels/6.7.6-200.fc39.x86_64 which from where I am sitting, is required by your make script. I'll happily assist in any way I can in this and would happily make a PR back even if its documentation if we can figure it out!

Thanks,
Matt

P.S. If you wanna chat in the Framework discord, I'm Waffleophagus there as well.

LTS versions of many linux distributions seem to mostly still be running kernel versions 5.X. Based on my testing of kernel versions 5.15.0-89, and 5.13.0-40 it seems like there is an issue with building on kernels older than 6.0

The error i got when building on the above kernels (snippet from make output):

framework_laptop.c:252:24: error: initialization of ‘int (*)(struct power_supply *)’ from incompatible pointer type ‘int (*)(struct power_supply *, struct acpi_battery_hook *)’ [-Werror=incompatible-pointer-types]
  252 |         .add_battery = framework_laptop_battery_add,
      |                        ^~~~~~~~~~~~~~~~~~~~~~~~~~~~

Theres a very similar error for framework_laptop_battery_remove as well

after running sudo apt install linux-headers-6.2.0-37-generic, i was able to compile (using make KDIR=/lib/modules/6.2.0-37-generic/build) this module no problem.

Is this an issue that is able to be fixed relatively easily for 5.X kernels more easily than me dealing with trying to distrohop to something that has a 6.x kernel?

As the title says, is it possible (if not done already) to commit this into the upstream Linux kernel?
I don't know the rules for submitting this kind of driver.

Hi,

I was just wondering if there was a plan to expose fan speed potentially in hwmon?

I might have a go implementing it myself next week if it isn't too hard, but I've only ever made small one line changes to older broken kernel modules before, so this might be way out of my skill set.

Edit: It's at least not automatically exposed by ACPI on my AMD Framework, idk about the Intel models.

Thanks,
Steve

System Information

• Bios-version: 03.06
• Bios-release-date: 11/10/2022
• OS: Fedora Linux 39 (Workstation Edition) x86_64
• CPU: 12th Gen Intel i5-1240P (16) @ 4.400GHz
• Kernel: 6.6.7-200.fc39.x86_64
• DE: GNOME 45.2

Issue

• Readme tell us that:

This module requires cros_ec and cros_ec_lpcs to be loaded and functional.

I am facing the issue with Fn key getting stuck, and was advised to disable cros_ec_lpcs as per here.

Question

I wanted to ask if using this kernel module it also fixes the Fn issue? I got to this repository through this link