devj3ns / monopoly-mobile-banking Goto Github PK

Such als total Play time, total games played etc.

Currently, it always shows the minutes, but sometimes it makes more sense to show the seconds or the hours.

30s: 0min --> 30s
30min: 30min --> 30min
90min: 90min --> 1:30h

For example, how often you won a game etc.

Maybe check if the local version is the same as the last GitHub release?!

Or check if everyone in the game is using the same game version?!

via Firebase Hosting

When your name for example is 'Jens' and you got 500.000 $ from 'Evelyn' this is shown in the transaction history item:

'Jens paid you 500.000 $'

But the text should be like this:
'Evelyn paid you 500.000 $'

Instead recommend sign in with Google.

Add change username screen.

When signing in the first time with Google use the display name of the Google Account. If the user wants another name he can change that later.

and show warning when signing out, that you can never sign in again with that account.

Add possibity to connect anonymous account to Google account?

Sometimes multiple transactions take place in a short timeframe. With the current implementation, it can happen that some transactions are 'lost' or overwritten by others because the client manipulates the state of the game instead of the server.

It would be better to store the transactions in a sub collection of the game object in the database. (This would also make it easier to set the timestamp to FieldValue.serverTimeStamp because it is not nested anymore.)
Then a cloud function could detect the creation of new queued transactions and manipulates the player's balance in the game state object accordingly.
When that (the transaction) is done, it can update the status of the transaction and show that in the UI.

Try out some fonts :)

Maybe raleway?

Currently, I use a mix of package:ntp and FieldValue.serverTimestamp(), unfortunately though package:ntp does not support flutter web.

The best way would be to use FieldValue.serverTimestamp(), but that's complicated with the nested players and transaction data. PRs are very welcome!

e. g. when going over the GO field

autofocus is true on the TextFormField.

On android it always works fine, on iOS sometimes but not always (Tested with Chrome, Safari & Brave).

Create a GameResults class which can be stored in a list in the users object in the database.

A GameResults object could store information like:

• game id
• when the game started
• duration of the game
• place of all players

These could be shown on the homepage and be used to calculate statistics like how many games the user played and won in total.

To create these objects we could create a function which converts a Game object into a GameResults object when the game has a winner.

• #44
• #45

The screen could be similar to this one:

e. g. when buying a street

Check if snapshot has pending writes and show a bar that says that the game is not synchronized with the server and therefore you cannot make another transaction.

Use the has pending writes property.

Hi @devj3ns, awesome project ✨ 😍

In the demo I saw that you are using . for the thousands separator, however, that is probably not the correct one for the locale on the device.

The intl package provides ways to do this properly.
See this function for example: https://github.com/simpleclub/math_keyboard/blob/491120508a9b665182dcc7e674323ae26bcc3f2e/math_keyboard/lib/src/widgets/decimal_separator.dart#L12
It uses the intl package to determine the decimal separator and you can use the same method to determine the thousands separator. I think that would be GROUP_SEP (https://pub.dev/documentation/intl/latest/number_symbols/NumberSymbols/GROUP_SEP.html).

However, I think the best way is to use NumberFormat directly instead of doing it manually because that uses the correct number format based on the locale by default.
Maybe you are already doing that, but it seems like it is not properly formatted.

Or, I was tricked by the device locale being de while you are using English strings :D (also possible). In that case, I would force the locale :)

Refactor this code:

https://github.com/devj3ns/monopoly-banking/blob/b4c401bb3c207fb4dda2580d771f738c83b50acf/lib/game/game_screen/view/game_view.dart#L403

• Highlight own transactions
• Make usernames colourful
• Add icon based on the transaction type

The game should be snyced on all players devices. If someone makes transactions without being connected to the server that can make problems.

SignInWithPopup works but SignInWithRedirect not.

Error: [firebase_auth/unknown] An unknown error occurred: TypeError: Cannot read properties of undefined (reading 'isNewUser')

It looks like I have to find an alternative to package:ntp because it does not fully support web.

On iOS, there is no done button on the numeric keyboard, therefore onEditingComplete is never called, which means transactions cannot be done.

Maybe package:keyboard_actions can help?

Before Flutter 2.5.0 it worked.

Public game lobbies don't make sense for this app.

For example, someone might not know that you have to send a player all your money to go bankrupt.
(Should I also add a button to go bankrupt?!)

This was introduced in 4c5eb4b but has to be improved a bit because some colors are badly visible/readable.

e.g. https://monopoly-banking.web.app/game/XXXX (where XXXX is the game ID).

• Don't allow the connection of new players when the game has started.
• Set startingTimestamp on game to the time the game actually started and not the time the game was created.