UISearchController contains some elements which might need to be searched such as:

• searchResultsController (UIViewController)
• searchBar

Possible function definition on a UIViewController extension may be:

func hasGradientLayer(withColors searchColors: [UIColor]) -> Bool

API may look like this:

func findView<T>(ofType searchType: T.Type) -> UIView? where T: UIView

This may exist within:

• navigationItem.titleView
• navigationItem.searchController

Complementary issue to #52 which focuses on finding UISiwtches within a UICollectionView.

The idea is to make it so that when searching for any type of UIKit component, it only can find ones that are visible to the user. If we were to go by apple's definition of if a view can't be touched, that would be isHidden == true or alpha < 0.01.

For example, if I have a label that is currently hidden, findLabel(withExactText:) should no longer be able to find that label.

Handle the scenarios where:

• The selected tab is a view controller
• The selected tab is a navigation controller whose top view controller is the desired view controller

The API might look like: displayedTab(isAKindOf class: AnyClass) -> Bool

Manually specifying a range of a string using magic numbers in the test / builder for attributed strings can both be difficult to understand what it's pointing to and easy to make a mistake when adding/modifying a test.

For those tests where a given sequence of characters exists only one time, might it be better to specify the actual string that you want the attributes to be applied to? I think this might help the tests become a bit more readable.

Here's an example of one test that I've modified to allow this to be done by adding a new method to the builder:

https://github.com/derekleerock/Succinct/blob/b93b9cedbb1139ad8b22feb5453261c3d0fd60a4/SuccinctTests/NSAttributedString/NSAttributedString%2BAttributesSpec.swift#L13

If you think this would be a good improvement, can you make this same update to the remaining tests that could benefit from this? (The last test where you have the same string in there twice probably can't use this approach but I think most of the others can.)

Thanks!

It could be helpful to support regular expressions when searching for text.

For example: findLabel(withExactText: "Issues") returns true if there is a UISegmentedControl with a title of "Issues".

UISegmentedControls should be excluded when searching for UILabel to ensure that searching for UILabels is exclusive to UILabel. If the developer wants to search for a UISegmentedControl, then the developer should call those methods explicitly.

It would be helpful to have some documentation which covers all of the available APIs - however this is a lot of work (and duplication potentially) given the number of functions that are supported / could be supported.

This issue is to research ways in which documentation could potentially be automated to make the process of updating and maintaining the documentation easier.

Are there other solutions that other frameworks make use of? What is the most efficient way to generate this information automatically and minimize the manual nature of preparing / maintaining documentation?

Looks like some of the attributes used throughout these tests are sometimes repeated in different tests. Might be worth looking at extracting these out to the top of the file (or maybe a fixture? not sure if it is worth it though) to help reduce some clutter in the tests?

https://github.com/derekleerock/Succinct/blob/b93b9cedbb1139ad8b22feb5453261c3d0fd60a4/SuccinctTests/NSAttributedString/NSAttributedString%2BAttributesSpec.swift#L11

This was removed in commit 9eeff1f due to assuming that it was no longer needed assuming that tapBarButtonItem(systemItem:) satisfied this need.

tapBarButtonItem(systemItem:) can only be used with system items whereas tapLeftBarButtonItem() can be used with any kind of UIBarButtonItem, therefore tapLeftBarButtonItem() support is still helpful.

This could be accomplished by specifying the coordinates of the annotation that should be selected, for example:

func selectAnnotation(latitude: Double, longitude: Double) { ... }

There's a forced unwrapped optional when looking for the search string in an attributed string:

https://github.com/derekleerock/Succinct/blob/413cda993cbbe6011feec8cdb7a6edf1939a9436/Succinct/NSAttributedString/NSAttributedString%2Battributes.swift#L13

Therefore when a search string that doesn't exist in the attributed string is searched for, the function crashes.

Here's a test that re-creates this issue:

context("when the search string does not exist in the attributed string") {
    it("cannot find the string") {
        let redForegroundColor = [NSAttributedString.Key.foregroundColor : UIColor.red]
        let mutableAttributedString = NSMutableAttributedStringBuilder(withText: "Foreground and Background")
            .withAttributes(
                redForegroundColor,
                range: NSRange(location: 0, length: 10)
            )
            .build()


        let attributedString = mutableAttributedString.copy() as! NSAttributedString
        expect(attributedString.containsExactString("Invalid", withAttributes: redForegroundColor)).to(beTrue())
    }
}

Can you add this test and adjust the code to make it pass? Thanks!

• Ability to search through cell content for UITableViewController objects.

Consider adding support for accessibility identifiers. For example:

• findView(withAccessibilityIdentifier:)
• findButton(withAccessibilityIdentifier:)
• findLabel(withAccessibilityIdentifier:)
• findTextField(withAccessibilityIdentifier:)

Succinct allows you check selected segment title. Is there a way to check unselected ones?

Initially this would apply to:
[ ] has/findLabel
[ ] tapping buttons

etc.

Currently this functionality exists on UIView but should be accessible from UIViewController.

Cocoapods Specs and the Specs Repo: https://guides.cocoapods.org/making/specs-and-specs-repo.html
Podspec Syntax Reference: https://guides.cocoapods.org/syntax/podspec.html

• Create Succinct.podspec locally using $ pod spec create https://github.com/derekleerock/Succinct

• Configure pod and confirm using $ pod spec lint Succinct.podspec --verbose

• Test local podspec with Xcode project pointing to local Succinct with podspec

• Test GitHub podspec with Xcode project pointing to Succinct Git repo

• Submit pod to the trunk using $ pod trunk push Succinct.podspec (Reference) Link: https://cocoapods.org/pods/Succinct

• $ pod trunk register [email protected] 'Name' --description='Computer name/session'

• $ pod trunk push Succinct.podspec --allow-warnings

• Tag latest version of Succinct for a release which resolves the latest Xcode warnings

• Push the new tagged version to Cocoapods

• Update local Cocoapods repository and re-test locally using $ pod repo update

• Update README.md with information on installation and Cocoapods support

Most of Succinct's functionality was built using TDD - however some portions were built using TDD within the context of an actual iOS app implementation. These functions were not test-driven inside the framework, but inside the iOS app.

This milestone is for backfilling tests for these functions to ensure that they continue to work as expected within the context of the framework.

(Tests for some of these may have been added but this is the last list that I had created.)

• UICollectionView+Testing
• UIView+UIView
• UIViewController+UIView
• UIView+UITextField
• UIViewController+UISegmentedControl
• UIView+UISegmentedControl
• UIView+UILabel
• UIView+UIStepper
• UIViewController+UIStepper
• UIViewController+UITextField
• UIView+UIPickerView
• UIView+UIImage
• UIViewController+UIImage
• UIView+UISwitch
• UIViewController+UIPickerView
• UIPickerView+SelectComponent

Looks like every time an attributed string is created using the builder it's converted from a mutable attributed string to an attributed string in each test:

https://github.com/derekleerock/Succinct/blob/b93b9cedbb1139ad8b22feb5453261c3d0fd60a4/SuccinctTests/NSAttributedString/NSAttributedString%2BAttributesSpec.swift#L17

If this is the case, maybe it'd be easier to adjust the builder to just return an attributed string and remove this line from the tests?

For example, with a builder list this:

struct NSAttributedStringBuilder {
    private var attributedString: NSMutableAttributedString

    init(withText text: String) {
        attributedString = NSMutableAttributedString(string: text)
    }

    ...

    func build() -> NSAttributedString {
        return attributedString.copy() as! NSAttributedString
    }
}

The test can be cleaned up like this:

it("can find text with a foregroundColor") {
    let redForegroundColor = [NSAttributedString.Key.foregroundColor : UIColor.red]
    let attributedString = NSMutableAttributedStringBuilder(withText: "Foreground and Background")
        .withAttributes(redForegroundColor, forString: "Foreground")
        .build()


    expect(attributedString.containsExactString("Foreground", withAttributes: redForegroundColor)).to(beTrue())
}

What do you think?

I'm not a huge fan of the force-cast to an NSAttributedString but it doesn't look like there's a nicer way to create attributed strings... =T

In order to help with debugging, if a match is not found, output all label text found so the developer can see if there was a close match but maybe just a type-o or other miss.