Giter Club home page Giter Club logo

Comments (3)

Simon-Laux avatar Simon-Laux commented on June 29, 2024

Yeah would make sense to replace momentjs by luton or dayjs, which use the newer browser apis. This would also make the app slightly smaller.

from deltachat-desktop.

WofWca avatar WofWca commented on June 29, 2024

It's not just about moment though. E.g. here

deltachat-desktop/src/renderer/components/dialogs/ViewGroup.tsx

Lines 239 to 248 in e7fc9e2

? tx(
'n_members',
groupMembers.length.toString(),
groupMembers.length == 1 ? 'one' : 'other'
)
: tx(
'n_recipients',
groupMembers.length.toString(),
groupMembers.length == 1 ? 'one' : 'other'
)}

from deltachat-desktop.

Simon-Laux avatar Simon-Laux commented on June 29, 2024

I think it would be the best to fix this issue by using a newer date library and to make a new issue for the other cases, I don't know a fix for those yet, maybe we need to update our translation function or introduce a new one for counts, or use some translation library instead of our own thing, but let's treat that as a dedicated/seperate issue.

EDIT: ok let's take this as the generic issue and #3866 as the one for the dates

from deltachat-desktop.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.