deltachat / deltachat-desktop Goto Github PK

Version 12.0.1 of standard was just published.

This version is covered by your current version range and after updating it in your project the build failed.

standard is a devDependency of this project. It might not break your production code or affect downstream projects, but probably breaks your build or test tools, which may prevent deploying or publishing.

Your Greenkeeper Bot 🌴

This will create windows builds. Depends upon a windows build script for the deltachat-core and deltachat-node libraries. We should use Appveyor for testing and building the executable.

I keep getting this output where publishing is skipped because release doesn't exist and not created because "publish" is not "always" and build is not on tag tag=v1.0.2 version=1.0.2, which is slightly informative but also confusing, since this was indeed on a tag.

• publishing      publisher=Github (owner: deltachat, project: deltachat-desktop, version: 1.0.2)
  • uploading       file=deltachat-desktop-1.0.2-x86_64.AppImage provider=GitHub
  • skipped publishing file=deltachat-desktop-1.0.2-x86_64.AppImage reason=release doesn't exist and not created because "publish" is not "always" and build is not on tag tag=v1.0.2 version=1.0.2
  • uploading       file=deltachat-desktop_1.0.2_amd64.snap provider=GitHub
  • skipped publishing file=deltachat-desktop_1.0.2_amd64.snap reason=release doesn't exist and not created because "publish" is not "always" and build is not on tag tag=v1.0.2 version=1.0.2
  • skipped publishing file=latest-linux.yml reason=release doesn't exist and not created because "publish" is not "always" and build is not on tag tag=v1.0.2 version=1.0.2

Version 1.2.0 of conversations was just published.

This version is covered by your current version range and after updating it in your project the build failed.

conversations is a direct dependency of this project, and it is very likely causing it to break. If other packages depend on yours, this update is probably also breaking those in turn.

Your Greenkeeper Bot 🌴

It should be easy to filter the chat list when you type in an input box and only display chats in the list that contain those characters

Chat List screen is a preview list of the chats, and Chat View is a view of a single chat. Right now, these are two separate screens. Instead, we could have (like Signal Desktop, or Facebook Messenger) have one screen with the Chat List on the left hand side and the current chat you are viewing in the rest of the window. Example:

Right now builds are about 200mb. We could probably get it below 60mb.

There is a little paperclip icon in the chat window. A user should be able to click that button and a file chooser appears. The user should be able to select multiple files from this picker, and send them.

It's possible to click the login button multiple times and create multiple contexts. If we disable input while the login process in ongoing we can get rid of some issues. Once login succeeds we continue to next screen, if it fails we enable the login button once again, so next login attempt can be started.

Version 1.18.4 of nodemon was just published.

This version is covered by your current version range and after updating it in your project the build failed.

nodemon is a devDependency of this project. It might not break your production code or affect downstream projects, but probably breaks your build or test tools, which may prevent deploying or publishing.

Your Greenkeeper Bot 🌴

unless the user is scrolling up through history..

from @hpk42:

Each DB is tied to exactly one account and vice versa.
dc_context is kind of a synonym for "dc_account".
The way to have multiple accounts is to have multiple DBs.
in the python bindings i happily have 2 active accounts
with their respective smtp/imap threads.

If you have a directory with different DBs and want
to show a selector of the different accounts,
say db1, db2, db3 in a particular application dir,
you can make a for-loop over the dbs, opening each, checking if
is_configured() is true, getting the "addr" config, and closing it.

There is no need to have a db-filename that is derived from "addr".
And this means that in "single account" mode (the one we are aiming to
get working) you can open "db1", start threads and don't ever stop the
threads or close/unref it unless you are really switching accounts.
You can set_config(addr), set_config(mail_pw) and dc_configure()
until success.

Version 0.9.4 of deltachat-node was just published.

This version is covered by your current version range and after updating it in your project the build failed.

deltachat-node is a direct dependency of this project, and it is very likely causing it to break. If other packages depend on yours, this update is probably also breaking those in turn.

Your Greenkeeper Bot 🌴

Hello,
I've installed the last version on Ubuntu 18.04 and found these problems:

1. The .deb file is really big (183MB). Can you try to reduce it?

2. The icon is not shown correctly on GNOME:
   

3. The app correctly chose the system-language (italina) but the app is still in english. Can you please add the translation? In transifex all the strings are translated.

Voice messages should be parsed and an audio preview icon displayed. When the icon is clicked, the voice message should be played.

Note this is different than a file attachment that is of audio form -- these are handled by viewing and downloading file attachment messages.

🚨 You need to enable Continuous Integration on all branches of this repository. 🚨

To enable Greenkeeper, you need to make sure that a commit status is reported on all branches. This is required by Greenkeeper because it uses your CI build statuses to figure out when to notify you about breaking changes.

Since we didn’t receive a CI status on the greenkeeper/initial branch, it’s possible that you don’t have CI set up yet. We recommend using Travis CI, but Greenkeeper will work with every other CI service as well.

If you have already set up a CI for this repository, you might need to check how it’s configured. Make sure it is set to run on all new branches. If you don’t want it to run on absolutely every branch, you can whitelist branches starting with greenkeeper/.

Once you have installed and configured CI on this repository correctly, you’ll need to re-trigger Greenkeeper’s initial pull request. To do this, please delete the greenkeeper/initial branch in this repository, and then remove and re-add this repository to the Greenkeeper App’s white list on Github. You'll find this list on your repo or organization’s settings page, under Installed GitHub Apps.

Just creating an issue here so we can follow up progress. See electron/electron#14247

So, we need node v10.7.0 to support both:

• napi_create_threadsafe_function()
• napi_create_bigint_int64().

We can tweak the c-code to temporarily get rid of napi_create_bigint_int64(), but we need the threads. If we do this we can use v10.6.0.

I checked the electron repo (with help of @mafintosh) and current master is pinning node on v10.2.0 which doesn't help us right now. But in the electron/node fork there's a branch named electron-node-v10.6.0.

cc @Karissa @r10s @Jikstra

If we can check out that branch and build electron ourselves based on that branch we should be good to at least develop, which will buy us some time.

hum, i wonder if we could do a "line-chat" protocol where the core streams events to some file stream and JS reads it, treating each new line as an event. wouldn't this remove the need to do tricky c/js/electron business? you basically say "dc_set_event_stream(FD)" and delta writes out one line per event to that FD. Can electron treat new lines from that FD as events in its eventloop?

and then on "DC_EVENT_HTTP_GET" dcn (the js-deltachat-c layer) writes out to that event stream, and listens to an incoming stream (maybe even polling that).

just throwing it out -- hope it makes some sense. feel free to try shoot it down :)

During the initial login/password screen no feedback is provided if things go wrong. How about at least printing DC_EVENT_ERROR events as they come in?

When clicking a contact from within a chat screen, you should be able to see more details about them, including verification numbers

Currently it can take quite some time to generate keys etc. Using a spinner and providing some feedback text from DC_EVENT_INFO (plus other events?) will let the user know something is going on.

Release notes here https://electronjs.org/blog/electron-3-0

I don't know if we are affected by breaking changes or not.

Hi

Is it possible to use a custom imap server with the desktop likew e can on Android? My server's imap is not imap.myserver.com

thanks

The newest deltachat-node has a different method for initializing the repository, let's use that instead.

Hi

I am trying to install tthis on Debian testing x64

meson.build:12:0: ERROR: Native dependency 'libsasl2' not found

npm WARN [email protected] requires a peer of ajv@^6.0.0 but none is installed. You must install peer dependencies yourself.
npm WARN [email protected] license should be a valid SPDX license expression
npm WARN optional SKIPPING OPTIONAL DEPENDENCY: [email protected] (node_modules/fsevents):
npm WARN notsup SKIPPING OPTIONAL DEPENDENCY: Unsupported platform for [email protected]: wanted {"os":"darwin","arch":"any"} (current: {"os":"linux","arch":"x64"})

npm ERR! code ELIFECYCLE
npm ERR! errno 1
npm ERR! [email protected] install: ./scripts/rebuild-all
npm ERR! Exit status 1
npm ERR!
npm ERR! Failed at the [email protected] install script.
npm ERR! This is probably not a problem with npm. There is likely additional logging output above.

1. create a draft release on github, e.g. v1.0.3
2. bump version in package.json (e.g. from 1.0.2 to 1.0.3)
3. commit and push that (or commit and push several times until release is ready)
4. once done, publish the release on github, which will create the tag

Also see https://www.electron.build/configuration/publish

Maybe no use doing right now, but later on when the ui has settled a bit.

Currently we produce an .AppImage for linux that is over 200Mb large. We should try to figure out if we can reduce this size.

EDIT

• conversations (110Mb) okdistribute/conversations#1
• emoji-panel (32Mb) f5d7ede
• deltachat-node (14Mb) 8418c64

Video messages should be parsed and an preview displayed. When the icon is clicked, the video message should be played.

v1.0.9. after logging, creating chat+contact (where i enter emailadr and name) there is a crash, see screenshot.

When entering your setup message, the interface should automatically create dashes for you, or give you separate boxes for inputting each of the 4-digit codes.

Also, we can display this number more clearly when generating a message.

from @r10s

maybe related: tried out to register delta 1.0.9 on macOS High Sierra 10.13.4 (grabbed my daughter's mac while she's at school :): download and installation works like a charm, up to the setup dialog:

a first click on the "Login" button does nothing, so i wait some ten minutes (might be the key generation took some time :)
a second click on the "Login" button let the login window disappart without any comments.

I was able to reproduce this bug by typing in incorrect credentials, and then logging in again will cause dc_configure to crash because the sqlite database is never closed (i think). Maybe we need to use unref here?

this is not an real issue, but more a reminder about how deltachat-core (and the deltachat-node bindings) should be used to request things.

@ralphtheninja @Karissa feel free to close it :)

stumbling upon the loadChats() in IRC i have noted that this call would be an expensive call as it get the message lists for every chat. while this may be okay in an CLI program, for a desktop app, this may be too slow.

the idea is more to get the list of all chats via dc_get_chatlist() - without any listflags, see below - and to implement a "virtual list" or so (the count of chats is known).

only for the items that are in view (the list may have several hundreds chats), the UI should call dc_chatlist_get_summary() then. this function provides all elements needed for painting the item.

on a click of such an item, the UI should change to the chat view and get all messages from this view via dc_get_chat_msgs(). again, a "virtual list" is created (the count of messages is known) and for each messages that is scrolled into view, dc_get_msg() is called then.

why no listflags? without listflags, dc_get_chatlist() adds the deaddrop and the archive "link" automatically as needed. the UI can just render these items differently then.
although the deaddrop link is currently always the first entry and only present on new messages, there is the rough idea that it can be optionally always present and sorted into the list by date. rendering the deaddrop in the described way would not add extra work in the UI then.

Version 1.1.1 of location-history was just published.

This version is covered by your current version range and after updating it in your project the build failed.

location-history is a direct dependency of this project, and it is very likely causing it to break. If other packages depend on yours, this update is probably also breaking those in turn.

Your Greenkeeper Bot 🌴

When in the chat view for a group, you should be able to click the menu in the upper right and hit 'Edit Group' to go to the Edit Group screen.

To keep it simple, screen could be the same as the one that is shown when the group is created -- createGroup.js. Upon save, the changes in the members and name are then reflected in the group, and the screen returns to the chat window.

My issue is this:

1. electron-builder needs a build folder for build resources, by default it will pick build/ and it will not be included when electron-builder builds the app
2. this is why I changed configuration to set the build folder to src/ https://github.com/deltachat/deltachat-desktop/blob/master/package.json#L88, which fixed the problem in 1. but it's not a good solution because then the icons can't be found

solution 1

1. buble builds to another folder than build/ (and we remove the src/ config) (and index.js needs updating since it currently loads build/main)
2. we put icons etc in build/

solution 2

1. we create a new folder, e.g. resources and change buildResources in configuration to use that
2. put icons etc inside that

I'll play with this a bit. At first glance I think second solution is the best.

Version 1.0.2 of conversations was just published.

This version is covered by your current version range and after updating it in your project the build failed.

conversations is a direct dependency of this project, and it is very likely causing it to break. If other packages depend on yours, this update is probably also breaking those in turn.

Your Greenkeeper Bot 🌴

You should be able to delete a contact from your contact list.

This would be in the 'contact view' screen.

Hello,
I've installed the last Desktop .deb package on Ubuntu 18.04. It starts fine, but when I put username and password DeltaChat crashes immediately. I've started it 4-5 times and always get the following errors.

The terminal returned

(node:6844) Warning: N-API is an experimental feature and could change at any time.
init: 1017.107ms
undefined:0



Error: Failed to open

or

(node:7853) Warning: N-API is an experimental feature and could change at any time.
init: 1022.815ms
Not configured, cannot connect.
Not configured, cannot connect.
Bad or incomplete autoconfig: 0 0:0:0:0 0:0:0:0 0
Bad or incomplete autoconfig: 0 0:0:0:0 0:0:0:0 0
Bad or incomplete autoconfig: 0 0:0:0:0 0:0:0:0 0
undefined:0



Error: Failed to open

then it seemed to work.
I've typed the email and a WRONG PASSWORD and it seemed to login. When I pressed the "Create Chat" button it asked for an account. Then I've tried to press LOG OUT but it didn't work. Now I'm stuck: it's logged in (it's a fake login since the password was wrong) and I can't logout.

Thanks for your help

This should be similar functionality to the android version. Next to the 'create chat' button on the main window, you should have a mini QR code button. This button should open a screen and when a mobile device scans that QR code, they will be entered into the verified group.

This also should create a 'create verified group' button in the 'create chat' view

Once i successfully login, i'd like my deltachat-desktop app to remember my credentials. I am fine with storing the credentials in some default home-dir place.

Once the app has settled a bit we should write something explaining the code structure, which folders contain what etc.

Right now, generating and verifying a setup message is synchronous, which blocks the user interface. Instead, this should be asynchronous -- this might require the deltachat-node library to spawn a thread in C and call a callback once finished, so the UI can render a loading message in the meantime.

• These methods, which are synchronous, should be turned asynchronous: https://github.com/deltachat/deltachat-desktop/blob/master/src/main/deltachat.js#L170-L176
• The frontend calls these functions via the ipc channel here: https://github.com/deltachat/deltachat-desktop/blob/master/src/main/ipc.js#L66-L74

Version 0.9.1 of deltachat-node was just published.

This version is covered by your current version range and after updating it in your project the build failed.

deltachat-node is a direct dependency of this project, and it is very likely causing it to break. If other packages depend on yours, this update is probably also breaking those in turn.

Your Greenkeeper Bot 🌴

Builder should auto upload to github releases on a tag.

https://www.electron.build/file-patterns#default-file-pattern

We will need this to surgically remove unwanted things to improve resulting application size

Version 3.5.0 of @blueprintjs/core was just published.

This version is covered by your current version range and after updating it in your project the build failed.

@blueprintjs/core is a direct dependency of this project, and it is very likely causing it to break. If other packages depend on yours, this update is probably also breaking those in turn.

Your Greenkeeper Bot 🌴