dejal / dejalactivityview Goto Github PK

Hi,

I have a problem with orientation.
I am showing a view controller with horizontal orientation (no rotation is allowed on this view controller).

Here is how I make the horizontal view:

• (BOOL)shouldAutorotateToInterfaceOrientation:(UIInterfaceOrientation)interfaceOrientation {
  return (interfaceOrientation == UIInterfaceOrientationLandscapeRight);
  }

When the view is shown I am loading some list from remote server on the "viewDidLoad" method.
The activity view is shown in vertical orientation for some reason even though the view controller is horizontally oriented.
When I show the view second time (for example when creating a new item on the list), the view is shown properly.

Is it a known issue? Is there a solution?

Thanks,
Guy

Hi David

DejalActivityView is really useful. It looks like we are using a very old version. I.E. pre github. I was going through the code. I wanted to fix a couple of deprecated font related warnings.

seem like you use a style of code I am not familiar with.

prototype with a semi colen
chuck of code?

What does this do?

I noticed around line 300 what looks like a prototype and a chunk of code. I wonder if this dead code? I set a break point. It never seems to execute

- (void)layoutSubviews;
{
    self.frame = [self enclosingFrame];
    

I noticed something similar around line 569. a prototype and chunk of code. I know this chunk executes.

- (void)layoutSubviews;
{
    // If we're animating a transform, don't lay out now, as can't use the frame property when transforming:
    if (!CGAffineTransformIsIdentity(self.borderView.transform))
        return;
    
    self.frame = [self enclosingFrame];
    
    CGSize maxSize = CGSizeMake(260, 400);
    
    // https://stackoverflow.com/questions/19145078/ios-7-sizewithattributes-replacement-for-sizewithfontconstrainedtosize
//    CGSize textSize = [self.activityLabel.text sizeWithFont:
//                       [UIFont boldSystemFontOfSize:[UIFont systemFontSize]]
//                                          constrainedToSize:maxSize
//                                              lineBreakMode:self.activityLabel.lineBreakMode];
    //SCILog(@"deprecated textSiz: h:%f w:%f", textSize.height, textSize.width)
    NSDictionary *attributes = @{NSFontAttributeName: [UIFont boldSystemFontOfSize:[UIFont systemFontSize]]};
    CGRect rect = [self.activityLabel.text boundingRectWithSize:maxSize
                                                        options:NSStringDrawingUsesLineFragmentOrigin
                                                     attributes:attributes
                                                        context:nil];
    CGSize textSize = rect.size;
    //SCILog(@"deprecated textSiz: h:%f w:%f", textSize.height, textSize.width)

kind regards

Andy

I have a view controller that on viewDidLoad calls the following method
[DejalBezelActivityView activityViewForView:self.view withLabel:@"Loading" width:0]

But after a few seconds it removes the activity view automatically without me removing it.

I've got a view controller in my app that calculates some statistics. It does its job in the background, when it recieves certain NSNotifications. When NSNotification is received, it lays DejalBezelActivityView over its view, and when the job is done, dismisses it. So that's how it normally looks like:

I've got another controller (in the same UITabBarController) which can broadcast notifications when user adds an item to the database. The user can do that by filling data in modal view controller, which is basically a simple table view wich text fields.

The problem appears when the user hasn't dismissed the keyboard when filling the information. Modal view controller dismisses, presenting view controller sends NSNotification, and statistics view controller starts to calculate things. This is the moment when DejalBezelActivityView appears on top of unwanted view, although it shouldn't appear at all.

Interesting thing is, if the user dismisses the keyboard first and THEN presses "Save", this will not happen.

Hey,
Great tool :)
I there a best (easiest) way to change the labelText while the activityView is on screen?
Cheers,
Qizib

Because you are using singleton approach there is a problem when you quickly show DejalActivityView one after another (when old one is still animating to remove itself).

You are partially taking care of existing views during init:

if (dejalActivityView) [self removeView];

But the problem is that if there is removal animation still in progress, the completion selector will still be executed.

- (void)removeAnimationDidStop:(NSString *)animationID finished:(NSNumber *)finished context:(void *)context

In that case finished parameter will be @(0) - since animation was cancelled, by removing a view from a superView. Without checking for that value this completion selector removes a new instance of a popup which you wanted to be visible.

You should be checking for the finished parameter value to prevent that.
Alternative will be checking:
if(dejalActivityView == self) in that method

Please add a new tag for the more recent commits past 1.0. The cocoapods spec is currently referencing the 1.0 tag and this version does not include iOS 6 fixes.

Cocoapods can reference the commits directly but the prefered method is access by tag.

Thanks!

I want to add DejalActivityView to the CocoaPods package manager repo.

CocoaPods is a tool for managing dependencies for OSX and iOS Xcode projects and provides a central repository for iOS/OSX libraries. This makes adding libraries to a project and updating them extremely easy and it will help users to resolve dependencies of the libraries they use.

However, DejalActivityView doesn't have any version tags. I will add the current HEAD as version 0.0.1, but a version tag will make dependency resolution much easier.

Semantic version tags (instead of plain commit hashes/revisions) allow for resolution of cross-dependencies.

In case you didn’t know this yet; you can tag the current HEAD as, for instance, version 1.0.0, like so:

$ git tag -a 1.0.0 -m "Tag release 1.0.0"
$ git push --tags

I am presenting the DejalBezelView in a UITableViewController. However, when displaying the Bezel view, it appears behind the table view.

Here is the code that I use to call the DejalBezel view.

[DejalBezelActivityView activityViewForView:self.view withLabel:@"Loading ..."];

See the attached image.

Why not add something like this...

@protocol DejalActivityViewDelegate

• (void) dejalActivityViewDidAnimateOn;
  @optional
• (void) dejalActivityViewDidAnimateOff;
  @EnD

and then give the base class

• (void) setDelegate:(id)d;

so you can optionally use this to capture when the animate on or off finishes.

I have this working and would upload it for you if i knew how to

Is there an easy way to change the font of all DejalActivityViews?

Is it possible to use cusom colors like green or UIColor for the text and indicator loader in DejalBezelActivityView ?

I read on your blog about Wagner Truppel's fork of your original DSActivityView and downloaded a copy because I needed the progress indicator feature. I believe I've identified a bug (not sure if it was introduced in Wagner's fork or if stems from DSActivityView), but can't seem to find an appropriate avenue through which to discuss it.

I think it's fairly obvious that you are only hosting it and not maintaining it, but I thought other folks with the same interest as mine might stumble upon this issue.