is there a chunk of dead code in DejalActivityView.m ? about dejalactivityview HOT 5 CLOSED

The semicolon after the method name makes it easier to copy the line to the header file. The semicolon is optional, and is ignored. It isn’t dead code.

from dejalactivityview.

Hi Dejal

You have two functions with exact same signature. I suspect the compiler / linker only sees one. In my case I know the last one is executed. It is not clear when the first one would be executed.

You might consider implementing using a more modern style based on categories
https://developer.apple.com/library/content/documentation/General/Conceptual/DevPedia-CocoaCore/Category.html

One advantage of this style is the compiler will generated an "error: duplicate declaration of method" error.

//
//  SpotifyAuthController.m
// 

#import "CacheHelper.h"
#import "SCIMediaItem.h"

@interface CacheHelper(Private)
+ (void) copySampleSong:(FileInfoData *)audioFileData 
                FromAppBundleWithDelegate:(NSObject<CacheHelperDelegate> *)delegate 
                withCallbackData:(void *)callbackData ;

- (void) play;

@property (nonatomic, strong) ImportSpotifyCoreAudioController *iscac;

@end


@implementation CacheHelper

@synthesize iscac;

///////////////////////////////////////////////////////////////////////////////
+ (void) copySampleSong:(FileInfoData *)audioFileData 
        FromAppBundleWithDelegate:(NSObject<CacheHelperDelegate> *)delegate 
        withCallbackData:(void *)callbackData {

 ...

}

- (void) play {

  ...

}

@end

from dejalactivityview.

The first is in a local header for private methods. Did you not notice the @interface? This used to be required to be able to call them, though nowadays the compiler can find methods within the same file without it.

from dejalactivityview.

Hi Dejal

I really like your work. You have two functions with the same signature. I is not clear which version will be use when. I am just trying to encourage you to make your code more valuable by making it easier to understand and maintain. You know https://en.wikipedia.org/wiki/Occam%27s_razor. Try and keep things simple whenever possible

Kind Regards

Andy

from dejalactivityview.

@AEDWIP I think you didn't read that file carefully enough. There are multiple classes in the same file, hence the duplicate methods.
I agree, though, that this is bad style and should be split into separate files.

from dejalactivityview.