dbojarski / ng-rxjs-take-until-destroy Goto Github PK

I suggest to create and update changelog after increase version of decorator.
Is very useful when You want update version in project,

I see that your package is published with node_module directory, containing rxjs. I believe that is unnecessary and event redundant. You can declare rxjs as peerDependency because your decorator is dedicated for use in Angular apps, which always have rxjs included. For test purposes you can included rxjs as devDependency and add node_modules to .npmigore do it wilk not be published. Ten you can also ignore package-lock.json

I am using Storybook to document my components.
Storybook creates and destroys components dynamically.
For some reason components with @TakeUntilDestroy decorator throw error "provider.onDestroy()" is not a function. I didn't do deep research on it but it seems that setting target['ngOnDestroy'] = null is causing this problem. I suggest to use empty function there instead of null.