Giter Club home page Giter Club logo

approvals.bash's Issues

Auto-approving

Hi,
Would you be up for adding/supporting a feature of auto-approving new changes?

Imagine a scenario:

  1. You have plenty of tests and you make a change which includes approving many changes
  2. Some changes may even mean that "some approvals (files) should be removed and others created".

Which may mean:

  1. You make your change and would want to just approve all changes.
  2. You might even want to be able to:
    1. rm -rf approvals/
    2. Rerun your approvals.bash tests
    3. Have all changes be auto-approved.

Unbound variable `allow_diff_regex` (when using `set -u`)

Could we change approvals.bash to avoid errors like:
approvals.bash: line 12: allow_diff_regex: unbound variable

For example when sourcing and running the approvals function in a script which has:

set -u
source approvals.bash
approve "ls"

Another way to reproduce:

bash-5.2$ set -u
bash-5.2$ source approvals.bash
bash-5.2$ approve "ls"
bash: allow_diff_regex: unbound variable

Finished with failures
bash-5.2$ echo $?
1

On what set -u does:

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    ๐Ÿ–– Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. ๐Ÿ“Š๐Ÿ“ˆ๐ŸŽ‰

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google โค๏ธ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.