dannyben / approvals.bash Goto Github PK

Hi,
Would you be up for adding/supporting a feature of auto-approving new changes?

Imagine a scenario:

1. You have plenty of tests and you make a change which includes approving many changes
2. Some changes may even mean that "some approvals (files) should be removed and others created".

Which may mean:

1. You make your change and would want to just approve all changes.
2. You might even want to be able to:
   1. rm -rf approvals/
   2. Rerun your approvals.bash tests
   3. Have all changes be auto-approved.

Could we change approvals.bash to avoid errors like:
approvals.bash: line 12: allow_diff_regex: unbound variable

For example when sourcing and running the approvals function in a script which has:

set -u
source approvals.bash
approve "ls"

Another way to reproduce:

bash-5.2$ set -u
bash-5.2$ source approvals.bash
bash-5.2$ approve "ls"
bash: allow_diff_regex: unbound variable

Finished with failures
bash-5.2$ echo $?
1

On what set -u does:

• https://linuxcommand.org/lc3_man_pages/seth.html
• https://pubs.opengroup.org/onlinepubs/9699919799.2018edition/utilities/V3_chap02.html#set