Comments (5)
You may want to use --danger-id
to differentiate them, either way, this isn't really a bug nor feature request - so I'm gonna close it up
from danger-js.
You probably want to use --newComment
to always post a new comment instead of having Danger continually editing the existing message, this IMO is a bit spammy, but it is the only way in which you get the full history
But danger will only delete the comment if it was ran on the CI when the CI run had no issues, so I'm not sure how you would get a situation where a PR after a merge is running danger but that's likely to do with your CI infra
from danger-js.
Thank you, yeah --newComment
is too spammy.
But danger will only delete the comment if it was ran on the CI when the CI run had no issues
We have some checks which will print simple messages and warnings, so which don't mark the PR checks as "failed".
But danger will only delete the comment if it was ran on the CI when the CI run had no issues, so I'm not sure how you would get a situation where a PR after a merge is running danger but that's likely to do with your CI infra
💡 🚀 I think you just answered my question.
On our repo, we have two sets of Dangers checks, one running while the PR is open and changing, and one running after the merge.
The checks running after the merge are probably deleting the previous messages, because the set of checks is different.
I think we need to make sure the entire set of danger checks runs after the merge as well.
If you're curious, via Github Actions, we run Danger on a PR after a merge using the following code:
name: Danger JS after merge
on:
pull_request_target:
types:
- closed
env:
# ......
jobs:
if_merged:
if: github.event.pull_request.merged == true
runs-on: ubuntu-latest
steps:
- # ...... steps for setup
# ....
- name: Danger after merge
run: yarn danger ci --dangerfile "./dangerfile_after_merge.ts"
from danger-js.
My colleague @eppisapiafsl suggested that we could use --newComment
just for the "Danger after merge" run, so we have two sets of comments, and this one runs once anyway.
We will try this.
If it doesn't work, we will run "the entire set of danger checks after the merge as well."
from danger-js.
Makes sense, thank you!
from danger-js.
Related Issues (20)
- [DEPS] Move from @gitbeaker/node to @gitbeaker/rest HOT 3
- [BUG] Danger taking comments as modified files HOT 6
- [BUG] process.env - Cannot read properties of undefined (reading 'env') HOT 1
- [BUG] substr is deprecated HOT 2
- [BUG] [Gitlab] Can't post multiple inline comments HOT 1
- [BUG] Upgrading to danger `11.3.0` causes `tsc` build errors HOT 4
- [BUG] Include dangerfile.ts in the tsconfig makes tsc run out of memory HOT 2
- [BUG][Spec] GitHubReviewers interface is not described
- [BUG] Danger fails to create inline comments on Gitlab
- [BUG] Danger posting separate comment for each warning on GitHub HOT 2
- GHCR publishing is broken HOT 3
- [BUG] GitHubAPIPR unsupported structure HOT 2
- [BUG] `parent_ids` of GitLab MR commits is always an empty array HOT 2
- [BUG] `message` does not attach to a file and line provided, and instead all comments are in the "main comment" section HOT 1
- [Feature Request] Support ignoring whitespace-only changes HOT 3
- [BUG] prettier.resolveConfig fails due to faulty shouldUseGitHubOverride HOT 8
- [BUG] Can you push updated images to dockerhub? HOT 4
- [BUG] Commit status check associated with the wrong commit in CircleCI + GitHub combination HOT 2
- [Config Issue] GitHub Merge Queue - Danger server stuck in "waiting for status be reported" HOT 4
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from danger-js.