Comments (2)
orta
commented on June 2, 2024
2
I'd bake the link into your messages and not use the file + line syntax, I don't think there's an argument for disabling the inline commenting built into the sustem
from danger-js.
fbartho
commented on June 2, 2024
The inline commenting was added later so that might explain why these docs are a bit out-of-date, or at least don't mention that case.
Additionally, if the file/line is not present in a PR, then it will bundle those messages into a table.
Just for my reasoning on why this works this way: For many projects, an inline comment is much more actionable. You can even provide a triple-backtick suggestion and use GitHub's browser interface to commit a change.
Anyhow: I agree with @orta re: resolution of no behavior change!
from danger-js.
Related Issues (20)
- GHCR publishing is broken HOT 3
- [BUG] GitHubAPIPR unsupported structure HOT 2
- [BUG] `parent_ids` of GitLab MR commits is always an empty array HOT 2
- [BUG] `message` does not attach to a file and line provided, and instead all comments are in the "main comment" section HOT 1
- [Feature Request] Support ignoring whitespace-only changes HOT 3
- [BUG] prettier.resolveConfig fails due to faulty shouldUseGitHubOverride HOT 8
- [BUG] Can you push updated images to dockerhub? HOT 4
- [BUG] Commit status check associated with the wrong commit in CircleCI + GitHub combination HOT 2
- [Config Issue] GitHub Merge Queue - Danger server stuck in "waiting for status be reported" HOT 4
- [BUG] danger.gitlab.mr.description can be null
- [BUG] GitHub API request fails for PR with > 300 files change HOT 2
- [BUG] Danger doesn't work with App tokens anymore HOT 22
- [Feature] Provide some messaging if you are not on pull_request for GitHUb Actions CI
- [BUG] Danger succeeds despite receiving a 403 error from GitHub API and having `--failOnErrors` flag set
- API for common ancestor HOT 3
- [BUG] GitHubReview['state'] type does not match current GitHub review states HOT 4
- [BUG] all changes regardless of type are grouped incorrectly into `modified_files` in `danger.git` HOT 1
- [BUG] Error: ReferenceError: fetch is not defined HOT 13
- [images/4-results.png[](url)](url) HOT 1
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from danger-js.