Giter Club home page Giter Club logo

Comments (1)

fbartho avatar fbartho commented on June 8, 2024

As I understand there is a connected issue for Github. Is it possible to adopt the same fix for Gitlab or is it completely different?

I would certainly examine the linked PR to see if it teaches you anything, but I wouldn’t expect it to necessarily be exactly related. The fundamentals of cross-provider DangerJS behavior has been pretty stable for a long time. GitLab is a relatively newer provider so I’d expect the issue to be in one of these places:

I think more likely, the problem is a misunderstanding about GitLab’s automatic behaviors, for example maybe GitLab has only one “slot” for a line-level comment, which means the last one always wins. In that case, you might be able to preprocess all the line-level comments, and merge all the ones that target the same/file-line into a single comment. (I even believe this is doable in user-space)

from danger-js.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.