d00med / scifi_nodes Goto Github PK

The current wiring rules for the digicode are very not apparent without trial and error. They should be the same as the basic mesecon button instead of only 1m below next to the digicode (x=-1, y=-1, z=0 and x=1, y=-1, z=0 when facing North), which requires exposed mesecons bending up to mid-air.

@D00Med can you do me a favor and transfer the repository-permissions to my new account thanks 👍

2020-08-04 22:02:27: WARNING[Main]: Node scifi_nodes:white2 has a palette, but not a suitable paramtype2. WARNING[Main]: Node scifi_nodes:white has a palette, but not a suitable paramtype2. WARNING[Main]: Node scifi_nodes:whiteoct has a palette, but not a suitable paramtype2. WARNING[Main]: Node scifi_nodes:whitetile has a palette, but not a suitable paramtype2.

but still older 9ad9ba3 25.06.2020
if fixed, I will just update then

Looking in the textures directory, it looks like this mod has loads of cool stuff! You should definitely show this off with more screenshot - both on the ContentDB listing and here in the README.

For example, ceiling light can't be placed horizontally along X axis, same with wall light and Z axis. Since these light nodes have an asymmetric shape, it would be nice if they could be rotated in all directions. Perhaps this problem applies to some other nodes as well.

Ability to have password protected sci-fi doors. Door only opens with a keypad. Making it work with the palm scanner as well would be nice as a two factor authentication.

Makes it possible to use the mod with other games too (mtg is going to be put in maintenance mode: minetest/minetest_game#2710)

Todo:

• Only register recipes if default is available (alternative recipes would be a next step)
• Internalize default.gui* references in chest.lua
• Internalize default.node_sound_*_defaults()
• Check for default.MAX_LIGHT

It looks like this, but only from one side:

I don't see where the item meta field is ever set:

on_destruct() seems pointless.

Did I overlook something?

itemframes and pedestals set that value [homedecor_modpack/itemframes] but sci_fi stands do not.
Also itemframes and pedestals protect their items while sci_fi counterparts give free gifts, behaviour which I like.

This item is missing a recipe and it is widely used across your mod.
Thanks for considering adding a recipe :)

Two sounds are under the bad/non-free CC BY-NC 3.0 licence:

• scifi_nodes_door_mechanic.ogg primeval_polypod https://freesound.org/people/primeval_polypod/sounds/156507/
• scifi_nodes_digicode.ogg https://freesound.org/people/Robinhood76/sounds/94933/

Please replace those sounds with libre ones OR we somehow convince the authors to grant us a free content license like CC BY or CC BY-SA.

The latter sound, actually, is so trivial that I think it can be recreated easily. This is just telephone digit dial sounds for 01592, I bet it can be recreated in Audacity.

WARNING[Main]: Not registering alias, item with same name is already defined: scifi_nodes:panel_white_bottom -> scifi_nodes:panel_white WARNING[Main]: Not registering alias, item with same name is already defined: scifi_nodes:micro_white_bottom -> scifi_nodes:micro_white

is this necessary, or depending on maybe not all used parts to be sure ?
Otherwise I might it comment out at me ... server start get so long ... data

In singleplayer, when leaving the game and then starting again, the item holder loses the held item.

issue: the error messages for the teleporter(found in nodeboxes.lua) such as minetest.chat_send_all("There can only be two teleportation pads at a time!") and minetest.chat_send_all("Teleporter error!") which when they have errors, and someone not understand what tries multiple times, spams up the chat. could these perhaps be changed to use minetest.chat_send_player() instead?

For some reason, most nodes that are clearly made out of metal make glass sounds, for foostep and breaking. Breaking even makes a "glass shatter" sound.

Can this please be fixed and a metal sound be used for the metal nodes instead? Thanks.

this warnings are displayed in chat when using this mod with other games besides default, guessing this is probably from the alien grass

currently the teleporters work, but leave room to be desired. Perhaps a optional dependency for the travenet(https://github.com/Sokomine/travelnet) mod could be added so that they could be compatible.

opening this issue to continue the discussion from PR #40
"@D00Med what were your plans with the teleporter pads? The limtiation of 2 pads makes sense for singleplayer worlds, what about multiplayer?"

scifi_nodes:glass_pane and scifi_nodes:windowpanel share the same recipe. I believe the author overlooked this because scifi_nodes:glass_pane is automatically generated from the template.

In octagon_panes.lua: recipe_ingredient evaluates to scifi_nodes:glass:

local function register(basename, description, texture)
=>  local nodename_single = "scifi_nodes:" .. basename .. "_pane"
    local nodename_double = "scifi_nodes:" .. basename .. "_pane_double"
    local nodename_offset = "scifi_nodes:" .. basename .. "_pane_offset"
=>  local recipe_ingredient = "scifi_nodes:" .. basename

    ...

    -- register recipes

    minetest.register_craft({
      output = nodename_single .. " 16",
      recipe = {
=>      {recipe_ingredient}
      },
    })

  ...
end

...
=> register("glass", "Dark Glass pane", "scifi_nodes_glass.png")

At the same time in crafts.lua:

-- https://forum.minetest.net/viewtopic.php?f=10&t=13125&p=261481#p261481
minetest.register_craft({
    output = 'scifi_nodes:windowpanel 4',
    recipe = {
=>      {"scifi_nodes:glass","",""}
    }
})

Sounds, possibly some of the digging properties etc.

From pandorabox-io/in-game#229

The README claims the sound license for some sounds to be actually worse (CC BY-NC 3.0) than it actually is:

• Actually CC BY 3.0: scifi_nodes_door_normal.ogg tlwmdbt https://freesound.org/people/tlwmdbt/sounds/165862/
• Actually CC BY 3.0: scifi_nodes_switch.ogg http://soundbible.com/1950-Button-Push.html
• Actually CC BY 3.0: scifi_nodes_palm_scanner.ogg https://freesound.org/people/THE_bizniss/sounds/39313/
• Actually CC0 1.0: https://freesound.org/people/TheBuilder15/sounds/415762/
• Actually CC BY 3.0: scifi_nodes_access_refused https://freesound.org/people/RICHERlandTV/sounds/216090/

Please fix this. This project should not need to be less libre than neccessary. :-)

Sadly, the CC BY-NC 3.0 license is correct for these 2 sounds:

• scifi_nodes_door_mechanic.ogg primeval_polypod https://freesound.org/people/primeval_polypod/sounds/156507/
• scifi_nodes_digicode.ogg https://freesound.org/people/Robinhood76/sounds/94933/

latest scifi_nodes master as of now

2021-08-28 14:02:34: ACTION[Main]: Server: Shutting down
2021-08-28 14:02:35: ERROR[Main]: ModError: Failed to load and run script from /opt/minetest/bin/../mods/scifi_nodes/init.lua:
2021-08-28 14:02:35: ERROR[Main]: /opt/minetest/bin/../mods/scifi_nodes/nodes.lua:650: attempt to index global 'unifieddyes' (a nil value)
2021-08-28 14:02:35: ERROR[Main]: stack traceback:
2021-08-28 14:02:35: ERROR[Main]: /opt/minetest/bin/../mods/scifi_nodes/nodes.lua:650: in main chunk
2021-08-28 14:02:35: ERROR[Main]: [C]: in function 'dofile'
2021-08-28 14:02:35: ERROR[Main]: /opt/minetest/bin/../mods/scifi_nodes/init.lua:24: in main chunk

minetest-dev master as of a few days ago
minetest_game latest master as of now