Artifacting seems to not be resolvable by tweaking depth and normal bias. Am I missing something or is this not implemented?

Thanks

Hey I'm getting these two errors:
Shader error in 'Shader Graphs/ShadowReceiver': Couldn't open include file 'Packages/com.cyanilux.shadergraph-customlighting/CustomLighting.hlsl'. at line 210
Shader error in 'Shader Graphs/ShadowReceiver': Couldn't open include file 'Packages/com.cyanilux.shadergraph-customlighting/CustomLighting.hlsl'. at line 877

Any ideas?

I'm using Unity 2022.3.13f1, URP 14,
I don't know what's up but shadow atten is just white...

Hi,

I get this error on shader compilation when using a 2020 LTS with custom lighting.

It looks like a relevant fix for this was made on the URP repo. It consists of :
https://github.com/Unity-Technologies/Graphics/pull/3551/files
where the fix was to add a check for defined(VARYINGS_NEED_SHADOW_COORD) in Varyings.hlsl:

#if defined(VARYINGS_NEED_SHADOW_COORD) && defined(REQUIRES_VERTEX_SHADOW_COORD_INTERPOLATOR)

However, the URP version used on 2020 LTS still uses the old test:

#if defined(REQUIRES_VERTEX_SHADOW_COORD_INTERPOLATOR)

so it requires a different workaround.

This repo has a test starting on line 38:

#ifndef SHADERGRAPH_PREVIEW
	#if VERSION_GREATER_EQUAL(9, 0)
		#include "Packages/com.unity.render-pipelines.universal/Editor/ShaderGraph/Includes/ShaderPass.hlsl"
		#if (SHADERPASS != SHADERPASS_FORWARD)
			#undef REQUIRES_VERTEX_SHADOW_COORD_INTERPOLATOR
		#endif
	#else
		#ifndef SHADERPASS_FORWARD
			#undef REQUIRES_VERTEX_SHADOW_COORD_INTERPOLATOR
		#endif
	#endif
#endif

which undefines the statement so that Varyings.hlsl does not try to reference shadowCoord.

In my case, this still resulted in errors in the console. The reason was because the custom lighting nodes (and related includes) were only included on shadergraph paths that calculated color. The shadowcaster pass does not calculate color, so it doesn't make the custom lighting include, does not make the undef and so still throws the errors. The fix for me was to wire a custom function to the alpha node so that it makes the include and then also correctly undefs the shadowcaster pass.

(Issue can be closed, I hope the info is useful to others)

Thank you for you work, it has helped me a lot exploring new ideas and learn about shaders without having to mess much with shader code!

There is a way to set every shader to vertex lit, but I wanted to make only some of them using this technique to have better performance, is there a way to make a vertex lit shader using your resources?

Reporting a bug/missing feature:

When using Subtractive lighting https://drive.google.com/uc?id=1r5fO4GJOwFskzgW2L4UOHaXcUEYRrB36, the toon shader from this Github doesn't receive the Subtractive shadow as demonstrated here https://drive.google.com/uc?id=1EWzjEFLrqJQTN0HGQgcFCnqUr0LwEI4A

My project uses Subtractive lighting so would be great if this feature could be supported!

In a clean unity 2021.3.9f (LTS) install using URP 12.1.7, additional lights seem to be broken when setting the build target to Android.
Here's a screen shot with Windows as build target:

And here's the exact same scene, just with android as build target:

Details:

• Using the Toon material included in the package.
• No settings were changed to the default 3D (URP) template
• Render pipeline set to the URP "HighFidelity" preset (has 8 per pixel lights set for additional light and most settings maxed out)

Thanks for your work - just thought I would report it for anyone battling with this problem. I don't know if this may be related to the light indexing problem described here: https://forum.unity.com/threads/additional-lighting-issue-when-switch-to-android-platform.1191736/
With a unity case (though it is marked as fixed): https://issuetracker.unity3d.com/issues/mobile-urp-all-lights-are-emitting-light-from-one-light-spot-when-the-platform-is-set-to-android-or-ios

Update: The problem doesn't seem to be in the light indexing, but rather in calculating the ToonAttenuation. Tried applying a standard lighting model for the additional lights, which worked as expected.

Hey

I have found a weird problem with the spotlights. They seem to ignore distance in some instances the light shines through objects. Im using Unity 2021.3 LTS

The shadows work perfectly in a lit or unlit graph, or when using the subgraph in a fullscreen shader. However, if i make my own custom function that includes CustomLighting.hlsl in a fullscreen shader, MainLightShadows_float outputs 1 for everything, like there are no shadows.

Edit: After looking at other issues, I'm fairly certain this has to do with the boolean and enum keywords, namely _SHADOWS_SOFT and _MAIN_LIGHT

the teal is the original shader, the red my implementation (to rule out issues with the project of scene).
I implemented my toon shader, added the ramp and specular wihtout any issues but the shadow map and baked/subtractive GI dont seem effective : I have reproduced the shadergraph in a very similar subgraph below, am I missing something?

In the past these shaders worked well in all Unity versions. Right now 2022.3.15LTS breaks the shadow receiving shader.
It only happens with 3 or 4 cascades, so it probably is a keyword issue. It also happens with 2 cascades when conservative enclosing sphere is enabled

Soft shadows now also have enums for the quality tiers

Hi!

First off, thank you so much for this example repo! I've spent way too long searching for a way to make unlit shadows work and only finding outdated posts.

One thing I had to do to make your repo work, was adding one line to CustomLighting.hlsl to fix an error that said that VERSION_GREATER_EQUAL does not exist. The line in question is:

#include "Packages/com.unity.render-pipelines.core/ShaderLibrary/Version.hlsl"

I'm on my MacBook Pro (Big Sur 11.5, Metal) on URP version 11.0.0. Not sure if this is necessary only for Mac or only for newer versions of URP though.

Cheers!

Super awesome shader.

I have played around with different custom lighting models for URP for a while. I'm having trouble getting something that bake the light correctly and supports light probes.

I have tried using your toon shader example for baking, but it bakes the standard lighting model. Is it on purpose?

Baked

Realtime

I'm using 2021.3.10f1

i want to adjust the shadows from both mainlight and additional light.

In Unlit Graph:

In Subgraph Connected to Unlit Graph


(ignore the parameters, they are not attached to anything)

What's going on here?

Is there something to configure befor use?
I imported it form asset store and all the examples were pink. Then i imported it from git with the same result.
Is there something to setup befor i can use this shader?
Is there a manual?

I pulled this repository into a fresh unity 2020.21f1 project and found that the realtime additional light shadows are not working for the example toon shader with spotlights. I tried the same for 2021.1.0b3 with spotlights and pointlights.
furthermore I tried:

• enabling the keyword via script as outlined in your article
• setting the boolean in the graph to true
• checked if shadows are enabled in the RP asset

I am not sure what I am missing at this point, but please let me know if I overlooked or misunderstood anything

Really cool package, I can't thank you enough for this ! I was wondering and fiddling with it and is there a way to actually remove the "self-shadowing" from the MainLightShadows. I've been trying for a good while now to get access to the unity shadow texture and the fact is while I'm compositing my lighting I've got issue that comes from trying to remove the ugly self shadowing that I'm getting with the node. It might not be possible maybe the actual shadow looks like this, but since I'm compositing my own self shadowing with the inverse DOT it kinda conflict with it. The projected shadow are so smooth and nice compared to what the self shadows are. :/ I'm a noob at HLSL could've probably figured it out in shaderlab, but now I'm a bit lost. Thanks in advance for your time!

Adding support for forward+ would be awesome. It flickers now if forward+ is activated. Also would be neat if the point/spot lights listened to the ramp texture instead of creating bands.

Hello! This repo has been an invaluable resource for setting up custom lighting in URP. Thank you so much for putting this together!

I was wondering if you had any thoughts/leads on how I might extend it to work with deferred rendering now that URP supports it? I was picking through the URP code and the mechanics of reading/writing the GBuffer seem doable, but complicated. Have you looked at it at all, or have any idea where one might get started?