Giter Club home page Giter Club logo

accsettings's People

Contributors

crazyboyfeng avatar

Stargazers

 avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar

Watchers

 avatar  avatar  avatar  avatar  avatar

accsettings's Issues

Please give feature of setting schedule

There is an app named AccA: https://github.com/MatteCarra/AccA

This AccA app has a feature of setting schedule. Though I find this app buggy, I think this scheduler option might be helpful for many of the users of ACC Settings. Because in the daytime usually we need faster charging and at night we need charging as slow as possible to keep the phone plugged overnight.

Your app is awesome already. Please take my suggestion under your consideration.

Issues about some configuration

I am documenting this for now and then take time to see how acca handles it, or if it has been discussed in any previous issues. If not, submit it for discussion.

  • cooldown_custom file string input or options? options from where?
  • apply_on_boot and apply_on_plug string input or options? options from where?
  • reset_batt_stats_on_pause and reset_batt_stats_on_unplug what settings do they affect?

  • max_temp_pause necessary?
    As I understand it, when max_temp is set, acc will loop to detect if it is higher than that value and then pause charging. Then setting the duration of loops seems to be meaningless.
  • max_charging_current and max_charging_voltage file string input or options? options from where?
    The documentation says that the file is automatically selected, so for now we can ignore the file.
  • lang is meaningless for front-end.

Future request, Please add an in-app updater

Dear dev,

I really appreciate all the work you put into ACCSettings. But as a user of your app I must say that I didn't know I was outdated until I checked GitHub. I think I will not be alone with this lack of knowledge about the updates of your app.

So please, would you add an in-app updater (with notification support that informs user of an update) for your app? It would allow users to use outdated versions much less often :)

In appreciation for your work,
Sir Henry

Future state of the app

What is the current status of this app? Is the development stopped? It hasn't received any update for a long time.

Compatibility problem of `libsu` with `Coroutines`

This will block:

runBlocking{
    withContext(Dispatcher.Default){
        val job = com.topjohnwu.superuser.Shell.sh("echo test")
        val result = job.exec()
        val output = result.out
        println(output)
    }
}

All Dispacther except Unconfined have the same effect.

The reason seems to be that shell job created in sub-threads (coroutines) are not available.
At the moment I'm not sure if this is a bug or if I'm using it in the wrong way. I'll take the time to look into this later. It has taken me too long.

The current solution is simple: first call the shell once in the main thread before the coroutines to generate the cached shell:

runBlocking{
    Shell.sh().exec()//Or before runBlocking
    withContext(Dispatcher.Default){
        println(Shell.sh("echo test").exec().out)
    }
}

occasional display issue for Voltage and Power

idk if this is from acc or accSettings, but once or twice per minute these show these values with the wrong order of magnitude

vlc_seVQcNGdYb

(btw love the app, much better than going into the terminal)

Light theme

It seems to me that, currently, this APP only has dark theme. This is inconvenient when the device is running under light theme. This is probably the case for E-Ink devices.

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    ๐Ÿ–– Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. ๐Ÿ“Š๐Ÿ“ˆ๐ŸŽ‰

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google โค๏ธ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.