compnerd / cassowary Goto Github PK

It would be beneficial to add documentation for the interfaces to enable easier usage of the library. The eventual goal would be to provide proper generated documentation via DocC.

Hi there! My colleagues and I are porting Cassowary to another language and your implementation has served as a great reference. We noticed that in your implementation a condition for determining if an added constraint is unsatisfiable differs from the original C++. I just wanted to raise it to your attention in case it needs to be flipped.

Solver.swift: https://github.com/compnerd/cassowary/blob/master/Sources/Cassowary/Solver.swift#L424-L426

if row.constant ~= 0.0 {
  throw UnsatisfiableConstraint(constraint)
}
subject = tag.marker

solverimpl.h: https://github.com/nucleic/kiwi/blob/master/kiwi/solverimpl.h#L106-L107

if( !nearZero( rowptr->constant() ) )
  throw UnsatisfiableConstraint( constraint );
else
  subject = tag.marker;