Giter Club home page Giter Club logo

Comments (5)

nh2 avatar nh2 commented on July 30, 2024

We should also discuss whether durability should be the default in writeFileBinary and writeFileUtf8.

My personal take right now is safe defaults are better, even if they are much slower due to the fsyncs and moves.

And ideally the docs should point out things like "if you do not need durability, use this other function which is much faster".

Also relevant for atomic moves (and performance) is whether the source and target are on the safe file system (overwise the rename() is not atomic at all).

from rio.

snoyberg avatar snoyberg commented on July 30, 2024

The atomic move issue is probably the biggest question mark about this for me. AFAICT, the only way to reliably implement this is to create a temporary file in the same directory as the target file and then move it. However, in the case of program crashes/SIGKILLs/etc, there's a possibility that the file could be left behind, meaning that this change doesn't just trade performance for durability, but also introduces slight externally-visible semantic changes.

from rio.

nh2 avatar nh2 commented on July 30, 2024

I found another very useful thread that discusses these issues, and particular wheter fsync() after rename() is necessary (the answer there is yes):

from rio.

lehins avatar lehins commented on July 30, 2024

Just stumbled on this ticket. It seems like it can be closed, no?

from rio.

snoyberg avatar snoyberg commented on July 30, 2024

I think so

from rio.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.