Giter Club home page Giter Club logo

Comments (3)

kindaro avatar kindaro commented on September 6, 2024

Of course, I can copy some code from RIO.Prelude.Simple and have this:

runApp ∷ RIO App α → IO α
runApp action = do
  verbose <- isJust <$> lookupEnv "RIO_VERBOSE"
  lo <- logOptionsHandle stderr verbose
  withLogFunc lo $ \lf -> do
    simpleApp <- mkSimpleApp lf Nothing
    temporaryDirectory ← getTempDir
    runRIO App {..} action

But what is the point of depending on a library if I still have to borrow code from it? Also, it is very technical and I do not really want to trust myself with this sort of things.

from rio.

snoyberg avatar snoyberg commented on September 6, 2024

This bit of code looks incorrect to me:

runApp  RIO App α  IO α
runApp action = do
  simpleApp  runSimpleApp ask
  temporaryDirectory  getTempDir
  runRIO App {..} action

Instead of using runSimpleApp and then allowing the result of ask to escape, something like the following would be preferable:

runApp  RIO App α  IO α
runApp action = runSimpleApp $ do
  simpleApp  ask
  temporaryDirectory  getTempDir
  runRIO App {..} action

For the rest of the code: to be honest, I'm not that comfortable with all of the language extensions employed to make that work, so it's possible something is slipping past me.

from rio.

kindaro avatar kindaro commented on September 6, 2024

This works, thanks!

from rio.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.