Giter Club home page Giter Club logo

Comments (7)

snoyberg avatar snoyberg commented on September 6, 2024

What happens if you give it an absolute path in the first place?

from rio.

k-bx avatar k-bx commented on September 6, 2024

@snoyberg all right, I've created a minimal self-containing repo. I also confirm that the code works on macOS, but not Ubuntu 20.04, and suspect it might work fine on Ubuntu 18.04, which might be somewhat alarming https://github.com/k-bx/rio-process-symlink-issue

The README captures the build and run instructions

from rio.

snoyberg avatar snoyberg commented on September 6, 2024

Does this reproduce with the process package?

from rio.

k-bx avatar k-bx commented on September 6, 2024

Yes, I rewrote it using the UnliftIO.Process and it works now

from rio.

snoyberg avatar snoyberg commented on September 6, 2024

I'm quite confused about the claim that this works on macOS and Ubuntu 18.04 but not Ubuntu 20.04. I think I know what the problem is: usage of canonicalizePath instead of makeAbsolute in findExecutable. However, that functions behaves identically on macOS and Ubuntu 18.04: resolving symbolic links.

The repro you've provided isn't really minimal, since it depends on assumptions of virtualenv working identically across all OSes and versions. I'm fairly certain that's the problem here. My recommendation: can you try replacing canonicalizePath with makeAbsolute in the codebase and see if that solves the problem you're seeing?

from rio.

snoyberg avatar snoyberg commented on September 6, 2024

I don't see a downside to the change, so I've opened #218.

from rio.

k-bx avatar k-bx commented on September 6, 2024

@snoyberg yes, tested with the patched rio, it works now. Thank you!

from rio.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.