According to http://www.industrialrelations.nsw.gov.au/oirwww/NSW_public_holidays/NSW_Public_Holidays.page (which is already in your code comments), there is no public holiday on 31st December for AU/NSW, yet the code has got it specified. Why is this so?

Also, npm test doesn't pass when I tried running it (even without modifications), I get lots of errors, mostly off by half an hour, so I wasn't confident enough to submit a pull request.

I'm using Arch Linux with the latest tzdata-2016j installed, if that indicates anything...

have a 'distribution' json directory of holiday dates,
i.e. json only, no code
e.g, so i can just pick up /dates/GB/England-Wales.json or /dates/GB/GB.json from the CDN or npm ....
=> its programming language independent
=> its very small (most people will just need 1 or 2 small files with a handful of dates (their country and possibly, region)
=> have 2 option, an, 'array of dates => name' file, and an 'object of names => date' file, so people can choose what they need.

FYI day names have shifted on the demo site? For example, 2019 holidays for Australia list Good Friday, 19th April on Thursday.

Hi,
If it is possible, I request that Indonesia and Malaysia be added.
Thank you!

Hi again,

I wanted to run something by you to see what you thought or if you have a better solution.

In my use case, I need to be able to automatically apply holiday surcharges to appointments that fall on a holiday. Each business has a list of observed holidays, so when a customer schedules an appointment, I first need to check to see if the business observes the holiday and if they do, then check to ensure the date of the appointment falls on the holiday. For the first part, I'm currently matching a list of holiday names to what's output by the getHolidays(year) function of your library. This works great, but I'd prefer to match on some unique identifier rather than a language-dependent name.

Would you be open to adding unique identifiers for holidays that would be the same regardless of language? Do you have a better solution that I may be missing?

Thanks!

Hi there,

sorry im new bee.
Whats the best way to install under Symfony? Just put the folder in my assets or is there a better way?

THX
Mike

Disclaimer: this is not an issue but a request for comment. However, a Github issue seems like the closest thing to an RFC.

I am wondering if it makes sense to remove data/holidays.json from version control and move the YAML to JSON process into the build process? Specifically, it would mean moving node scripts/holidays2json.js into the scripts/build step of package.json. This way, the full holidays.json would be packaged with the node module. It would also line up a bit more closely when customizing which countries exist in holidays.json.

I would also like this from a development standpoint. In the past, I have had merge conflicts with holidays.json which were more of an annoyance as I was able to regenerate the file on my branch.

What do you think?

there is a typo in index.html file

on line 36 includes javascript file "index.js" when in fact it's "test.js"

current
<script src="index.js" type="text/javascript"></script>

should be
<script src="test.js" type="text/javascript"></script>

Hello,

I tried to use one of the readme example but I got an error

date-holidays installed : 1.4.0
chrome : 74.0.3729.169

My code ( in a react component):
var hd = new Holidays( 'FR' );

// working
console.log( hd.getHolidays() );

// Uncaught TypeError: Cannot read property 'fn' of undefined
hd.isHoliday( new Date( '2016-02-09 00:00:00 GMT+0000' ) )

Did I forget . to init something ?

This is a TODO. I have used the Python yamllint command for this in the past. There is also a Node tool but I have no experience with it.

Hi there! I am the maker of https://github.com/kodie/moment-holiday and I'm considering switching my holiday source to your package here. Unfortunately, this package is missing one feature that I need, to be able to search for holidays using keywords.

I could implement this in my package and have something like keywords.json in it, but I think it would be better for everyone if the keywords were contained in the same package as the data source.

So my suggestion is to implement a holiday function for searching for holidays using keywords.

For example:

var hd = new Holidays('US')
hd.holiday('Memorial Day')

This would involve adding the keywords and keywords_n to the holidays.yaml structure.

Both of these keys would accept an array of strings and/or regex strings. keywords would be used as expected and keywords_n would be for values that shouldn't apply to that holiday. For example, the holiday Christmas Day would have ['christ', 'x-?mas'] in it's keywords and ['eve'] in it's keywords_n.

I would be more than happy to work on this and submit a pull request.

For holidays in Australia, instantiating holidays using an object doesn't work.

For example the following fails, creating an instance with an empty {} instead of a set of holidays

const holidays = new Holidays({country: 'AU', state: 'NSW'});

Whereas this creates holidays as expected

const holidays = new Holidays('AU', 'NSW');

So with the .getHolidays(), how would I be able to specify multiple years e.g. the next 5 years including the current one?

const Holiday = require('./lib/index')
const public = new Holiday('DE', 'mv')
  .getHolidays(2017)
  .filter(h => h.type == 'public')
  .filter(h => h.date.match(/2017-10-31/));
console.log(public)

produces following output:

[ { date: '2017-10-31 00:00:00',
    start: Tue Oct 31 2017 00:00:00 GMT+0100 (CET),
    end: Wed Nov 01 2017 00:00:00 GMT+0100 (CET),
    name: 'Reformationstag',
    type: 'public' },
  { date: '2017-10-31 00:00:00',
    start: Tue Oct 31 2017 00:00:00 GMT+0100 (CET),
    end: Wed Nov 01 2017 00:00:00 GMT+0100 (CET),
    name: 'Reformationstag',
    type: 'public' } ]

I guess it has something to do with it being celebrated as the country-wide holiday in 2017 only

It is Scottland in the GB.yaml file.
The correct spelling is Scotland.

When using create-react-app there is problem with minifying.
./node_modules/date-holidays-parser/src/CalEvent.js:3

Please read more here: http://bit.ly/2tRViJ9

Ps. we can't edit webpack config file in create-react-app environment.

Hi,

there is no state 'Berlin' in the country 'DE'. In fact Berlin is a state of it's own and has different holidays than Brandenburg.

Hi

Really great plugin. Though one day is missing from the list when I pull danish holidays.
It's 24th of dec. Christmas Eve in Denmark, it's a public holiday as well.

When attempting to create a custom build using the example

"scripts": {
  "build": "holidays2json --pick US,CA,MX --min"
},

I got the following

npm run build
Error: got #ifndef expected #elif, #else, #endif
    at Parser._isCmd (/Users/xxx/node_modules/prepin/lib/parser.js:55:13)
    at /Users/xxx/node_modules/prepin/lib/parser.js:43:17
    at Array.map (<anonymous>)
    at Parser.parse (/Users/xxx/node_modules/prepin/lib/parser.js:34:29)
    at /Users/xxx/node_modules/prepin/lib/index.js:20:27
    at <anonymous>
    at process._tickCallback (internal/process/next_tick.js:189:7)

Using

$ npm -v
6.4.1
$ node -v
v8.12.0

Is it compatible with Node.js?

The project I'm working on uses date-holidays and it just started throwing the following error, looks to be associated with caldate's recent changes.

any ideas?

Hello,

date-holidays installed : 1.4.0
chrome : 74.0.3729.169
Opera : 60.0.3255.170

When I try to use "isHoliday", Igot this error :

This is what I got for "b":

Am I doing something wrong ?

Add new holiday for DE-TH International Children's Day / Weltkindertag on 09-20
source https://www.thueringer-landtag.de/service/presse/pressemitteilungen/weltkindertag-am-20-september-wird-gesetzlicher-feiertag/

Currently, the May Bank holiday on this module is incorrect. It states that the May bank holiday is on the 4th of May, but it's on the 8th (https://www.gov.uk/bank-holidays). This would normally be correct but it's VE day. Could you fix this?

Hi,
First of all, thank you for this module! When I try to use it with create-react-app, an errror occurs during the npm run build command. It says:

Failed to minify the code from this file: 

 	./node_modules/date-holidays-parser/src/CalEvent.js:3 

Any help?

Thank you!

The following problem is not fixed in #12. Do you think it is fix worthy?

Only DE-BB observes easter and easter 49 as public holidays. (source, easter sunday and pentecoste sunday are not marked bold)

The 1st of November is the 'All Hallows' (Allerheiligen) holiday. For Berlin - Germany this is no holiday.
The library also detects the 2nd of November as the same holiday.

Typescript definition: Holidays.isHoliday(date: Date): Holidays.Holiday
In reality it should be either Holidays.isHoliday(date: Date): Holidays.Holiday | boolean or Holidays.isHoliday(date: Date): Holidays.Holiday | false

We request that Hanukkah be added, if that is possible, given that the dates change each year. Thank you!

According to wikipedia it depends largely on state:
https://en.wikipedia.org/wiki/Washington%27s_Birthday

https://github.com/commenthol/date-holidays/blob/master/data/names.yaml#L264

Thanks for setting up this project!
I'd like to use it but I only need the holidays of a certain set of countries.
The current https://github.com/commenthol/date-holidays/blob/master/data/holidays.json contains all countries/regions and translations.
Since I am aiming to keep my app bundle size at a small size I wonder if we could organize the data json differently?

While I could implement a pre-build step and remove all the countries not needed I think other users might also gain something if the data could be included more fine grained.

Kanton Uri, Kanton Appenzell A. Rh. and Kanton Appenzell I. Rh. require a new rule that holiday 12-26 (Stefanstag) is a holiday only if not falling on a Monday or Friday.

This is not fixed in #12:

Technically every sunday is a holiday in DE-HE.

Public holidays are the sundays and [...]
Source: http://www.datumsrechner.de/gesetze/Hessen.pdf

I do not know how you want to handle this.

According to https://www.gov.uk/bank-holidays#northern-ireland, the Summer bank holiday is observed in Northern Ireland. However, when I scope to GB and the NIR (Norther Ireland) region, that holiday does not appear:

const Holidays = require('date-holidays')
const gb_nir = new Holidays('GB', 'NIR')
gb_nir.getHolidays(2018).filter((h) => h.name == 'Summer bank holiday') // returns [] but should return the Summer bank holiday.

Note that it does work correctly for England:

const gb_eng = new Holidays('GB', 'ENG')
gb_eng.getHolidays(2018).filter((h) => h.name == 'Summer bank holiday')

/* return value:
[ { date: '2018-08-27 00:00:00',
    start: 2018-08-26T23:00:00.000Z,
    end: 2018-08-27T23:00:00.000Z,
    name: 'Summer bank holiday',
    type: 'public' } ]
*/

I'm using date-holidays in my angular project. Everything works fine but my unit tests all fail after importing it. It looks like date-holidays won't compile with commonjs module:

Uncaught TypeError: date_holidays_1.default is not a constructor

Here is my tsconig.spec

{
  "extends": "../tsconfig.json",
  "compilerOptions": {
    "outDir": "../out-tsc/spec",
    "baseUrl": "./",
    "module": "commonjs",  <-- changing so something like "es2015" works fine (but breaks other things not related to date-holdays. I need to keep it as commonjs)
    "types": [
      "jasmine",
      "node"
    ]
  },
  "files": [
    "test.ts",
    "polyfills.ts"
  ],
  "include": [
    "**/*.spec.ts",
    "**/*.d.ts"
  ]
}

Based on the API documentation, I was expecting to be able to pass an array of holiday types to Holidays.init and have it return only holidays of those types. For example:

const Holidays = require('date-holidays');
const us_all = new Holidays('us');
new Set(us_all.getHolidays(2018).map(h => h.type))
// returns Set { 'public', 'observance', 'optional' } as expected

# filtering by a single type works as expected:
const us_optional = new Holidays('us', {types: ['optional']})
new Set(us_optional.getHolidays(2018).map(h => h.type))
// returns Set { 'optional' }

# But filtering by multiple types returns nothing:
const us_optional_public = new Holidays('us', {types: ['optional', 'public']})
new Set(us_optional_public.getHolidays(2018).map(h => h.type))
// returns Set {} but I am expecting Set{'optional', 'public'}

Note that I am running this on Node 10 which has support for the new Set type. I am also running this against master as of 4768392 .

I am not sure if this is a documentation bug but it would be nice to be able to filter by multiple types.

On node 10.15.x and 8.x note is missing for some years for US Veterans Day

     "name": "Veterans Day",
     "type": "public",
+    "note": "Federal Government offices are closed",

On [email protected] all notes a present.
Not sure if there is a problem with the parser or with node?

Affected fixtures:

US-AK-2016.json
US-AK-2017.json
US-AK-2018.json
US-AK-2019.json
US-AK-2020.json
US-AL-2016.json
US-AL-2017.json
US-AL-2018.json
US-AL-2019.json
US-AL-2020.json
US-CA-2015.json
US-CA-2016.json
US-CA-2020.json
US-CA-LA-2015.json
US-CA-LA-2016.json
US-CA-LA-2017.json
US-CA-LA-2018.json
US-CA-LA-2019.json
US-CA-LA-2020.json
US-CT-2015.json
US-CT-2016.json
US-DC-2015.json
US-DC-2017.json
US-DC-2018.json
US-DC-2019.json
US-DC-2020.json
US-DE-2015.json
US-DE-2016.json
US-DE-2018.json
US-DE-2020.json
US-FL-2015.json
US-FL-2019.json
US-FL-2020.json
US-GA-2016.json
US-GA-2017.json
US-GA-2018.json
US-GA-2019.json
US-GA-2020.json
US-HI-2015.json
US-HI-2016.json
US-HI-2017.json
US-HI-2018.json
US-HI-2019.json
US-HI-2020.json
US-IA-2016.json
US-IL-2015.json
US-IL-2016.json
US-IL-2017.json
US-IL-2018.json
US-IL-2019.json
US-IL-2020.json
US-IN-2015.json
US-IN-2016.json
US-IN-2017.json
US-IN-2018.json
US-IN-2019.json
US-IN-2020.json
US-KY-2017.json
US-KY-2018.json
US-KY-2019.json
US-KY-2020.json
US-LA-2016.json
US-LA-2017.json
US-LA-2019.json
US-LA-NO-2015.json
US-LA-NO-2018.json
US-LA-NO-2019.json
US-MA-2015.json
US-MA-2016.json
US-MA-2017.json
US-MA-2020.json
US-ME-2015.json
US-ME-2017.json
US-ME-2018.json
US-ME-2019.json
US-ME-2020.json
US-MO-2016.json
US-MO-2017.json
US-MO-2018.json
US-MO-2019.json
US-MO-2020.json
US-MS-2015.json
US-MT-2016.json
US-MT-2017.json
US-MT-2020.json
US-NC-2017.json
US-NC-2018.json
US-NC-2019.json
US-NC-2020.json
US-NE-2015.json
US-NH-2016.json
US-NH-2020.json
US-NJ-2015.json
US-NJ-2016.json
US-NJ-2017.json
US-NJ-2018.json
US-NJ-2019.json
US-NJ-2020.json
US-NV-2016.json
US-NV-2017.json
US-NV-2018.json
US-NV-2020.json
US-NY-2015.json
US-NY-2016.json
US-NY-2017.json
US-NY-2018.json
US-NY-2019.json
US-NY-2020.json
US-SC-2016.json
US-TN-2017.json
US-TN-2018.json
US-TN-2019.json
US-TN-2020.json
US-TX-2015.json
US-TX-2016.json
US-TX-2018.json
US-TX-2019.json
US-WI-2015.json
US-WI-2016.json
US-WI-2017.json
US-WI-2018.json
US-WI-2019.json
US-WI-2020.json
US-WV-2015.json
US-WV-2016.json
US-WV-2017.json
US-WV-2018.json
US-WV-2019.json
US-WV-2020.json

Hello, is it possible to get the Holidays without providing a year, just the data from the holidays.json?

Hey! So I'm a little confused on how to get isHoliday() working correctly.

I know that it respects timezones but I'm still having troubles getting it to return the correct days.

Here is the code I have:

var Holidays = require('date-holidays')
var hd = new Holidays('US')
console.log(hd.isHoliday(new Date('2018-01-02 00:00:00 GMT+0000')))

// { date: '2018-01-01 00:00:00',
//   start: 2018-01-01T05:00:00.000Z,
//   end: 2018-01-02T05:00:00.000Z,
//   name: 'New Year\'s Day',
//   type: 'public' }

And as you can see it returns New Year's Day for January 2nd, however, New Year's Day is actually on January 1st, therefore it should return false.

I'm pretty sure this has something to do with timezones but is there anyway I can get holidays to only return on the actual day that they are on?

I would like a support for the public holidays of the State of Israel (as IL: 'ישראל').
The list: https://www.timeanddate.com/holidays/israel/

If you don't have enough time, I can open a PR.

What are your thoughts about falling back to the Calendarific Holidays API for missing countries?

Hi, I'm from the Quebec state of Canada and I do know the "Boxing Day" (December 26th) and Remembrance Day (November 11) ARENT official holidays (as stated in by my state http://www4.gouv.qc.ca/fr/Portail/citoyens/programme-service/Pages/Info.aspx?sqctype=sujet&sqcid=329 - thought December 25th is usually paid by the employer).
There is no trace of a possible weird exception for the Quebec state. (Though I did only a quick search)

When looking for the Canada holidays I found a couple of links, even on the Canada tax web portal I found 2 pages (https://www.tpsgc-pwgsc.gc.ca/remuneration-compensation/services-paye-pay-services/paye-centre-pay/feries-holidays-eng.html and https://www.canada.ca/en/revenue-agency/services/tax/public-holidays.html), listing the Boxing Day as well as the Remembrance Day, as Canada holidays. One of these page refers to what looks like a law page.
So I'm confused even as a Canadian...

Google embedded result tools also match my state website. (Warning: On April we have a substitution day)

I do believe they could be for employees working for the Canada government and aren't public holidays.

I don't quite want to change my country file yet since I don't know per-state. If some github users from Canada could post here their holidays for their state it would be great!

Browser example is published on https://commenthol.github.io/date-holidays/

Hi there, first, thanks for a great library!

We recently ran into an issue with the range for New Year's Eve showing up properly. Here's the code I'm running:

    // create a new instance of holidays for the business' country
    const holidays = new Holidays(country) // US for this example

    // set timezone for the holidays
    holidays.setTimezone(timezone) // America/Denver for this example

    // get all of the holidays for the current year
    const countryHolidays = holidays.getHolidays('2018')

When I log countryHolidays, I see the following for New Year's Eve:

{ date: '2018-12-31 18:00:00',
  start: 2019-01-01T01:00:00.000Z,
  end: 2019-01-01T07:00:00.000Z,
  name: 'New Year\'s Eve',
  type: 'observance' }

I'd expect start to be 2018-12-31T07:00:00.000Z.

Thoughts? Thanks in advance for your help!

Hi,
when I try to use the version 1.2.8 via typescript I am getting the following error:

> node js/index.js

/Users/asoysal/work/date-holidays-test/js/index.js:4
const h = new date_holidays_1.default();
          ^

TypeError: date_holidays_1.default is not a constructor

TS File, which I've based it on the test file in typescript folder:

import Holidays from "date-holidays"

const h = new Holidays()

generated js looks like this:

"use strict";
Object.defineProperty(exports, "__esModule", { value: true });
var date_holidays_1 = require("date-holidays");
var h = new date_holidays_1.default();

I need to add "The day after Independence day" for one state. I think I see in the YAML where I would do it (I think). But the format looks a tad tricky to me, Independence day looks like:

07-04 and if sunday then next monday if saturday then previous friday:
        substitute: true
        _name: Independence Day

I'm guessing it would be the same except 07-05 ?

What I don't understand is how I can add that without essentially hacking the existing YAML file?

Hi,

I'm at loss, how would one get this script to work in a regular browser?
Do I really need node to get this script going or can I use it at the frontend as well?
It's suggested it is possible but how?

Aren't there some ready to grab script files I can inlcude on my page, include some locales and work with it?

Hey everyone, as in moment-holidays (https://github.com/kodie/moment-holiday#isholiday), is it possible to provide a custom holidays-array (or something equal) for check the input-Date.
My use case is to "validate" dates provided by client, so its not always matching with the official dates (sometimes they're open, even if there are holidays)
Or do you have another idea to realize this?

Thanks! Dominik

Would the author consider putting this library on a CDN like cloudflare or https://cdnjs.com so that we can use sites like Codepen to prototype. Thanks in advance.

I am getting the following error when in Internet Explorer 11.

Error date-holidays-parser/src/CalEvent in ? - Expected identifier

This is for the following line.

const {isDate} = require('./internal/utils')

My guess is it is interpreting the destructuring assignment as an object. My project is based off of react-boilerplate and is using babel-polyfill instead or core-js, not sure if that is the cause. Any ideas what could be causing this?