TypeError when using with the provided Typescript Typings about date-holidays HOT 6 CLOSED

Hi, I personally don't use typescript in my projects so I can't help with this. Sorry...
@johnolos could you please help here?

from date-holidays.

I'll take a look once I got time. Just saw this now.

For the record, we use this in our code-base and it's working just fine. What TypeScript version are you using?

Our tsconfig.json

{
  "compilerOptions": {
    "baseUrl": ".",
    "outDir": "build/dist",
    "module": "esnext",
    "target": "es5",
    "lib": ["es2017", "dom"],
    "sourceMap": true,
    "allowJs": true,
    "jsx": "react",
    "moduleResolution": "node",
    "rootDir": "src",
    "forceConsistentCasingInFileNames": true,
    "noImplicitReturns": true,
    "noImplicitThis": true,
    "noImplicitAny": true,
    "strictNullChecks": false,
    "suppressImplicitAnyIndexErrors": true,
    "noUnusedLocals": true,
    "allowSyntheticDefaultImports": true
  },
  "exclude": [
    "node_modules",
    "build",
    "scripts",
    "acceptance-tests",
    "webpack",
    "jest",
    "src/setupTests.ts"
  ]
}

from date-holidays.

@tonakai Any news on this issue from your side?

from date-holidays.

hi,
sorry i must have missed the emails,
similar to #45 my tsconfig contains, "module": "commonjs", changing it to esnext causes bunch of errors on other imports, looks like a similar issue however this is a node project instead of angular

from date-holidays.

@tonakai this problem seams to be unrelated to this project. Could you please confirm by closing this issue?

from date-holidays.

I'm having the same issue, the problem is that the module is exported as module.exports = Holiday, and typings for those kinds of exports should look like export = Holiday, export default Holidays could be used if the module was exported something like module.exports = { ...Holiday, default: Holiday } (the default property needs to have a value if you want to use a default import).

Note that when you do change the typings to export = ... you might encounter this issue and you have to import it as import * as Holidays from 'date-holidays'.
Because of the linked issue, you'll probably need to somehow exclude the entire typings file and write your own.

The way I resolved this issue was to fall back to date-holidays: 1.2.7 (the last version without typings) and wrote my own version of the typings.
There is probably a better way to do this, but going back to an old version wasn't really an issue for my project so it was the easiest for me.

In case someone asks, my tsconfing.json has module: "commonjs" and I'm using Typescript version 3.3.3333

from date-holidays.