comicrelief / campaign Goto Github PK

View Code? Open in Web Editor NEW

22.0 18.0 10.0 80.98 MB

Comic Relief Campaign Distribution in Drupal 8

Home Page: https://master-tx3mbsqmxtu74.eu.platform.sh/fundraise

License: GNU General Public License v2.0

PHP 19.79% JavaScript 26.30% CSS 7.59% HTML 35.49% Shell 0.13% Gherkin 10.70%

drupal cms fundraising distributed-systems drupal8 distribution behat

campaign's People

Contributors

Stargazers

Watchers

Forkers

wimleers flocondetoile ipublicis christopher-hopper bimsonz adamclark-dev biletnam cmario03 comicreliefinc

campaign's Issues

Block reference link class

Link class is not showing in the markup of the block reference link.

ds-reset--node-content-wall.html.twig

Ideally it should be in the template not in the database.

Update drupal-composer vendors

Since we start to use this project they update their vendors or replace them with others, we should follow their suggestions otherwise we may have to deal with issues that they no longer maintain.

Review profile config management from Thunder v2

See https://github.com/BurdaMagazinOrg/thunder-distribution/blob/develop/docs/development.md#updating-thunder

Thunder v2 provides some really nice documentation related to their dealing with config. Don’t think we need to adopt it as-is, but it might be useful to have a deeper look into it.

For example:

They log every config change with a custom logger (useful for debugging)
They import new config using Drupal\config_update\ConfigReverter::import()
They use Drupal\thunder_updater\Updater::updateConfig() to update config, and they check beforehand whether that config was overwritten or not. Since we’ll initially be managing few sites (not 100s like thunder), this feels like overkill especially since we don’t want to deal with overwritten config, but worth knowing a way to do so

Promo header inline image styles refactoring

We need to make one field (ie desk_img) to output different responsive images depending on what layout you choose (big header or smaller head).

Remove inline responsive image styles and create a function to display the two options.

Big header: Small header:

And use something like: field_landing_image.big_header and field_landing_image.small_header

Update to editorial functions: colours and inline links

Currently the colours added to content is not displayed in the WYSIWYG view - this means editors must publish content before really seeing what it looks like.

The colours drop down currently doesn't include yellow - can we make rules that all colours in the pattern lab are automatically in the CMS editorial tools?

Inline links are also manually added in the HTML rather than as an editor tool.

Add more badges

We want to add more badges, we have the following list to check the source of the badges.

http://shields.io (Example https://github.com/Sylius/Sylius )
http://poser.pugx.org (Example https://github.com/slimphp/Slim )

Badges that probably we want:

Latest release
License
Downloads (total? montly?)

Remove meta icons block being displayed on every page

The following is appearing on every admin page at the top.

This is meta icons block, Use block--cr-meta-icons.html.twig in your theme templates folder to override it
Breadcrumb

Method for single message colours to be overridden by child theme

Modify the cr_single_msg module to allow the colour options to be overridden easily by a child theme.

Install Roave Security advisories

Roave security advisories is a composer tool that blocks composer packages from being installed that have know security advisories. It is run against composer update or composer require and prevents packages with known issues from being installed.

https://github.com/Roave/SecurityAdvisories

@Saphyel @pvhee What do you think?

CR logo overlapping CMS menu

CR logo overlapping cms edit menu,
Behat test not able click edit. Test failing.

Remove Travis keys for legacy Pantheon deployment

We've previously added encrypted Travis keys to the repo (as part of #71).

Remove keys from repo
Clean out history using BFG

Single message FE bug

The single message update to enable text to go extend below the line of the image has broken the single message when text is less than the image height. The expected behaviour would be that the bottom of the single message would be in line with the bottom of the image unless the text is bigger than the image.

Image #4 x 3

Image 16 x 9

Update composer.lock

Regenerating composer.lock using composer update nothing, then validating it using composer validate

News filters dropdowns editable by content editors

Currently the news component auto-generates a news category for every category added by the content team and puts the category into the drop down filter:

The categories currently are used a bit like tags so that the 'related news' is relevant to the article - for example 'Women and Girls' is a grants initiative we support and we would want those articles to link to each other. We do not want the 'Women and Girls' category to be displayed as a front end filter to the end user.

The category should still exist in the background to link relevant articles to each other - the content team just need to be able to choose if they are displayed as final front end filters to the end users.

Upgrade Drupal version to 8.2.8

The Drupal version is currently set to 8.2.7, it needs to be upgraded to 8.2.8 to implement the latest security release.

Fix develop

We have a Test broken because the date format.
A possible way to fix this:
c4bbe14#diff-a27cab3af67f912d403d2d66ee78e582R76

Use docker-compose to run Travis build

Currently, we manage our stack (PHP, MySQL, etc) manually on Travis, but it would be easier to reuse our Docker setup, so we can debug Travis runs locally.

Make article category field optional

Editors often don't have a category to add to an article, so we should consider making this field optional instead of required. We should review how the article overview page will then show the article, would all articles without a category be shown via "None" dropdown option?

Improve install doc

campaign/docs/install.md the order should be 1st bundle install and then npm install also for Ubuntu users we should add: sudo ln -s /usr/bin/nodejs /usr/bin/node

Sorry for comment this here :)

Migrate all colour arrays to config management module

All of the custom modules have colour configuration duplicated across them and are not easy to override in child themes

Behat - fix landing page test to run lcoal

Button 'Add existing Partner' not found

Failed scenario
Drupal\DrupalExtension\Context\MinkContext::pressButton()
And I press the "Add existing Partner" button # Drupal\DrupalExtension\Context\MinkContext::pressButton()
Button with id|name|title|alt|value "Add existing Partner" not found. (Behat\Mink\Exception\ElementNotFoundException)

modules for default nav and optional feature nav

https://comicrelief.atlassian.net/browse/CR-5
The current navigation module that's enabled by default is the feature navigation (3 items featured plus the hamburger menu). This should be changed to a default navigation that shows all the menu items inline and only has the hamburger menu on small and medium screen sizes. The feature navigation should be an optional module that can be enabled to replace the default navigation.

Styling and javascript of the new default navigation is done in the pattern-lab:
comicrelief/pattern-lab#43
Specific styling for comicrelief.com:
comicrelief/pattern-lab#71

The javascript for the feature navigation still lives in the navigation module, so this needs to be moved to the pattern-lab too and the feature navigation needs to be either renamed or moved to a new feature nav module.

We need to find a way to override the default navigation when the feature navigation module is enabled.

Edit:

Some RND specific changes:
https://github.com/comicrelief/rnd17/issues/298
Disable cr_navigation module in comicrelief theme:
https://github.com/comicrelief/comicrelief/issues/75
Styling for the feature nav needs to be checked:
comicrelief/pattern-lab#120

Fix search block and results

Open and close search block not working. Search results have no layout.

Behat - fix media feature test to run local

Change media file path in media feature test.

Failed scenarios
Then I should see "File nose (administration) has been created." # Drupal\DrupalExtension\Context\MinkContext::assertPageContainsText()
The text "File nose (administration) has been created." was not found anywhere in the text of the current page. (Behat\Mink\Exception\ResponseTextException)

Then I should see "File pdf (administration) has been created." # Drupal\DrupalExtension\Context\MinkContext::assertPageContainsText()
The text "File pdf (administration) has been created." was not found anywhere in the text of the current page. (Behat\Mink\Exception\ResponseTextException)

And I enter "Here goes the video caption" for "Video caption" # Drupal\DrupalExtension\Context\MinkContext::assertEnterField()
Element is not currently visible and so may not be interacted with
Build info: version: '2.53.1', revision: 'a36b8b1', time: '2016-06-30 17:37:03'
System info: host: 'bf1d7a1502a8', ip: '172.19.0.4', os.name: 'Linux', os.arch: 'amd64', os.version: '4.8.0-52-generic', java.version: '1.8.0_91'
Driver info: driver.version: unknown (WebDriver\Exception\ElementNotVisible)

Then I should see "File video file has been created." # Drupal\DrupalExtension\Context\MinkContext::assertPageContainsText()
The text "File video file has been created." was not found anywhere in the text of the current page. (Behat\Mink\Exception\ResponseTextException)

Articles without an image require default styling

Current article auto-displays the top image on the article:

If articles have no image (for example Press Releases would not necessarily have an image or a breaking news article may not yet have an image but we could update later with an image) then the article looks janky on the news view.

Review integrate access_unpublished to provide time-limited access to unpublished content with unique URL

From access_unpublished:

Easy to use module grants access to view unpublished content to anyone who has a unique URL and appropriate permissions. Visitor can be anonymous or authenticated user with the user role.

Review whether this is wanted functionality (it is now part of Thunder v2)?

Update behat tests

We want to start to use our docker images in Travis, in order to do that we need to update some functions or use different ones.

List of features failing:

    tests/behat/features/media.feature:5
    tests/behat/features/media.feature:20
    tests/behat/features/media.feature:62
    tests/behat/features/search.feature:9
    tests/behat/features/search.feature:15
    tests/behat/features/search.feature:20

Removed not-on-travis tag from article.feature
Added files_path and deleted travis suite in behat.yml
Replaced all wait Ajax loading to wait 3 secs

Link

Make bg colour fields optional

Currently we have some components with bg colour field required some not. For those required we had to add an option "no colour". We have decided to make them all not required so we can have the option "none" as default.

Remove legacy Drupal makefiles

The following files are part of the repo still:

however these aren't used anymore since we use composer for everything. We need to remove these.

When contributing the profile to d.o. we might need to re-add specific makefiles, as the documentation still forces you to use makefiles, but we'll re-add this then.

Remove modernizr from composer

Now we have grunt task to download modernizr.

We need to remove it from composer and enable it in grunt.

grunt.registerTask('build', [
    // only needed if you have your own components
    // 'sass_globbing',
    'sass',
    'concat',
    'uglify',
    // we need to remove modernizr downloading via composer first so we can enable it and let grunt build it
    // 'modernizr',
    'kss',
    // 'imagemin'
  ]);

Exclude articles from being categorised as 'All'

There are certain instances where we do not want an article to be pulled through onto article aggregator views (e.g. an email landing page which links to a specific moment-in-time piece of marketing).

Similarly for the articles which we are using as Press Releases. they should be excluded from the main news aggregator views.

Implementation Plan

Add a boolean field to news articles titled "Exclude articles from aggregator views", off by default.
Add filter to view to make fields that have "Exclude articles from aggregator views" on, to be excluded from results.

Change RabbitMQ message to write to serverless queue

Currently, a thank-you message is added to the welcome_queue, which in turn is being consumed by smart_consumer. We'll replace this consumer with serverless_consumer, which accepts a slightly different message format.

Adapt to new message format
https://github.com/comicrelief/serverless-mailer/issues/2 to support a generic thank-you message for ESU
Adapt behat tests to work with new message format

RabbitMQ format: https://github.com/comicrelief/serverless-mailer/blob/master/docs/message_formatting.md

Articles block defined by category

General use case: In order to auto-display templated content on pages on a website, we need to be able to display articles based on their category - for example on cr.com: Press Releases only on the media centre page or Grants initiatives only on the grants page.

The category would also be required to not display on 'All news'

Update to drupal 8.3.x

Follow-up from first attempt in #859 (we got stuck at the content_moderation upgrade path).

~~Unofficial upgrade path that can be tried now is described in https://www.drupal.org/node/2846618~~

Behat - fix user feature test to run local

Test fails in local env.
Status code not available from selenium driver.

Remove the config of /news-tv-and-events/ from news page set up in platform

News landing page for RND was built under the section of /news-tv-and-events/ - this is only relevant to that specific site. We need to replace this logic in the Campaign code base.

The platform config should be just “the initial state” and every site later onwards can do what they want with the config (quote from @pvhee )

1.17.0

Upgrades

Add Tag dropdown to editor library view

Editors currently can apply a few different actions to many of the same content via the editor library view drop down (see admin list)

We need to review what is currently on this list - but one request is that applying tags could be an action which can be done from the library view rather than having to open each article and apply individually (image to be provided by content team).

Improve README

I think is better if we add in the documentation install composer and do a "composer global require drush/drush phing/phing" to get everything rather than the actual way. @pvhee @peter-brady

Remove phing files from repo

We've fully adopted composer in favor of phing. Remove legacy phing files from the repo

CHANGELOG.md

Generated via https://github.com/skywinder/github-changelog-generator

comicrelief / campaign Goto Github PK

campaign's People

Contributors

Stargazers

Watchers

Forkers

campaign's Issues

Edit:

Implementation Plan

Change Log

1.22.0 (2016-12-20)

1.21.0 (2016-12-14)

1.20.0 (2016-12-07)

1.19.0 (2016-11-23)

1.18.0 (2016-11-17)

1.17.0 (2016-11-16)

1.16.0 (2016-11-03)

1.15.0 (2016-10-26)

1.14.0 (2016-10-19)

1.13.0 (2016-10-05)

1.12.0 (2016-09-23)

1.11.0 (2016-09-14)

1.10.2 (2016-09-08)

1.10.1 (2016-09-08)

1.10.0 (2016-09-06)

1.9.1 (2016-09-01)

1.9 (2016-08-31)

1.8.1 (2016-08-25)

1.8 (2016-08-23)

1.7 (2016-08-17)

1.6 (2016-08-05)

1.5 (2016-08-04)

1.4 (2016-08-03)

1.3 (2016-08-01)

1.2 (2016-07-25)

1.0-alpha2 (2016-06-15)

1.0-alpha1 (2016-05-19)

Recommend Projects

Recommend Topics

Recommend Org