When showing the baits used in a trip summary, the baits are scrollable. They should have the same behavior as the catch summary (show 3 and a "more" button).
A lot of the species sections are shown as the same color. When selected, the correct color shows almost as a border around the outside of that section. It's almost as if there's another layer on top of the chart that's covering the correct layer.
Should test on multiple devices. E: This does not occur on all devices. It is fine on the Galaxy S5, but is broken on the Nexus 5X.
In theory a feature like this would be quite simple. Merger will the the priority item (i.e. the properties of merger are kept when there's a conflict) and mergee will be the item being merged with merger.
User selects a merger
User selects a mergee
Properties are merged, favouring merger in a conflict
Mergee's relationships (catches, baits, locations, etc.) are transferred to merger
Mergee is deleted
Copied from original issue: cohenadair/AnglersLog-Android#41
Add a "skunked" checkbox for trips. EDIT: Probably don't even need a checkbox. This can easily be auto detected if there were no catches added to the trip.
Copied from original issue: cohenadair/AnglersLog-Android#23
Users aren't supposed to be able to delete from a PartialListActivity.
Since PartialListActivities (I think) use a XxxListAdapter, there will be leftover long touch events that user's can utilize from a PartialListActivity.
Reproduction steps:
Open a Trip summary that has > 3 catches
Try to edit or delete an item
Crash
Desired behaviour options:
Do not allow users to edit and/or delete items from a PartialListActivity (original intention), or
Allow them to delete, which will affect the overall Logbook, not just the entity that uses the PartialListActivity (i.e. trip, bait) - this may not work because of SQLite constraint, or
Give options specific to the current entity:
For a trip - "Edit", "Remove from this trip"
For a bait - "Edit" (remove will not work because catches aren't manually added to baits), or
This would require a little more work, but would allow users to edit entities from anywhere:
Utilize MyListFragment inside a PartialListActivity which should give all the same capabilities of MainActivity to PartialListActivity
To make this nicer, an abstract MyListActivity should work, which will then be a superclass to MainActivity and PartialListActivity.
Note: the crossed out options will add too much navigation confusion, I think, but will be implemented via #124
Users need to go into "Add Catch" or "Add Bait" to manage primitives (species, fishing methods, etc.). On iOS, they can be managed from the menu.
Solution
Add primitives to the navigation drawer, and convert from a dialog to a normal activity. Mimic iOS behaviour when it comes to managing items in the lists.
Each time ManageFishingSpotFragment is resumed (it appears) the fishing spot list is reinitialized without removing the old spots, resulting in a lot of duplicate fishing spots.
Users requested for some other location data (in addition to weather) such as:
moon/lunar phases -- requested 7 times
tide (in/out) tide stage in days (biggest <--> smallest), tidal coefficient -- requested 8 times
barometric pressure -- requested 3 times
wind direction -- requested 5 times
air pressure -- requested 4 times
weather description -- requested 1 time
water levels per body of water -- requested 1 time
Solution
A nice implementation of this would be to use the last known user location to get and display this data when a user goes to add a Catch. A LocationManager can be implemented that keeps track of the user's location so that it's instantly accessible when adding catches.
They also suggested to use a photo's metadata to gather some of this information. If the photo has a location attached to it, it can be cross-referenced with the user's locations and possibly automatically have a selected location for the user.
Update: User only experienced this once. After continuing to add catches everything worked as normal. Should test a fresh install and see what happens.
Copied from original issue: cohenadair/AnglersLog-Android#7
If users don't fill out a field in the edit weather dialog they are shown a "Please fill out all fields" dialog. Clicking OK on this dialog will both the warning and edit weather dialogs. It should only close the warning.
Copied from original issue: cohenadair/AnglersLog-Android#34
When sharing log items, users should be given the option to choose what the want to share. For example, if a user wants to share a trip, they should be able to select if they want to share photos, locations, catches, etc.
On some devices, it appears that an InputButtonView and Button.Borderless themed buttons has incredibly light text when an item (such as a species) has been selected.
Issue was first noticed on a Samsung SM-T210R running SDK level 19. E: This is an API level 19 issue.
A "Rate Angers' Log" or "Provide Feedback" button should be added to the navigation drawer. Also, the Bugs & Feedback link in Settings should be changed to "Bugs & Suggestions".
Copied from original issue: cohenadair/AnglersLog-Android#18