Comments (5)
Yeah good point - guessing noticed this because you rely on connInfo
in a handler using the std lib http
server?
Alongside supporting std lib, we also want to support the likes of oak
etc., e.g. see https://github.com/oakserver/oak#handle-method.
The second conn
arg for Oak is a superset of connInfo
I implemented for the std lib so suspect can just passing the full conn
and that should work for most / all use-cases. Will just need some loose typing, e.g.
interface ConnLike extends ConnInfo {}
from superdeno.
@asos-craigmorten , yea that sounds reasonable. I haven't looked into the other frameworks/tools this library tries to support tho.. And when testing I guess it can just pass in a fake ConnLike or make a method to allow the user to specify it? Something like:
superdeno(...)
.setConn()
?
from superdeno.
@asos-craigmorten , yea that sounds reasonable. I haven't looked into the other frameworks/tools this library tries to support tho.. And when testing I guess it can just pass in a fake ConnLike or make a method to allow the user to specify it? Something like:
superdeno(...) .setConn()?
Okay, I took a look at the code and find my previous statement doesn't make much sense and the connection info is not easy to mock in this case. Looks like we just need to fix the typing and actually pass the connInfo to the handler function in the managed server instance.
from superdeno.
Going to reopen as think this is valid, and be good to keep to track the fix/feature (depending on how see it!)
from superdeno.
I'm rewriting tinyhttp for native http and I faced a similar problem. The app.handle
needs both req
and connInfo
from superdeno.
Related Issues (20)
- Submitting a payload with a get request results in request termination error HOT 5
- 4xx and 5xx response missing body and text HOT 4
- [BUG] Error thrown on empty body responses (e.g. 304)
- Consider using Pagic to build the website? HOT 1
- [BUG] res.header vs res.headers typescript issues
- [CHORE] Use Deno's inspect instead of one from NPM HOT 2
- SuperDeno does not process headers in the response from Opine HOT 4
- Re-introduce multiple cookie headers in test HOT 1
- Question: testing if header doesn't exist HOT 2
- Expected "Hello World" response body, got "HTTP/1.1 20" HOT 10
- Support new [email protected]/http API HOT 3
- Error: Request has been terminated for native http server HOT 4
- Couldn't make `multipart/form-data` requests with oak. HOT 4
- Getting async leaking error when testing opine v2 HOT 3
- Attach is possibly not sending the actual file to the app HOT 1
- Question: How to run superdeno with plain deno server HOT 2
- Can this be used with `express`? HOT 1
- How does superdeno intercept redirects? HOT 8
- Release 1.5 causing an error on download HOT 3
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from superdeno.