Giter Club home page Giter Club logo

Comments (4)

cmorten avatar cmorten commented on May 27, 2024 1

Have released https://deno.land/x/[email protected] which should be more useful when debugging issues in future. Issue appears to lie with tinyhttp so closing the issue. Feel free to reopen if find otherwise!

from superdeno.

cmorten avatar cmorten commented on May 27, 2024

So the error seeing internally with some extra logging is:

TypeError: error sending request for url (http://127.0.0.1:54365/): connection closed before message completed
    at async mainFetch (deno:ext/fetch/26_fetch.js:265:14)

Yet to determine if an issue with superdeno, tinyhttp, or the compat between the two.

(FYI this is using request.handler as request._server is undefined for the above snippet)

from superdeno.

cmorten avatar cmorten commented on May 27, 2024

Digging further, this is the output from logging the request passed into app.handle from tinyhttp, and the subsequent error that it throws:

request Request {
  bodyUsed: false,
  headers: Headers {
  accept: "*/*",
  "accept-encoding": "gzip, br",
  host: "127.0.0.1:54765",
  "user-agent": "Deno/1.16.2"
},
  method: "GET",
  redirect: "follow",
  url: "http://127.0.0.1:54765/"
}

app error TypeError: Cannot read properties of undefined (reading 'settings')
    at handler (https://denopkg.com/deno-libs/tinyhttp@new-std-http/app.ts:216:33)
    at Server.handler (file:///Users/craigmorten/git/asos-craigmorten/superdeno/src/superdeno.ts:90:34)
    at Server.#respond (https://deno.land/[email protected]/http/server.ts:350:43)
    at Server.#serveHttp (https://deno.land/[email protected]/http/server.ts:396:20)

It appears that the issue lies with the handler having some implicit reliance on a bootstrapping step where this.settings is populated, but in the case of using app.handler standalone this isn't happening --> https://github.com/deno-libs/tinyhttp/blob/new-std-http/app.ts#L216

from superdeno.

cmorten avatar cmorten commented on May 27, 2024

Going to add some error logging to superdeno so it is clearer when it is the underlying app handler at fault and what the error is.

from superdeno.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.