Comments (4)
Have released https://deno.land/x/[email protected] which should be more useful when debugging issues in future. Issue appears to lie with tinyhttp
so closing the issue. Feel free to reopen if find otherwise!
from superdeno.
So the error seeing internally with some extra logging is:
TypeError: error sending request for url (http://127.0.0.1:54365/): connection closed before message completed
at async mainFetch (deno:ext/fetch/26_fetch.js:265:14)
Yet to determine if an issue with superdeno, tinyhttp, or the compat between the two.
(FYI this is using request.handler
as request._server
is undefined
for the above snippet)
from superdeno.
Digging further, this is the output from logging the request passed into app.handle
from tinyhttp, and the subsequent error that it throws:
request Request {
bodyUsed: false,
headers: Headers {
accept: "*/*",
"accept-encoding": "gzip, br",
host: "127.0.0.1:54765",
"user-agent": "Deno/1.16.2"
},
method: "GET",
redirect: "follow",
url: "http://127.0.0.1:54765/"
}
app error TypeError: Cannot read properties of undefined (reading 'settings')
at handler (https://denopkg.com/deno-libs/tinyhttp@new-std-http/app.ts:216:33)
at Server.handler (file:///Users/craigmorten/git/asos-craigmorten/superdeno/src/superdeno.ts:90:34)
at Server.#respond (https://deno.land/[email protected]/http/server.ts:350:43)
at Server.#serveHttp (https://deno.land/[email protected]/http/server.ts:396:20)
It appears that the issue lies with the handler having some implicit reliance on a bootstrapping step where this.settings
is populated, but in the case of using app.handler
standalone this isn't happening --> https://github.com/deno-libs/tinyhttp/blob/new-std-http/app.ts#L216
from superdeno.
Going to add some error logging to superdeno
so it is clearer when it is the underlying app handler at fault and what the error is.
from superdeno.
Related Issues (20)
- Submitting a payload with a get request results in request termination error HOT 5
- 4xx and 5xx response missing body and text HOT 4
- [BUG] Error thrown on empty body responses (e.g. 304)
- Consider using Pagic to build the website? HOT 1
- [BUG] res.header vs res.headers typescript issues
- [CHORE] Use Deno's inspect instead of one from NPM HOT 2
- SuperDeno does not process headers in the response from Opine HOT 4
- Re-introduce multiple cookie headers in test HOT 1
- Question: testing if header doesn't exist HOT 2
- Expected "Hello World" response body, got "HTTP/1.1 20" HOT 10
- Support new [email protected]/http API HOT 3
- Couldn't make `multipart/form-data` requests with oak. HOT 4
- Getting async leaking error when testing opine v2 HOT 3
- Attach is possibly not sending the actual file to the app HOT 1
- `HandlerLike` signature doesn't match actual `server.Handler`. Missing `connInfo` HOT 5
- Question: How to run superdeno with plain deno server HOT 2
- Can this be used with `express`? HOT 1
- How does superdeno intercept redirects? HOT 8
- Release 1.5 causing an error on download HOT 3
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from superdeno.