Unclear how to use `--skip-drain=` in bosh deploy about bosh-cli HOT 12 CLOSED

yup looks like value-name is missing similar to what we've done here: 33f5c26

from bosh-cli.

Related: https://www.pivotaltracker.com/story/show/130417399

from bosh-cli.

@voelzmo I believe the commits in the above story should cover the cases you mentioned, though explicitly specifying wildcard still isn't in the -h output because it's the default behavior.

It might be nice to update the documentation to state more clearly that you pass --skip-drain multiple times if you want to skip more than 1 instance group. @cppforlife thoughts?

from bosh-cli.

@tjvman not sure what you mean by specifying a wildcard "is the default behavior". I had to look into the code to figure out that * is a valid value. Right now, this is what I get for bosh deploy --help in terms of skipping drain:

--skip-drain=INSTANCE-GROUP    Skip running drain scripts for specific instance groups

While that is better than before, there are some details missing:

• I can enter individual instances in the form instance-group/uuid
• I can enter * as a wildcard or just leave out an argument to have it match all instances (i.e. =INSTANCE-GROUP is optional)
• I can specify this option multiple times (this also applies to many other options like -o, -v, etc)

As stated in my original comment, I'm not sure how to best do this with go-flags here.

from bosh-cli.

Going to close and reopen to generate a tracker story.

from bosh-cli.

We have created an issue in Pivotal Tracker to manage this:

https://www.pivotaltracker.com/story/show/160773274

The labels on this github issue will be updated when the story is started.

from bosh-cli.

Hello,

It looks like we have not responded to this in a reasonable time, and unfortunately a year has passed. Given this, we are going to close the issue, but please feel free to re-open the issue. In doing so, a new Pivotal Tracker story will be generated, and we can revisit this.

Thanks again for submitting this, and apologies for closing without a proper resolution at this moment.

BOSH Systems Team - @aashah @luan @jaresty

from bosh-cli.

We have created an issue in Pivotal Tracker to manage this:

https://www.pivotaltracker.com/story/show/164752720

The labels on this github issue will be updated when the story is started.

from bosh-cli.

Reopened as requested. Not sure this triggers creation of a new story though.

from bosh-cli.

Hey, we took a look at this issue and think it ought to be discussed with our PM. We gave the story a label (pre-ipm) to ensure we discuss it this coming Friday.

Thanks,
Aakash & @jaresty

from bosh-cli.

The story has now moved to the director backlog. The CLI has the same behaviour as the last output above.

Additionally, clicking through to the docs was disappointing: https://bosh.io/docs/cli-v2/#deploy. No information about subcommands. Adding https://www.pivotaltracker.com/story/show/165466904 to update the docs.

from bosh-cli.

The CLI output was fixed here and the docs updated. The change should be available in the next version of the CLI.

Diego & @rkoster

from bosh-cli.