Giter Club home page Giter Club logo

Comments (7)

klakin-pivotal avatar klakin-pivotal commented on August 20, 2024

Replacing it would be backwards-incompatible, and I would strongly veto that.

from bosh-cli.

Benjamintf1 avatar Benjamintf1 commented on August 20, 2024

As an alias and deprecate force?

from bosh-cli.

klakin-pivotal avatar klakin-pivotal commented on August 20, 2024

Alias, maybe. Deprecate, definitely not.
[And I say "maybe" because I don't know if the alternative spelling is the best one, and am not sure that the --force flag is actually a problem. Making an alias of a nicely-named flag, if the current one is a problem is something I'd support.]

from bosh-cli.

psycofdj avatar psycofdj commented on August 20, 2024

@Benjamintf1, Aliasing --force by --dev-release does not seem to be a good idea since --force is not equivalent of building a dev release. It only deactivates the git dirty state check and --final and --force flags are not mutually exclusive.

Another possible approach could be to disable dirty git check by default when building a dev release (ie. flag --final not given). The idea behind this being:

  • when I want to build a final release: I'm glad that git dirty state is checked and I can deactivate it if needed
  • when I want to build a dev release: I just want my tarball, I don't care about git, generated files aren't even known to git

from bosh-cli.

Benjamintf1 avatar Benjamintf1 commented on August 20, 2024

I guess I'm forgetting that dev-release is it's own concept and can be finalized too. Perhaps --dev-release is a poor overloaded term here.

I do worry the degree i've seen --force --final out in the field and I wonder if changing the flags that are used could discourage these sort of patterns.

I don't want to distract yall too much, It's just something that's been rolling around the back of my head.

from bosh-cli.

beyhan avatar beyhan commented on August 20, 2024

I also agree that the change should be backwards compatible. Looking into the bosh create-release --help the --force flag explanation is quite clear Ignore Git dirty state check. The dirty state of the git repository could have an affect to the generated bosh-release that is why I think is a good idea to require explicit confirmation from the user that it is OK to ignore the dirty state. Even removing the check only for the dev releases is backwards-incompatible change and I'n not sure whether we should go that way. If yes, at least we should print a warning during the release generation.

from bosh-cli.

rkoster avatar rkoster commented on August 20, 2024

It feels like this discussion has reached its natural conclusion and no further actions are needed.

from bosh-cli.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.