Comments (7)
Replacing it would be backwards-incompatible, and I would strongly veto that.
from bosh-cli.
As an alias and deprecate force?
from bosh-cli.
Alias, maybe. Deprecate, definitely not.
[And I say "maybe" because I don't know if the alternative spelling is the best one, and am not sure that the --force
flag is actually a problem. Making an alias of a nicely-named flag, if the current one is a problem is something I'd support.]
from bosh-cli.
@Benjamintf1, Aliasing --force
by --dev-release
does not seem to be a good idea since --force
is not equivalent of building a dev release. It only deactivates the git dirty state check and --final
and --force
flags are not mutually exclusive.
Another possible approach could be to disable dirty git check by default when building a dev release (ie. flag --final
not given). The idea behind this being:
- when I want to build a final release: I'm glad that git dirty state is checked and I can deactivate it if needed
- when I want to build a dev release: I just want my tarball, I don't care about git, generated files aren't even known to git
from bosh-cli.
I guess I'm forgetting that dev-release is it's own concept and can be finalized too. Perhaps --dev-release is a poor overloaded term here.
I do worry the degree i've seen --force --final
out in the field and I wonder if changing the flags that are used could discourage these sort of patterns.
I don't want to distract yall too much, It's just something that's been rolling around the back of my head.
from bosh-cli.
I also agree that the change should be backwards compatible. Looking into the bosh create-release --help
the --force
flag explanation is quite clear Ignore Git dirty state check
. The dirty state of the git repository could have an affect to the generated bosh-release that is why I think is a good idea to require explicit confirmation from the user that it is OK to ignore the dirty state. Even removing the check only for the dev releases is backwards-incompatible change and I'n not sure whether we should go that way. If yes, at least we should print a warning during the release generation.
from bosh-cli.
It feels like this discussion has reached its natural conclusion and no further actions are needed.
from bosh-cli.
Related Issues (20)
- BOSH CLI commands to automatically add diego cell or Create VM on which containers can be deployed on . HOT 1
- [Question] About release v6.4.8 HOT 5
- Running deploy with a certain variable value panics HOT 3
- BOSH CLI on Windows platform is holding file lock on ssh-known-hosts file prevent ssh child process to read it HOT 4
- Release binaries for arm64 HOT 2
- Set the the ACL when uploading to S3 HOT 3
- Allow importing bosh-cli v6.4.2 as a dependency HOT 2
- TLS handshake failure occurs when downloading bosh-release HOT 2
- bosh upload-release (from source) ignores local changes HOT 2
- Specifying instances by index ambiguous HOT 3
- Updating package via bosh `vendor-package --prefix` does not honor prefix on dependent packages HOT 3
- Adding `--preview` parameter to bosh deploy command before commencing deployment HOT 5
- Creating releases with blobs are broken on Windows HOT 3
- delete_stemcell is causing bosh CLI to fail when stemcell already does not exist HOT 2
- Is a internal ca certificate can be used for HOT 2
- [Windows] Missing bosh create-env support HOT 12
- Default interpolated x509 certificates have invalid 3 digits USA country code
- CLI crashes on trying to select multiple columns to print HOT 4
- bosh-cli didn't read the trailing zero '0' of stemcell version in manifest HOT 1
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from bosh-cli.