Giter Club home page Giter Club logo

Comments (6)

grant avatar grant commented on May 28, 2024

It's not required and these versions are seldomly used since 1.0 came out.

from sdk-python.

di avatar di commented on May 28, 2024

I don't see why we need to intentionally create breaking changes for end users. I think I'd prefer saying the new "pythonic" API only supports v1 and v0.3 and that eventually when we deprecate the old API, we'll remove it entirely, including support for these versions.

from sdk-python.

cumason123 avatar cumason123 commented on May 28, 2024

Seems reasonable. I'm going to remove my existing PR and instead change sample code and README to using v1/v03 classes

from sdk-python.

grant avatar grant commented on May 28, 2024

@di 0.1, 0.2 events are strictly not required to be supported according to the spec.
https://github.com/cloudevents/spec/blob/master/SDK.md

This is common amongst other SDKs.
Besides, there are very few event producers that use < 1.0 events.

Previous publications can be used by existing users if they need this support.

It should be OK to remove these event versions like we've done so for other language SDKs.

from sdk-python.

di avatar di commented on May 28, 2024

OK, looks like this happened anyways.

Please update CHANGELOG.md to indicate to users that this is removed in the future version. This wasn't done in #43, I didn't have an opportunity to review that PR.

from sdk-python.

grant avatar grant commented on May 28, 2024

Yes, I merged the PR as it aligns with other language SDKs and the spec.

Looking for a review on #36 before continuing.

from sdk-python.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.