`cloudevents.kafka.to_binary` checks for a `content-type` attribute, which would not be a valid attribute name about sdk-python HOT 5 OPEN

Hi! I would be happy to work on this!

from sdk-python.

Hey @aucampia, thx for raising this. I believe you're correct and the event itself must not contain the content-type attribute. The conversion here should convert the datacontenttype of the event to the content-type header of the Kafka message.

Ans similarly the backwards conversion must take care of the respective mapping.

Here's the supportive docs section: https://github.com/cloudevents/spec/blob/30f1a081743bfe06b45b85519dd145f14a1ad22c/cloudevents/bindings/kafka-protocol-binding.md#321-content-type

from sdk-python.

I want to, but realistically I probably won't get to it before the end of next week, though I may look at it then. Will notify before I start working on it though.

from sdk-python.

someone want to PR this?

from sdk-python.

I'm out of capacity till the end of next week as well. Even though it's a small change in the codebase, I'd appreciate a PR. If none will start working on it, I'll find some time next week.

from sdk-python.