Giter Club home page Giter Club logo

Comments (3)

xSAVIKx avatar xSAVIKx commented on June 21, 2024

Hey @gaborbernat, thx for pointing this out. Is there any info on how one may support both v1 and v2 of Pydantic? While switching to v2 completely will break things for the library users.

from sdk-python.

gaborbernat avatar gaborbernat commented on June 21, 2024

I don't think there's support for supporting both... You could do some gimnastics to switch implementation based on detected version 🤷‍♂️ but will get messy.

from sdk-python.

febus982 avatar febus982 commented on June 21, 2024

The main problem could be testing but the pydantic V2 implementation includes the old V1, namespaced in the pydantic.v1 module.

It looks horrible but importing the BaseModel like this might work:

pydantic_version = pydantic.version.VERSION.split('.')[0]

from pydantic import BaseModel as BaseModelV2
if pydantic_version == '1'
    from pydantic BaseModel as BaseModelV1
else
    from pydantic.v1 BaseModel as BaseModelV1

class _CloudEventBaseV1(BaseModelV1):
   # Existing implementation

class _CloudEventBaseV2(BaseModelV2):
   # Pydantic V2 configured model
   
if pydantic_version == '1':
    CloudEvent = _CloudEventBaseV1
else:
    CloudEvent = _CloudEventBaseV2

It looks horrible, I know.

from sdk-python.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.