Giter Club home page Giter Club logo

Comments (6)

longemen3000 avatar longemen3000 commented on August 16, 2024

Oh, I see, they got mixed, same thing happened with decalin before, this just slipped out of my sight

from clapeyron.jl.

MichaelGadaloff avatar MichaelGadaloff commented on August 16, 2024

Ah ok fair enough - thank you for replying so quickly. I think I also found another one: cis-2-pentene (line 630 in the Clapeyron CSV) is labelled as 2-pentene

from clapeyron.jl.

prehner avatar prehner commented on August 16, 2024

Hi, to avoid confusion, can I suggest using the acronym PCP-SAFT for the version based on the dipolar term by Gross and Vrabec (and used by Esper et al.)? There is also a PPC-SAFT out there that is mainly developed by the groups of de Hemptinne and NguyenHuynh but that uses a different term for polar contributions.

from clapeyron.jl.

pw0908 avatar pw0908 commented on August 16, 2024

Hi, I knew there was a difference between PCP and PPC SAFT but I always assumed the Gross version was PPC since it just sounds more "correct"? I think there's also quite a few different implementations of "Polar PC-SAFT" beyond just Gross, de Hemptinne and NguyenHuynh (I think Chapman has his own?).

As an aside: have you benchmarked the dipole-quadrupole term in feos? The coefficients don't quite look the same as in the paper and there's an additional pi^2 in front of the a_3 term. The tests don't seem to cover this term and the original paper doesn't provide the parameters needed to reproduce the results.

from clapeyron.jl.

prehner avatar prehner commented on August 16, 2024

The dipole-quadrupole term is a bit of an issue in feos as well, because we are not sure whether the only reference implementation that we have is correct. The issue with the pi^2 should be clear though: It can either be absorbed in the correlation integral parameters (which would lead to a deviation close to factor 10) or left there as prefactor in a_3.

from clapeyron.jl.

longemen3000 avatar longemen3000 commented on August 16, 2024

On the PPCSAFT vs PCPSAFT naming issue, we can just add an alias that makes those equivalent in the meanwhile.

from clapeyron.jl.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.