Comments (3)
On the documentation, admittedly, it's not in the most obvious place, but we did document the fact that we do have no combining rule is the default: https://clapeyronthermo.github.io/Clapeyron.jl/dev/api/parameters/#Clapeyron.AssocOptions.
As for what the default should be, the difficulty is that did SAFT equations use different combining rules (I believe that SAFT-VR Mie uses Elliott whereas CPA using CR1. When it comes to specifying association parameters though, I do believe that it is better to leave the combining rule off by default as, when you get to SAFT-VR Mie / gamma Mie where you have H, e1, e2 and a1 association sites where you don't necessarily expect cross-association between everything, it's safer to leave it up to the user to specify.
I will add some docs on that in the documentation that I'm updating.
from clapeyron.jl.
Happy to report the updated docs do explicitly highlight how the association interactions can be adjusted: https://github.com/ClapeyronThermo/Clapeyron.jl/blob/docs-update/docs/src/tutorials/basics_model_construction.md
from clapeyron.jl.
If you explicitly select CPA/sCPA, I feel like the default sent to the association term should be CR1. Or at least, it should be clearly documented in the model documentation for all the relevant models that the combining rule is not set at all. I see your point about the nuances of how the association term gets used in other places, and sympathize. I'm struggling with the same thing in teqp now.
from clapeyron.jl.
Related Issues (20)
- Parameter Estimation for sle_solubility HOT 14
- UNIFAC ether and aldehyde groups error HOT 3
- Defining a custom alpha HOT 2
- COFFEE equation of state
- EOS-CG 2021 HOT 7
- user defined eos HOT 2
- Induced-Association Interactions in SAFT HOT 16
- Saturation solves fail moving from 0.5.7 to 0.5.8 HOT 4
- Move CPA input to use SI values
- Units of property functions HOT 9
- Help with modelling activity coefficients in UNIFAC HOT 3
- Wrong conversion of parameters for water in CPA HOT 10
- Installation problems with precompilation (`Setfield` not defined) HOT 4
- Evaluation of CPA at too high a density yields no error, just NaN HOT 4
- Possible issue with bubble and dew point estimation (or SAFT-gamma Mie) HOT 2
- Ask for help with sCPA calculating the molar volume of water HOT 7
- Simple example with activity coefficient model and antoine parameters for saturation pressure? HOT 3
- modified LKP and LKP-SJT
- Clarification/issue in SoftSAFT implementation HOT 13
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from clapeyron.jl.