Giter Club home page Giter Club logo

Comments (7)

ianhbell avatar ianhbell commented on August 16, 2024

In that vein, you might want to also add the GERG-2008 model for natural gas. I just added it to teqp: usnistgov/teqp#79

from clapeyron.jl.

longemen3000 avatar longemen3000 commented on August 16, 2024

GERG2008 is already in Clapeyron (GERG2008), it uses the same general infraestructure as the multiparameter fluids (with an addon for the difference in R)

from clapeyron.jl.

ianhbell avatar ianhbell commented on August 16, 2024

@longemen3000 Ah cool, didn't realize that.

from clapeyron.jl.

longemen3000 avatar longemen3000 commented on August 16, 2024

implemented in 0.5.11

from clapeyron.jl.

ianhbell avatar ianhbell commented on August 16, 2024

Nice! Did you implement test values to be sure all the models are exactly the same?

from clapeyron.jl.

longemen3000 avatar longemen3000 commented on August 16, 2024

Not yet, I couldn't find test values of EOS-CG-2021 in the original paper. But on the code part, it just reuses the general MultiFluid code, so the only test necessary is that the data values stored in the database are correct

On the data part, for the pure fluid, the fluids are taken from CoolProp JSONs or ported via REFPROP-interop. On the mixture models, I reused the existing ones where available (from EOS-LNG + some Coolprop mixture models), except the one with typos in the publication, that I have to extract from the paper itself(I have a function that generates mixture jsons from paper tables, so it is not completely manual).

from clapeyron.jl.

ianhbell avatar ianhbell commented on August 16, 2024

One key point is to make sure that you are definitely, 100%, using the pure fluid models that are specified in the document.

from clapeyron.jl.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.