Comments (7)
In that vein, you might want to also add the GERG-2008 model for natural gas. I just added it to teqp: usnistgov/teqp#79
from clapeyron.jl.
GERG2008 is already in Clapeyron (GERG2008
), it uses the same general infraestructure as the multiparameter fluids (with an addon for the difference in R)
from clapeyron.jl.
@longemen3000 Ah cool, didn't realize that.
from clapeyron.jl.
implemented in 0.5.11
from clapeyron.jl.
Nice! Did you implement test values to be sure all the models are exactly the same?
from clapeyron.jl.
Not yet, I couldn't find test values of EOS-CG-2021 in the original paper. But on the code part, it just reuses the general MultiFluid
code, so the only test necessary is that the data values stored in the database are correct
On the data part, for the pure fluid, the fluids are taken from CoolProp JSONs or ported via REFPROP-interop. On the mixture models, I reused the existing ones where available (from EOS-LNG + some Coolprop mixture models), except the one with typos in the publication, that I have to extract from the paper itself(I have a function that generates mixture jsons from paper tables, so it is not completely manual).
from clapeyron.jl.
One key point is to make sure that you are definitely, 100%, using the pure fluid models that are specified in the document.
from clapeyron.jl.
Related Issues (20)
- Data extraction from csv file HOT 7
- Parameter Estimation for sle_solubility HOT 14
- UNIFAC ether and aldehyde groups error HOT 3
- Defining a custom alpha HOT 2
- COFFEE equation of state
- user defined eos HOT 2
- Induced-Association Interactions in SAFT HOT 16
- Saturation solves fail moving from 0.5.7 to 0.5.8 HOT 4
- Move CPA input to use SI values
- Units of property functions HOT 9
- Help with modelling activity coefficients in UNIFAC HOT 3
- Wrong conversion of parameters for water in CPA HOT 10
- Installation problems with precompilation (`Setfield` not defined) HOT 4
- Surprising default combining rule in association term HOT 3
- Evaluation of CPA at too high a density yields no error, just NaN HOT 4
- Possible issue with bubble and dew point estimation (or SAFT-gamma Mie) HOT 2
- Ask for help with sCPA calculating the molar volume of water HOT 7
- Simple example with activity coefficient model and antoine parameters for saturation pressure? HOT 3
- modified LKP and LKP-SJT
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from clapeyron.jl.