christopherjenness / nba-player-movement Goto Github PK

For example, see: https://github.com/christopherjenness/NBA-player-movement/blob/master/examples/Curry3.gif

The functionality is awesome, but the color schemes used to track the players in the gifs might be easier to visually track from the user with more contrasting color options for the opposing teams, and especially for the central player (i.e., in your Curry demo). Might I suggest selecting "Triad" in https://color.adobe.com/create to see color combinations (along with their respective Color RGB values)? This might help the user utilize the final product in a more visually effective way.

I believe there could possibly be compilation issue due to dependencies on the third party project "https://www.github.com/neilmj" within the "_get_tracking_data" function.

Everything is python 3 compatible except for some reason the ffmpeg call in python 3 has a number of issues.

Currently, the play by play is retrieved from stats.nba.com. Recently, they updated their system to try to prevent non-browser access to the site. I made a quick hack to get around it, but I assume it will break again soon. I think we should move over to basketball-reference for play-by-play data.

File "D:\new win10\workspace\hupu\third\game\game.py", line 112, in _get_tracking_data
os.remove("./temp/zipdata")
FileNotFoundError: [WinError 2] 系统找不到指定的文件（system cant find the file）。: './temp/zipdata'

I just discovered your repo, and it looks amazing.
However, due to the amount of gifs playing on the README, my browser crashes every time I view your repository.

Have you thought about creating an official documentation website for your code?