Giter Club home page Giter Club logo

gtk3-imageview's People

Contributors

carygravel avatar darthgandalf avatar gregoa avatar ppisar avatar

Stargazers

 avatar  avatar

Watchers

 avatar

gtk3-imageview's Issues

Zoom using mouse is confusing

The pixel under the mouse cursor position is put to the middle of the image. But it should stay where the mouse is.

Unauthorized ASOKOLOV/Gtk3-ImageView-8.tar.gz release on CPAN

There is a new ASOKOLOV/Gtk3-ImageView-8.tar.gz release on CPAN. But an author of the release (Алексей Евгеньевич Соколов) is not permitted for Gtk3::ImageView::Tool::Selector. Please either remove the release from CPAN, or grant permissions to ASOKOLOV.

Redo linter in CI

I intended the linter to run perl critic and to check formatting/spelling errors. It probably does some of these things, but definitely not formatting. The one in t/91_critic.t I didn't manage to work even locally due to different spelling dictionary, and it seems to be even worse in the CI image used

Tests fail with PerlMagick and ImageMagick 7

It seems that switching from PerlMagick and ImageMagick 6 to version 7 causes the tests to fail.

Some failures are similar to those in #18 (comment), but are happening even when the tests aren't run in parallel.

Test log:

❯ nix-build -A perlPackages.Gtk3ImageView
these derivations will be built:
  /nix/store/yz6vk18sapj606n4dppc1kv6fj8qxjwh-perl5.32.0-Gtk3-ImageView-6.drv
building '/nix/store/yz6vk18sapj606n4dppc1kv6fj8qxjwh-perl5.32.0-Gtk3-ImageView-6.drv'...
unpacking sources
unpacking source archive /nix/store/5n6jnidvg2xlmzbj82b6agy4x017kdil-Gtk3-ImageView-6.tar.gz
source root is Gtk3-ImageView-6
setting SOURCE_DATE_EPOCH to timestamp 1605623921 of file Gtk3-ImageView-6/META.yml
patching sources
configuring
Checking if your kit is complete...
Looks good
Generating a Unix-style Makefile
Writing Makefile for Gtk3::ImageView
Writing MYMETA.yml and MYMETA.json
no configure script, doing nothing
building
build flags: SHELL=/nix/store/yyy7wr7r9jwjjqkr1yn643g3wzv010zd-bash-4.4-p23/bin/bash
cp lib/Gtk3/ImageView/Tool.pm blib/lib/Gtk3/ImageView/Tool.pm
cp lib/Gtk3/ImageView.pm blib/lib/Gtk3/ImageView.pm
cp lib/Gtk3/ImageView/Tool/SelectorDragger.pm blib/lib/Gtk3/ImageView/Tool/SelectorDragger.pm
cp lib/Gtk3/ImageView/Tool/Selector.pm blib/lib/Gtk3/ImageView/Tool/Selector.pm
cp lib/Gtk3/ImageView/Tool/Dragger.pm blib/lib/Gtk3/ImageView/Tool/Dragger.pm
Manifying 1 pod document
running tests
PERL_DL_NONLAZY=1 "/nix/store/p069ycxin0x5p0436mrcdhra8b3gp69l-perl-5.32.0/bin/perl" "-MExtUtils::Command::MM" "-MTest::Harness" "-e" "undef *Test::Harness::Switches; test_harness(0, 'blib/lib', 'blib/arch')" t/*.t
t/1_basics.t ....... ok
t/2_transparent.t .. 1/4 # PNG of the shown window:
# iVBORw0KGgoAAAANSUhEUgAAASwAAADIBAMAAACg8cFmAAAABGdBTUEAALGPC/xhBQAAACBjSFJN
# AAB6JgAAgIQAAPoAAACA6AAAdTAAAOpgAAA6mAAAF3CculE8AAAAHlBMVEUAAP/29fT/AADwDwDQ
# LwDAPwBwjwBAvwAA/wD///8il637AAAAAWJLR0QJ8dml7AAAASRJREFUeNrt3MsJwkAYhVFbsAUf
# DViCYAOiNdiB2oGWLVkJkllMvISfcO5qIJAcsvl2s1oNWw/7OW1m2Nh3vycsLCwsrL9ZzSdzsPp+
# FBYWFhZWN6tofLCwsLCwIqyi8cHCwsJaMmt7uk7e5dDF6onP7vaYvPtx5IWZJu6f78l7nbGwsLAW
# zeqJT5yVaSIWFhYWVpNVND5YWFhYWBFW0fhgYWFhYUVYReODhYWFhRVhFY0PFhYWFlaEVTQ+WFhY
# WFgRVtH4YGFhYWFFWEXjg4WFhYUVYRWNDxYWFhZWhFU0PlhYWFhYEVbR+GBhYWEtmRW/MKbN6olP
# /HqdTBPjw8LCwloOqyc+8WWaiIWFhYXVZBWNDxYWFhZWhFU0PlhYWFhYCdYHQ2UCIDLQtIsAAAAA
# SUVORK5CYII=
t/2_transparent.t .. 2/4
#   Failed test 'middle pixel should be green'
#   at t/2_transparent.t line 58.
#     Structures begin differing at:
#          $got->[1] = '0'
#     $expected->[1] = '1'

#   Failed test 'there is red background'
#   at t/2_transparent.t line 71.
#          got: '0'
#     expected: '1'

#   Failed test 'there is blue outside'
#   at t/2_transparent.t line 82.
#          got: '0'
#     expected: '1'
# Looks like you failed 3 tests of 4.
t/2_transparent.t .. Dubious, test returned 3 (wstat 768, 0x300)
Failed 3/4 subtests
t/3_zoom.t ......... ok
t/4_select.t ....... ok
t/5_filter.t ....... 1/10 # PNG of the blurred window:
# iVBORw0KGgoAAAANSUhEUgAAASwAAADICAMAAABlASxnAAAABGdBTUEAALGPC/xhBQAAACBjSFJN
# AAB6JgAAgIQAAPoAAACA6AAAdTAAAOpgAAA6mAAAF3CculE8AAACMVBMVEV0c/pkZPtTU/tEQ/wy
# Mv0jI/0REf4AAP8PD/4hIf4wMP1CQfxRUftiYvtycfoAAP4CAPwDAPsEAPoFAPkGAPgHAPcIAPYJ
# APUKAPQLAPMMAPINAPEOAPAPAO8BAP0RAO0UAOoWAOgYAOYaAOQdAOEfAN8hAN0bAOMSAOwQAO4T
# AOskANonANcqANQuANAxAM0rANMoANYXAOcjANssANI1AMk6AMQ+AMBDALs/AL82AMgtANEmANg3
# AMc8AMJCALxHALdNALFTAKtOALBIALY9AME4AMYyAMwcAOJJALVQAK5XAKdeAKBlAJlfAJ9YAKZR
# AK1KALREALovAM8pANUiANxFALlVAKldAKFtAJF1AIluAJBWAKhGALggAN5ZAKViAJxrAJN0AIp9
# AIGHAHd/AH9jAJtbAKMlANlkAJp4AIaCAHyMAHKXAGeNAHGDAHt5AIVvAI8eAOAVAOlwAI57AIOG
# AHiRAG2dAGGpAFWeAGCSAGyIAHZ8AIJxAI1PAK+TAGufAF+sAFK5AEWtAFGgAF6VAGlLALOhAF2u
# AFC8AELLADO+AECwAE6jAFt6AIRSAKzbACPNADF2AIhmAJg7AMPcACLtABHeACCOAHBgAJ5AAL4w
# AM7/AADvAA/dACG7AEOrAFOZAGWJAHV3AIdnAJczAMvgAB7PAC/AAD6vAE+PAG+AAH5hAJ1BAL2/
# AD+xAE2iAFyUAGqFAHmlAFmWAGhMALJzAItcAKI5AMX////ksCFDAAAAAWJLR0S6o7FH2gAABSlJ
# REFUeNrt0GlTU2cch2G77yX7SXJOyH7CCZCYEAhbEImEEAhCSIKsURES3JDVLQioYBFQRK0K1I2l
# 7nWpFr9dnal92+kz0xf/6fzuT3DPtWPHJ59+9vkXX36F/qGvv/n2u+9/+HEHsP5FwGIIWAwBiyFg
# MQQshoDFELAYAhZDwGIIWAwBiyFgMQQshoDFELAYAhZD/yVWjkyuUKrUGk6r0/OCgUgCr9dpOY1a
# pVTIZbk5VLBkCpVGxxuMJrPFarOLRLLbHBazKc/A6ziVQkYGS67ieMlpttrE/IJCl5tIrp2efNFm
# 9ZokXquWk8FSaHij2Wov8vjcxSX+UiKVlZS7Kzz5doc5j+cUZLCUOsnsECt97kDVrurdNUQK7imt
# DdVVFIhhs6RTksFS8U6r6HEVV5XWRxoao0Rq2tvcEqstb40nHCZBTQZLbTDbK13l/mSwbV+0vYNI
# ndHGrmB3WaC1oMcrachgaYzWIl+xvzqS2n/gYO8hIvV1tPenm+vLAhUZh5PLpYLFmWwed1Uykhro
# PHzk6DEiHR88MRRNN3fX1sWHR7RksLRm0RcoDaYGRsfGT546TaQzZ7MT56LpyVjIlfDqyGDpLPnu
# qvq2/Z1j41PT5y8Q6eLMbHZiqL/rkr8uY+XJYOmtBcW7IvsOHB6f+mnu8jyRFhavzGavtjctxQLx
# sEAGi7cVllQ3RA8eOTn9weoakZYXFmemBq/fSNXf9A0byGAJdpd/d2N779FT5y/P/3yLSLeXF+am
# 7/QNrUyurokSGSyD6C6tiXYcOnb6wvy1W78Q6e695fsPHq5vbLYlt4qMwAIWsIAFLGABC1jAAhaw
# gAUsYAELWMACFrCABSxgAQtYwAIWsIAFLGABC1jAAhawgAUsYAELWMACFrCABSxgAQtYwAIWsIAF
# LGABC1jAAhawgAUsYAELWMACFrCABSxgAQtYwAIWsIAFLGABC1jAAhawgAUsYAELWMACFrCABSxg
# AQtYwAIWsIAFLGABC1jAAhawgAUsYAELWMACFrCABSxgAQtYwAIWsIAFLGABC1jAAhawgAUsYAEL
# WMACFrCABSxgAQtYwAIWsIAFLGABC1jAAhawgAUsYP2dYHeVBZs6+46fubiwfPsukX599PjJzNNn
# o88jL9ZEiQwWb9tZsmdvtGPw7MziwvI9Ij367eWr1282NlMtVT67gQyW3uEpL21ubD+Rnb3yQYtI
# j1/+/nZ9rHOlJhaKhwUyWDpLvru2pat/aCI7OzN3n0hPXr1d7x0daHjn36q08mSwtGaxIhQLpqPn
# JrJT0w+INPN6vfePze1I8r0rYdGTweJMNk9dbXdzOjp0dfDOQyI9fTM2urm9VO3fittHtGSwNHnW
# /IrysvrmdH/79b51Ij3b6BzYXmpZDbgyDidHBktt8NoLWgNl3ZNdTTeGNog0urnSEKleDa15eiyS
# JocKloo3OcR4a6A2dmkptbJJpOepmndJf2CtMBEeEdRksJQ6yRxOFFTUhfyx+sk2IkVaYv73Wy5P
# Iuw16lVksBQcn2d29GTirrrAzdUkkV5UhbZc8UxP2OsUOAUZLLlKy0smr2M4kYn71raItOaLVybs
# DsuIUdCq5WSwZAo1pxMk54jXGh4Wi4gk2sNWy4hTEvScWikjg5UrkyuUag2n1fGCQTISSTIIvF7L
# adQqhVyWSwYr569ySfZxjgzW/z5gMQQshoDFELAYAhZDwGIIWAwBiyFgMQQshoDFELAYAhZDwGII
# WAwBi6GPWH8CgF32YRApFSQAAAAASUVORK5CYII=
t/5_filter.t ....... 2/10
#   Failed test 'middle pixel should be red'
#   at t/5_filter.t line 48.
#     Structures begin differing at:
#          $got->[0] = '0.996108949416342'
#     $expected->[0] = '1'

#   Failed test 'there is blue outside'
#   at t/5_filter.t line 74.
#          got: '0'
#     expected: '1'
# PNG of the crisp window:
# iVBORw0KGgoAAAANSUhEUgAAASwAAADIAgMAAAAvsTTGAAAABGdBTUEAALGPC/xhBQAAACBjSFJN
# AAB6JgAAgIQAAPoAAACA6AAAdTAAAOpgAAA6mAAAF3CculE8AAAACVBMVEUAAP//AAD////1Ly4u
# AAAAAWJLR0QCZgt8ZAAAAEpJREFUaN7tzDEBAAAEADCaKaF/FRU8XFuARQAAz7I3yuVyuVwul8vl
# crlcLpfL5XK5XC6Xy+VyuVwul8vlcrlcLpfL5XK5AIALA0maWUZ3PuQtAAAAAElFTkSuQmCC
t/5_filter.t ....... 6/10
#   Failed test 'blue pixel should still be blue'
#   at t/5_filter.t line 95.
#     Structures begin differing at:
#          $got->[2] = '0'
#     $expected->[2] = '1'

#   Failed test 'red pixel should be immediatelly near blue one'
#   at t/5_filter.t line 107.
#     Structures begin differing at:
#          $got->[0] = '0'
#     $expected->[0] = '1'

#   Failed test 'sharp edge should be within blurred edge (1)'
#   at t/5_filter.t line 113.
#     '0'
#         <
#     '0'
# Looks like you failed 5 tests of 10.
t/5_filter.t ....... Dubious, test returned 5 (wstat 1280, 0x500)
Failed 5/10 subtests
t/90_MANIFEST.t .... ok
t/91_critic.t ...... skipped: Author test.  Set $ENV{TEST_AUTHOR} to a true value to run.

Test Summary Report
-------------------
t/2_transparent.t (Wstat: 768 Tests: 4 Failed: 3)
  Failed tests:  2-4
  Non-zero exit status: 3
t/5_filter.t     (Wstat: 1280 Tests: 10 Failed: 5)
  Failed tests:  2, 4, 6, 8-9
  Non-zero exit status: 5
Files=7, Tests=63,  4 wallclock secs ( 0.04 usr  0.02 sys +  1.17 cusr  0.64 csys =  1.87 CPU)
Result: FAIL
Failed 2/7 test programs. 8/63 subtests failed.
make: *** [Makefile:883: test_dynamic] Error 255
builder for '/nix/store/yz6vk18sapj606n4dppc1kv6fj8qxjwh-perl5.32.0-Gtk3-ImageView-6.drv' failed with exit code 2
error: build of '/nix/store/yz6vk18sapj606n4dppc1kv6fj8qxjwh-perl5.32.0-Gtk3-ImageView-6.drv' failed

Test became flaky in 6

make -j20 -l20 test TEST_VERBOSE=0                                                                                                                                                                                                                                                
PERL_DL_NONLAZY=1 "/usr/bin/perl" "-MExtUtils::Command::MM" "-MTest::Harness" "-e" "undef *Test::Harness::Switches; test_harness(0, 'blib/lib', 'blib/arch')" t/*.t                                                                                                               
GLib-LOG **: posix_spawn avoided (fd close requested)  at /usr/lib64/perl5/vendor_perl/5.30.3/Gtk3.pm line 555.                                                                                                                                                                   
===(       1;0   1/38  0/4  0/7  0/2   0/10 )===========================GLib-LOG **: posix_spawn avoided (fd close requested)  at /usr/lib64/perl5/vendor_perl/5.30.3/Gtk3.pm line 555.                                                                                           
===(       2;0   1/38  1/4  0/7  0/2   0/10 )===========================GLib-LOG **: posix_spawn avoided (fd close requested)  at /usr/lib64/perl5/vendor_perl/5.30.3/Gtk3.pm line 555.                                                                                           
===(       4;0   1/38  1/4  1/7  0/2   1/10 )===========================GLib-LOG **: posix_spawn avoided (fd close requested)  at /usr/lib64/perl5/vendor_perl/5.30.3/Gtk3.pm line 555.                                                                                           
        Gtk3::init() called at /usr/lib64/perl5/vendor_perl/5.30.3/Gtk3.pm line 2296                                                                                                                                                                                              
        Gtk3::__ANON__() called at /usr/lib64/perl5/vendor_perl/5.30.3/Gtk3.pm line 513                                                                                                                                                                                           
        Gtk3::import("Gtk3", "-init") called at t/4_select.t line 11                                                                                                                                                                                                              
        main::BEGIN() called at t/4_select.t line 11                                                                                                                                                                                                                              
        eval {...} called at t/4_select.t line 11                                                                                                                                                                                                                                 
===(       5;3   1/38  1/4  1/7  1/2   1/10 )===========================LOG **: Name com.canonical.AppMenu.Registrar does not exist on the session bus                                                                                                                            
# PNG of the shown window:                                                                                                                                                                                                                                                        
# iVBORw0KGgoAAAANSUhEUgAAASwAAADIAQAAAAB6pOH4AAAABGdBTUEAALGPC/xhBQAAACBjSFJN                                                                                                                                                                                                    
# AAB6JgAAgIQAAPoAAACA6AAAdTAAAOpgAAA6mAAAF3CculE8AAAAAmJLR0QAAd2KE6QAAAAHdElN                                                                                                                                                                                                    
# RQfkCxEWLDWpXYKQAAAAHklEQVRYw+3BMQEAAADCoPVPbQdvoAAAAAAAAADgNx54AAEXKN2ZAAAA                                                                                                                                                                                                    
# JXRFWHRkYXRlOmNyZWF0ZQAyMDIwLTExLTE3VDIyOjQ0OjUzKzAwOjAwhU5YPQAAACV0RVh0ZGF0                                                                                                                                                                                                    
# ZTptb2RpZnkAMjAyMC0xMS0xN1QyMjo0NDo1MyswMDowMPQT4IEAAAAASUVORK5CYII=                                                                                                                                                                                                       
                                                                                                                                                                                                                                                                                  
#   Failed test 'middle pixel should be green'                                                                                                                                                                                                                                    
#   at t/2_transparent.t line 58.                                                                                                                                                                                                                                                 
#     Structures begin differing at:                                                                                                                                                                                                                                              
#          $got->[1] = '0'                                                                                                                                                                                                                                                        
#     $expected->[1] = '1'                                                                                                                                                                                                                                                        
                                                                                                                                                                                                                                                                                  
#   Failed test 'there is red background'                                                                                                                                                                                                                                         
#   at t/2_transparent.t line 71.                                                                                                                                                                                                                                                 
#          got: '0'                                                                                                                                                                                                                                                               
#     expected: '1'                                                                                                                                                                                                                                                               
                                                                                                                                                                                                                                                                                  
#   Failed test 'there is blue outside'                                                                                                                                                                                                                                           
#   at t/2_transparent.t line 82.                                                                                                                                                                                                                                                 
#          got: '0'                                                                                                                                                                                                                                                               
#     expected: '1'                                                                                                                                                                                                                                                               
# Looks like you failed 3 tests of 4.                                                                                                                                                                                                                                             
t/2_transparent.t .. Dubious, test returned 3 (wstat 768, 0x300)                                                                                                                                                                                                                  
Failed 3/4 subtests                                                                                                                                                                                                                                                               
t/3_zoom.t ......... ok

Sometimes it still passes though

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.