Giter Club home page Giter Club logo

Comments (9)

carygravel avatar carygravel commented on September 16, 2024

On a bionic-based system, it is working for me, without my having done anything to fix it, as is the Gscan2pdf::ImageView version. I'll test my Debian testing based system next.

from gtk3-imageview.

DarthGandalf avatar DarthGandalf commented on September 16, 2024

It was you who noticed the issue at all. What system that was on?

But I confirm this behavior on Gentoo

from gtk3-imageview.

carygravel avatar carygravel commented on September 16, 2024

Just committed a fix for this.

from gtk3-imageview.

carygravel avatar carygravel commented on September 16, 2024

Is it time for a new release?

Or is there something you'd like to get in in the next couple of days?

from gtk3-imageview.

DarthGandalf avatar DarthGandalf commented on September 16, 2024

Tip: you could use "Closes #1" in commit message to close the issue automatically, and that would also link the commit here.

Sure, let's release. I wanted to do it some time ~soon anyway, to get #16 in.

from gtk3-imageview.

DarthGandalf avatar DarthGandalf commented on September 16, 2024

https://docs.github.com/en/free-pro-team@latest/github/managing-your-work-on-github/linking-a-pull-request-to-an-issue#linking-a-pull-request-to-an-issue-using-a-keyword has list of keywords it understands

from gtk3-imageview.

DarthGandalf avatar DarthGandalf commented on September 16, 2024

You forgot to push the master branch with v6

from gtk3-imageview.

carygravel avatar carygravel commented on September 16, 2024

You're right that Github hadn't registered it, but I did push it, with git push --tags, which on other repo pushes the commits, plus the tags. Github seems to need to have the commits first, and the tags afterwards in a second operation.

from gtk3-imageview.

DarthGandalf avatar DarthGandalf commented on September 16, 2024

I think this is not specific to Github, but because of git push --tags. git push --tags master would push both in a single operation.
Also, from man git-push:

When neither the command-line nor the configuration specify what to push, the default behavior is used, which corresponds to the simple value for push.default

Probably that's why it worked for you with 2 commands git push --tags; git push without explicitly mentioning master.

from gtk3-imageview.

Related Issues (13)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.