I think readme file should be updated with a text like:

Please note that rule definition in validation array not work with single | delimited string as:

$request->validate([
    'password' => 'bail|required|new StrongPassword',
]);

you have to use only array in validation definition like our code example.

someone still using sigle string in validation definition (like me in one project) and this can make confusion getting newStrongPassword don't exist error.

I'm trying to test for the validation.strong_password rule in my test, but none of the validation strings seem to be added to the validation array.

For instance, I have a test:

public function testSubmitPasswordResetPasswordTooShort()
    {
        $user = factory(User::class)->create([
            'password' => Hash::make(self::USER_ORIGINAL_PASSWORD),
        ]);

        $token = Password::broker()->createToken($user);

        $password = str_random(self::MIN_PASSWORD_LENGTH - 1);

        $this
            ->followingRedirects()
            ->from(route(self::ROUTE_PASSWORD_RESET, [
                'token' => $token,
            ]))
            ->post(route(self::ROUTE_PASSWORD_RESET_SUBMIT), [
                'token' => $token,
                'email' => $user->email,
                'password' => $password,
                'password_confirmation' => $password,
            ])
            ->assertSuccessful()
            ->assertSee(__('validation.strong_password', [
                'attribute' => 'password',
            ]));

        $user->refresh();

        $this->assertFalse(Hash::check($password, $user->password));

        $this->assertTrue(Hash::check(self::USER_ORIGINAL_PASSWORD,
            $user->password));
    }

but validation.strong_password doesn't return anything.

Should I manually add all the rules to my lang\en\validation.php?

In selections, ID should be exists or 0 for roots!
For example in category, there is parent_id column, so, in root categories parent_id is 0.
I have been searching for such exists_or_zero validation method with no success.

#9

Reference for Kosovo: https://en.wikipedia.org/wiki/Kosovo

Not sure why you opted to add another disposable email validation rule since there already exists one: https://github.com/Propaganistas/Laravel-Disposable-Email

When I install the package with composer:

composer require mattkingshott/axiom

I don't have problem, but when I try to import into project a rule it don't work.
I have noted that into vendor dir the namespaces is

namespace Alphametric\Validation\Rules;

see attached images of my editor.
I have already tried to remove and reinstall the package, dump-autoload in composer and refresh my dirs.

Installing on production we receive this error:

Deprecation Notice: Class Alphametric\Validation\Rules\Misc\Iso3166Alpha3 located in ./vendor/alphametric/laravel-validation-rules/src/misc/Iso3166Alpha3.php does not comply with psr-4 autoloading standard. It will not autoload anymore in Composer v2.0. in phar:///usr/local/bin/composer/src/Composer/Autoload/ClassMapGenerator.php:201

Deprecation Notice: Class Alphametric\Validation\Rules\Misc\Iso3166Alpha2 located in ./vendor/alphametric/laravel-validation-rules/src/misc/Iso3166Alpha2.php does not comply with psr-4 autoloading standard. It will not autoload anymore in Composer v2.0. in phar:///usr/local/bin/composer/src/Composer/Autoload/ClassMapGenerator.php:201

Citizen identification mixes capitalisation and length from country code validation rules in same repo (laravel-validation-rules).

Which means that :=
Using 'US' for country code passes but fails citizen identification rule.
Using 'USA' for country code passes both rules.
Using 'GB' for country code passes but fails citizen identification rule.
Using 'GBR' for country code passes but fails citizen identification rule.
Using 'UK' for country code fails but passes citizen identification rule.
Using 'FR' for country code passes both rules.
Using 'FRA' for country code passes but fails citizen identification rule.

Expected behaviour :=
A form submitted from a web site using a single field for (country code/name) will pass or fail consistently including error messages.

Note : because
'GB' => 'United Kingdom of Great Britain and Northern Ireland',
'GBR' => 'United Kingdom',
A bug can be created when refactoring the country list for use outside of dedicated rules, because
assertTrue($country->setCountry('GB')->name(),$country->setCountry('GBR')->name());
will fail.

CitizenIdentification uses
The identification type to use ('usa', 'uk', 'fr').
where as
CountryCode uses
Array of countries with their ISO 3166-1 alpha-2 codes.

• 'FR' => 'France',
• 'GB' => 'United Kingdom of Great Britain and Northern Ireland',
• 'US' => 'United States of America',

Array of countries with their ISO 3166-1 alpha-3 codes.

• 'FRA' => 'France',
• 'GBR' => 'United Kingdom',
• 'USA' => 'United States of America',

I have done fresh install of package, and when testing country code validation, the default validation message defined in the class is not returned, rather returns validation.country_code message.

This can be fixed on user side by defining a language file entry for given rule.

However, to make use of the default message defined in the package, it need to fix a check in the helper class

public static function getLocalizedErrorMessage($key, $default)
{
    return trans("validation.$key") === $key ? $default : trans("validation.$key");
}

should be

public static function getLocalizedErrorMessage($key, $default)
{
    return trans("validation.$key") === "validation.$key" ? $default : trans("validation.$key");
}

In initial comparison the result of translation has a validation. prefix which is not there in the key, thus will always return false and not return default message

Hi there and first thx for your work !

I directly installed 2.1 without older version before.
"use Axiom... " doesn't work
Namespace hasn't updated and I have to use the old one "Alphametric..."

Adding the following test cases to DomainTest fails:

$this->assertFalse(validator(['domain' => 'google'], $rule)->passes()); // fails
$this->assertFalse(validator(['domain' => 1], $rule)->passes()); // fails

Hello! I think telephone number rule could be extended to support more countries by wrapping this lib: https://github.com/giggsey/libphonenumber-for-php.

Mu suggestion is to make it work like the citizen identification validation, where the country code is passed in and the validation occurs based on the country.

We could also validate not only if phone numbers are correct but also types. (Fixed-line, Mobile, Toll-free, Premium Rate, Shared Cost, VoIP and Personal Numbers)

Do you think it's a good addition to this package?

Hi there !

I got the ParseError above when I did
protected function validator(array $data) { return Validator::make($data, [ 'login' => ['required', 'string', 'max:255', new WithoutWhitespace] ]); }

My setup :

• Laravel 7
• php 7.4.6
• axiom 3.1

Edit : I tried using another validator rule (the TelephoneNumber one) from your package but got the same error.
Did I make something wrong ?

Thx for your answer !

Readme file is not synced with last changes, e.g. CountryCode and LanguageCode rules are not present in it. Should be updated accordingly.