Comments (2)
Sounds good!
from axiom.
Hey!
I'm familiar with the package yes, I've used it in other projects.
I think the existing rule is valid for basic checks, however I can see value in using more sophisticated checking when that is required.
I think we'd need to ensure that the current approach would continue to work so that existing apps won't break. However, it should be possible, because we only need to check for the presence of parameters. If none are supplied, we can fall back to the simple regex that is being used at the moment.
Otherwise, if the developer has supplied parameters, we can plug those into libphonenumber.
If you'd like to submit a PR, I'd be happy to take a look at it.
Thanks so much for contributing!
from axiom.
Related Issues (14)
- Package for disposable email validation rule HOT 1
- Republic of Kosovo missing in the ISO3166 file HOT 1
- Exists or 0 HOT 2
- Validation rules missing during tests? HOT 2
- Readme file should be updated with a note HOT 1
- Composer deprecation notice HOT 1
- Readme file should be updated with new added rules HOT 1
- Namespace error HOT 2
- New namespace "Axiom" doesn't work on 2.1 HOT 2
- Rule syntax error, unexpected 'array' (T_ARRAY), expecting function (T_FUNCTION) or const (T_CONST) HOT 8
- Inconsistent country coding HOT 1
- Domain validation rule is faulty (I think) HOT 2
- Default validation messages defined in rule classes not working HOT 1
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from axiom.