Giter Club home page Giter Club logo

Comments (2)

guiassemany avatar guiassemany commented on August 30, 2024 1

Sounds good!

from axiom.

mattkingshott avatar mattkingshott commented on August 30, 2024

Hey!

I'm familiar with the package yes, I've used it in other projects.

I think the existing rule is valid for basic checks, however I can see value in using more sophisticated checking when that is required.

I think we'd need to ensure that the current approach would continue to work so that existing apps won't break. However, it should be possible, because we only need to check for the presence of parameters. If none are supplied, we can fall back to the simple regex that is being used at the moment.

Otherwise, if the developer has supplied parameters, we can plug those into libphonenumber.

If you'd like to submit a PR, I'd be happy to take a look at it.

Thanks so much for contributing!

from axiom.

Related Issues (14)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.