broccoli-sane-watcher's Issues
Possible to have multiple filePaths trigger change, but only one is reported
When a change is detected, the watcher builds and then
- appends the filepath that triggered the change
- emits a
change
event with the resultshash
that includes thefilePath
that changed and triggered the build
Because the build is debounced, it's possible for multiple files to change before the build starts, but only the first one will get reported in the results hash filePath
property.
This can be demonstrated by changing two files very quickly, e.g.:
touch path/to/a.js && touch path/to/b.js
-> broccoli-sane-watcher emits change with{filePath: path/to/a.js}
touch path/to/b.js && touch path/to/a.js
-> broccoli-sane-watcher emits change with{filePath: path/to/b.js}
I'm not sure how "public" the filePath
property on the hash is considered to be, but the livereload server in ember-cli does use that property to determine whether it should trigger a livereload notification in the shouldTriggerReload
method.
If it seems like a good idea to gather all the filepaths that changed before the build started and report them in a filePaths
property on the results hash
I would be happy to make a PR for that.
including all of broccoli (4MB) just for the logging
enable travis
cc @krisselden
how to use with broccoli-cli
Any info on how to use this with broccoli-cli?
(current broccoli-cli idles at ~37%)
Incorporate https://github.com/ember-cli/broccoli-sane-watcher/pull/8
This enables:
- understanding why a build happened
- logging via
DEBUG=broccoli-sane-watcher*
- enable wrapping tooling to provide better information.
including tests in NPM distrubtion
installing this module causes warnings
npm WARN engine makeerror@1.0.10: wanted: {"node":"0.6.x"} (current: {"node":"1.6.2","npm":"2.7.3"})
npm WARN engine tmpl@1.0.3: wanted: {"node":"0.6.x"} (current: {"node":"1.6.2","npm":"2.7.3"})
I've submitted PR's to the offending dependencies
Once they update, someone (me if I notice it) should update this module accordingly.
utilized ready event
tag releases please
includes tests/* by mistake in publish
How to integrate this as watcher in broccoli?
I can't find any docs on broccoli-sane-watcher, is it meant to integrate it in the Brocfile.js
or the cli
?
We have broccoli running with some people on one dev-server, and it consumes almost all the CPU.
potential issue: redundant dir watching
FYI: Quick pass at upgrading to broccoli v1.0.0-beta.5
Comparison of master against my forked branch: master...timmfin:move-to-broccoli-v1
This was a very quick "brute force" pass. but it got me going locally. Maybe this helps (but if not no biggie... just figured I'd FYI you on my changes).
potential Instability when filters throw
I am unsure if it is this watcher, but since introducing it we seem to kill the build when a filter fails. For example if es6-validate-import fails to parse the JS. The build breaks, and we are unable to recover without restarting ember-cli
auto detect best watching mechanism
- maybe sane will add support -> amasad/sane#31
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
๐ Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. ๐๐๐
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google โค๏ธ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.